PiedWeb\SeoPocketCrawler\CrawlerRestart::getHarvest()

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes

0

<?php
    protected function getHarvest(Url $url)
    {
        if (true === $this->fromCache) {
            $filePath = $this->recorder->getCacheFilePath($url);
            if (file_exists($filePath)) {
                $response = new ResponseFromCache(
                    $filePath,

It seems like $filePath can also be of type null; however, parameter $filePathOrContent of PiedWeb\Curl\ResponseFromCache::__construct() does only seem to accept string, maybe add an additional type check?

                    $this->base.$url->uri,
                    json_decode(file_get_contents($filePath.'---info'), true)
                );

                return new Harvest($response);
            }
        }

        return parent::getHarvest($url);
    }