PiedWeb\SeoPocketCrawler\Recorder

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Test Coverage

Coverage

76.19%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	recordOutboundLink()	0	4	1
A	record()	0	12	2
A	recordInboundLink()	0	3	1

<?php

namespace PiedWeb\SeoPocketCrawler;

class Recorder
{
    public function __construct($folder)
    {
        $this->folder = $folder;

The property folder does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function record(array $urls)
    {
        $fp = fopen($this->folder.'/index.csv', 'w');

        $header = array_keys(get_object_vars(array_values($urls)[0]));
        fputcsv($fp, $header);

It seems like $fp can also be of type false; however, parameter $handle of fputcsv() does only seem to accept resource, maybe add an additional type check?

        foreach ($urls as $url) {
            fputcsv($fp, get_object_vars($url));
        }

        fclose($fp);

It seems like $fp can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

    }

    public function recordInboundLink(Url $from, Url $to)
    {
        file_put_contents($this->folder.'/links/To_'.$to->sha1.'.txt', $from->uri, FILE_APPEND);
    }

    public function recordOutboundLink(Url $from, array $links)
    {
        $links = array_map(function ($link) { return $link->getUrl(); }, $links);
        file_put_contents($this->folder.'/links/From_'.$from->sha1.'.txt', implode(PHP_EOL, $links));
    }
}