PiedWeb\Curl\StaticWrapperTrait::get()

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function get(string $url)
    {
        $request = new self($url);

The call to PiedWeb\Curl\StaticWrapperTrait::__construct() has too many arguments starting with $url.

        $request
            ->setDefaultGetOptions()

It seems like setDefaultGetOptions() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ->setDefaultSpeedOptions()
            ->setNoFollowRedirection()
            ->setDesktopUserAgent()
        ;

        $response = $request->exec();

It seems like exec() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return is_int($response) ? $response : $response->getContent();
    }