PageScannerService::getLinksCheckedCounter() - Code Metrics - Inspection of "Fix psalm error" - PiedWeb/CMS - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 4017d9...9757db )

by Dev
created 2020-12-13 17:01 UTC
PageScannerService::getLinksCheckedCounter() A

↳ Parent: PageScannerService
Complexity

Conditions	1
Paths	1
Size

Total Lines	3
Code Lines	1
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0
<?php

namespace PiedWeb\CMSBundle\Extension\PageScanner;

use Doctrine\ORM\EntityManagerInterface;
use PiedWeb\CMSBundle\Entity\PageInterface;
use PiedWeb\CMSBundle\Service\AppConfigHelper;
use PiedWeb\CMSBundle\Utils\GenerateLivePathForTrait;
use PiedWeb\CMSBundle\Utils\KernelTrait;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\KernelInterface;
use Symfony\Component\Routing\RouterInterface;
use Twig\Environment as Twig_Environment;

/**
 * Permit to find error in image or link.
 */
class PageScannerService
{
    use GenerateLivePathForTrait;
    use KernelTrait;

    /**
     * @var AppConfigHelper
     */
    protected $app;

    protected $em;
    protected $pageHtml;
    protected $twig;
    protected $currentPage;
    protected $webDir;
    protected $apps;
    protected $linksCheckedCounter = 0;
    protected $errors = [];
    protected $everChecked = [];
    public static $appKernel;

    public function __construct(
        Twig_Environment $twig,
        EntityManagerInterface $em,
        string $webDir,
        array $apps,
        RouterInterface $router,
        KernelInterface $kernel
    ) {
        $this->twig = $twig;
        $this->router = $router;
        $this->em = $em;
        $this->webDir = $webDir;
        $this->apps = $apps;

        static::loadKernel($kernel);
    }

    protected function resetErrors()
    {
        $this->errors = [];
    }

    public function scan(PageInterface $page)
    {
        $this->app = new AppConfigHelper($page->getHost(), $this->apps);
        $this->currentPage = $page;
        $this->resetErrors();
        $this->pageHtml = '';

        if (false !== $page->getRedirection()) {
            // check $page->getRedirection() return 20X

            return true; // or status code
        }

        $liveUri = $this->generateLivePathFor($page);
        $this->pageHtml = $this->getHtml($liveUri);

        // 2. Je récupère tout les liens et je les check
        // href="", data-rot="" data-img="", src="", data-bg
        if ($this->pageHtml) {
            $this->checkLinkedDocs($this->getLinkedDocs());
        }

        return empty($this->errors) ? true : $this->errors;
    }

    protected function getHtml($liveUri)
    {
        $request = Request::create($liveUri);
        $response = static::$appKernel->handle($request);

        if ($response->isRedirect()) {
            $linkedDocs[] = $response->headers->get('location');


            return;
        } elseif (200 != $response->getStatusCode()) {
            $this->addError('error on generating the page ('.$response->getStatusCode().')');
            exit;


            return;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        return $response->getContent();
    }

    protected function addError($message)
    {
        $this->errors[] = [
            'message' => $message,
            'page' => $this->currentPage,
        ];
    }

    protected static function prepareForRegex($var)
    {
        if (\is_string($var)) {
            return preg_quote($var, '/');
        }

        $var = array_map('static::prepareForRegex', $var);

        return '('.implode('|', $var).')';
    }

    protected static function isWebLink(string $url)
    {
        return preg_match('@^((?:(http:|https:)//([\w\d-]+\.)+[\w\d-]+){0,1}(/?[\w~,;\-\./?%&+#=]*))$@', $url);
    }

    protected function getLinkedDocs(): array
    {
        $urlInAttributes = ' '.self::prepareForRegex(['href', 'data-rot', 'src', 'data-img', 'data-bg']);
        $regex = '/'.$urlInAttributes.'=((["\'])([^\3]+)\3|([^\s>]+)[\s>])/iU';
        preg_match_all($regex, $this->pageHtml, $matches);

        $linkedDocs = [];
        for ($k = 0; $k < \count($matches[0]); ++$k) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $uri = isset($matches[4][$k]) ? $matches[4][$k] : $matches[5][$k];
            $uri = 'data-rot' == $matches[1][$k] ? str_rot13($uri) : $uri;
            $uri = strtok($uri, '#');
            $uri = $this->removeBase($uri);
            if ('' !== $uri && self::isWebLink($uri)) {
                $linkedDocs[] = $uri;
            }
        }

        return array_unique($linkedDocs);
    }

    protected function removeBase($url)
    {
        if (0 === strpos($url, 'https://'.$this->app->getMainHost())) {
            return substr($url, \strlen('https://'.$this->app->getMainHost()));
        }

        return $url;
    }

    public function getLinksCheckedCounter()
    {
        return $this->linksCheckedCounter;
    }

    protected function checkLinkedDocs(array $linkedDocs)
    {
        foreach ($linkedDocs as $uri) {
            ++$this->linksCheckedCounter;
            if (!\is_string($uri)) {
                continue;
            }
            if (('/' == $uri[0] && !$this->uriExist($uri))
                || (0 === strpos($uri, 'http') && !$this->urlExist($uri))) {
                $this->addError('<code>'.$uri.'</code> introuvable');
            }
        }
    }

    protected function urlExist($uri)
    protected function urlExist(/** @scrutinizer ignore-unused */ $uri)
    {
        // todo check external resource
        return true;
    }

    protected function uriExist($uri)
    {
        $slug = ltrim($uri, '/');

        if (isset($this->everChecked[$slug])) {
            return $this->everChecked[$slug];
        }

        $checkDatabase = 0 !== strpos($slug, 'media/'); // we avoid to check in db the media, file exists is enough
        $page = true !== $checkDatabase ? null : $this->em->getRepository(\get_class($this->currentPage))
            ->findOneBy(['slug' => '' == $slug ? 'homepage' : $slug]); // todo add domain check (currentPage domain)

        $this->everChecked[$slug] = (
            null === $page
                && !file_exists($this->webDir.'/'.$slug)
                && 'feed.xml' !== $slug
        ) ? false : true;

        return $this->everChecked[$slug];
    }
}

PiedWeb / CMS

Push — master ( 4017d9...9757db )

PageScannerService::getLinksCheckedCounter() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
