PiedWeb\CMSBundle\Entity\RedirectionTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	manageRedirection()	0	17	4
A	getRedirection()	0	7	2
A	getRedirectionCode()	0	7	2

<?php

namespace PiedWeb\CMSBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use Cocur\Slugify\Slugify;
use Gedmo\Mapping\Annotation as Gedmo;

trait RedirectionTrait
{
    protected $redirectionUrl;
    protected $redirectionCode;

    /**
     * Check if a content don't start by 'Location: http://valid-url.tld/eg'.
     */
    protected function manageRedirection()
    {
        $content = $this->getMainContent();

It seems like getMainContent() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $code = 301; // default symfony is 302...
        if ('Location:' == substr($content, 0, 9)) {
            $url = trim(substr($content, 9));
            if (preg_match('/ [1-5][0-9]{2}$/', $url, $match)) {
                $code = intval(trim($match[0]));
                $url = preg_replace('/ [1-5][0-9]{2}$/', '', $url);
            }
            if (filter_var($url, FILTER_VALIDATE_URL)) {
                $this->redirectionUrl  = $url;
                $this->redirectionCode = $code;
            }
        }

        $this->redirectionUrl  = false;
    }

    public function getRedirection()
    {
        if ($ths->redirectionUrl === null) {

The variable $ths seems to be never defined.

            $this->manageRedirection();
        }

        return $this->redirectionUrl;
    }

    public function getRedirectionCode()
    {
        if ($ths->redirectionUrl === null) {

The variable $ths seems to be never defined.

            $this->manageRedirection();
        }

        return $this->redirectionCode;
    }
}