PageController::show() - Code Metrics - Inspection of "try to repair sctnzr" - PiedWeb/CMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6130d0...57338d )

by Dev

created 2020-03-14 10:13 UTC

PageController::show() B

↳ Parent: PageController

Complexity

Conditions	10
Paths	44

Size

Total Lines	40
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	17
nc	44
nop	4
dl	0
loc	40
ccs	0
cts	28
cp	0
crap	110
rs	7.6666
c	1
b	0
f	0

How to fix Complexity

<?php

namespace PiedWeb\CMSBundle\Controller;

use PiedWeb\CMSBundle\Entity\PageInterface as Page;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Translation\TranslatorInterface;

class PageController extends AbstractController
{
    protected $translator;

    public function show(
        ?string $slug,
        Request $request,
        TranslatorInterface $translator,
        ParameterBagInterface $params
    ) {
        $slug = (null === $slug || '' === $slug) ? 'homepage' : rtrim(strtolower($slug), '/');
        $page = $this->getDoctrine()
            ->getRepository($this->container->getParameter('app.entity_page'))
            ->getRepository($this->container->/** @scrutinizer ignore-call */ getParameter('app.entity_page'))
            ->findOneBySlug($slug);
            ->/** @scrutinizer ignore-call */ findOneBySlug($slug);

        // Check if page exist
        if (null === $page) {
            throw $this->createNotFoundException();
        }

        if (null !== $page->getLocale()) { // avoid bc break, todo remove it
            $request->setLocale($page->getLocale());
        }

        // Check if page is public
        if ($page->getCreatedAt() > new \DateTimeImmutable() && !$this->isGranted('ROLE_ADMIN')) {
            throw $this->createNotFoundException();
        }

        // SEO redirection if we are not on the good URI (for exemple /fr/tagada instead of /tagada)
        $redirect = $this->checkIfUriIsCanonical($request, $page);
        if (false !== $redirect) {
            return $this->redirect($redirect[0], $redirect[1]);
        }

        // Maybe the page is a redirection
        if (false !== $page->getRedirection()) {
            return $this->redirect($page->getRedirection(), $page->getRedirectionCode());
        }

        // method_exists($this->container->getParameter('app.entity_page'), 'getTemplate') &&
        $template = null !== $page->getTemplate() ? $page->getTemplate() : $params->get('app.default_page_template');

        return $this->render($template, ['page' => $page]);
    }

    protected function checkIfUriIsCanonical($request, $page)
    {
        $real = $request->getRequestUri();

        $expected = 'homepage' == $page->getSlug() ?
            $this->get('piedweb.page_canonical')->generatePathForHomepage() :
            $this->get('piedweb.page_canonical')->generatePathForPage($page->getRealSlug());

        if ($real != $expected) {
            return [$request->getBasePath().$expected, 301];
        }

        return false;
    }

    public function preview(
        ?string $slug,
        Request $request
    ) {
        $pageEntity = $this->container->getParameter('app.entity_page');

        $page = (null === $slug || '' === $slug) ?
            new $pageEntity()
            : $this->getDoctrine()
            ->getRepository($pageEntity)
            ->findOneBySlug(rtrim(strtolower($slug), '/'));

        $plainText = \PiedWeb\CMSBundle\Twig\AppExtension::convertMarkdownImage($request->request->get('plaintext'));

        return $this->render('@PiedWebCMS/admin/preview.html.twig', ['page' => $page, 'plainText' => $plainText]);
    }

    public function feed(
        ?string $slug,
        Request $request,
        /** @scrutinizer ignore-unused */ Request $request,
        TranslatorInterface $translator,
        /** @scrutinizer ignore-unused */ TranslatorInterface $translator,
        ParameterBagInterface $params
        /** @scrutinizer ignore-unused */ ParameterBagInterface $params
    ) {
        $slug = (null === $slug || '' === $slug) ? 'homepage' : rtrim(strtolower($slug), '/');
        $page = $this->getDoctrine()
            ->getRepository($this->container->getParameter('app.entity_page'))
            ->findOneBySlug($slug);

        // Check if page exist
        if (null === $page || $page->getChildrenPages()->count() < 1) {
            throw $this->createNotFoundException();
        }

        // Check if page is public
        if ($page->getCreatedAt() > new \DateTimeImmutable() && !$this->isGranted('ROLE_ADMIN')) {
            throw $this->createNotFoundException();
        }

        $response = new Response();
        $response->headers->set('Content-Type', 'text/xml');

        return $this->render('@PiedWebCMS/page/rss.xml.twig', ['page' => $page], $response);
    }
}


PiedWeb / CMS

Push — master ( 6130d0...57338d )

PageController::show() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like