PageController::getPages() - Code Metrics - Inspection of "test 4 controller" - PiedWeb/CMS - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed
Push — master ( 304e55...90978a )

by Dev
created 2020-12-15 09:58 UTC
PageController::getPages() A

↳ Parent: PageController
Complexity

Conditions	1
Paths	1
Size

Total Lines	17
Code Lines	9
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes
Metric	Value
cc	1
eloc	9
nc	1
nop	2
dl	0
loc	17
ccs	0
cts	0
cp	0
crap	2
rs	9.9666
c	0
b	0
f	0
<?php

namespace PiedWeb\CMSBundle\Controller;

use PiedWeb\CMSBundle\Entity\PageInterface as Page;
use PiedWeb\CMSBundle\Repository\PageRepository;
use PiedWeb\CMSBundle\Service\AppConfigHelper as App;
use PiedWeb\CMSBundle\Service\Repository;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class PageController extends AbstractController
{
    /**
     * @var ParameterBagInterface
     */
    protected $params;

    /**
     * @var App
     */
    protected $app;

    public function __construct(
        ParameterBagInterface $params
    ) {
        $this->params = $params;
        $this->app = App::load(null, $this->params);
    }

    public function show(?string $slug, ?string $host, Request $request): Response
    {
        $page = $this->getPage($slug, $host, $request);

        // SEO redirection if we are not on the good URI (for exemple /fr/tagada instead of /tagada)
        if ((null === $host || $host == $request->getHost())
            && false !== $redirect = $this->checkIfUriIsCanonical($request, $page)) {
            return $this->redirect($redirect[0], $redirect[1]);
        }

        // Maybe the page is a redirection
        if ($page->getRedirection()) {
            return $this->redirect($page->getRedirection(), $page->getRedirectionCode());
        }

        $template = $this->app->getDefaultTemplate();

        return $this->render($template, array_merge(['page' => $page], $this->app->getParamsForRendering()));
    }

    public function preview(?string $slug, ?string $host, Request $request): Response
    {
        $page = $this->getPage($slug, $host, $request);
        $page->setMainContent($request->request->get('plaintext'));
        // todo update all fields to avoid errors with autosave
        // (getting them via json?!)
        // And not getPage but create a new Page !!! (else, error on unexisting Page)

        return $this->render(
            '@PiedWebCMS/page/preview.html.twig',
            array_merge(['page' => $page], $this->app->getParamsForRendering())
        );
    }

    public function showFeed(?string $slug, ?string $host, Request $request)
    public function showFeed(?string $slug, ?string $host, /** @scrutinizer ignore-unused */ Request $request)
    {
        $page = $this->getPage($slug, $host);
        $page = $this->getPage($slug, $host);

        if ('homepage' == $slug) {
            return $this->redirect($this->generateUrl('piedweb_cms_page_feed', ['slug' => 'index']), 301);
        }

        $response = new Response();
        $response->headers->set('Content-Type', 'text/xml');

        return $this->render(
            '@PiedWebCMS/page/rss.xml.twig',
            array_merge(['page' => $page], $this->app->getParamsForRendering()),
            $response
        );
    }

    /**
     * Show Last created page in an XML Feed.
     */
    public function showMainFeed(?string $host, Request $request)
    {
        $this->app->switchCurrentApp($host);
        $locale = $request->getLocale() ? rtrim($request->getLocale(), '/') : $this->params->get('locale');
        $LocaleHomepage = $this->getPage($locale, $host, $request, false);
        $slug = 'homepage';
        $page = $LocaleHomepage ? $LocaleHomepage : $this->getPage($slug, $host, $request);

        $params = [
            'pages' => $this->getPages(5, $request),
            'page' => $page,
            'feedUri' => ($this->params->get('locale') == $locale ? '' : $locale.'/').'feed.xml',
        ];

        return $this->render('@PiedWebCMS/page/rss.xml.twig', array_merge($params, $this->app->getParamsForRendering()));
    }

    public function showSitemap($_format, ?string $host, Request $request)
    {
        $this->app->switchCurrentApp($host);
        $pages = $this->getPages(null, $request);

        if (!$pages) {
            throw $this->createNotFoundException();
        }

        return $this->render('@PiedWebCMS/page/sitemap.'.$_format.'.twig', [
            'pages' => $pages,
            'app_base_url' => $this->app->getBaseUrl(),
        ]);
    }

    protected function getPages(?int $limit = null, Request $request)
    {
        $requestedLocale = rtrim($request->getLocale(), '/');
        //var_dump($requestedLocale);exit;

        $pages = $this->getPageRepository()->getIndexablePages(
                $this->app->getHost(),
                $this->app->isFirstApp(),
                $requestedLocale,
                $this->params->get('locale'),
                $limit
            )->getQuery()->getResult();

        //foreach ($pages as $page) echo $page->getMetaRobots().' '.$page->getTitle().'<br>';
        //exit('feed updated');

        return $pages;
    }

    /**
     * @return PageRepository
     */
    protected function getPageRepository()
    {
        return Repository::getPageRepository($this->getDoctrine(), $this->params->get('pwc.entity_page'));
    }

    protected function getPage(?string &$slug, ?string $host = null, ?Request $request, $throwException = true): ?Page
    protected function getPage(?string &$slug, ?string $host = null, /** @scrutinizer ignore-unused */ ?Request $request, $throwException = true): ?Page
    {
        $this->app->switchCurrentApp($host);
        $slug = $this->noramlizeSlug($slug);
        $page = $this->getPageRepository()->getPage($slug, $this->app->getHost(), $this->app->isFirstApp());

        // Check if page exist
        if (null === $page) {
            if ($throwException) {
                throw $this->createNotFoundException();
            } else {
                return null;
            }
        }

        if (!$page->getLocale()) { // avoid bc break
            $page->setLocale($this->params->get('pwc.locale'));
        }

        //if (null !== $request) { $request->setLocale($page->getLocale()); }
        $this->get('translator')->setLocale($page->getLocale());

        // Check if page is public
        if ($page->getCreatedAt() > new \DateTimeImmutable() && !$this->isGranted('ROLE_EDITOR')) {
            if ($throwException) {
                throw $this->createNotFoundException();
            } else {
                return null;
            }
        }

        return $page;
    }

    protected function noramlizeSlug($slug)
    {
        return (null === $slug || '' === $slug) ? 'homepage' : rtrim(strtolower($slug), '/');
    }

    protected function checkIfUriIsCanonical(Request $request, Page $page)
    {
        $real = $request->getRequestUri();

        $expected = 'homepage' == $page->getSlug() ?
            $this->get('piedweb.page_canonical')->generatePathForHomepage() :
            $this->get('piedweb.page_canonical')->generatePathForPage($page->getRealSlug());

        if ($real != $expected) {
            return [$request->getBasePath().$expected, 301];
        }

        return false;
    }
}

PiedWeb / CMS

Push — master ( 304e55...90978a )

PageController::getPages() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
