Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | class GeoFixerFacade |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @var KLogger\Logger |
||
| 19 | */ |
||
| 20 | private $logger; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var GeoFixer |
||
| 24 | */ |
||
| 25 | private $geo; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Инициализируем (если передан параметр) БД и логирование |
||
| 29 | * |
||
| 30 | * GeoFixerFacade constructor. |
||
| 31 | * @param bool $fias |
||
| 32 | * @param bool $logger |
||
| 33 | * @param array $config |
||
| 34 | */ |
||
| 35 | 4 | public function __construct($fias = false, $logger = false, $config = null) |
|
| 57 | |||
| 58 | /** |
||
| 59 | * Поиск похожих слов в массиве |
||
| 60 | * Логирование ошибок |
||
| 61 | * |
||
| 62 | * @param $word |
||
| 63 | * @param $search_array |
||
| 64 | * @param bool $strict_search |
||
| 65 | * |
||
| 66 | * @return string|false |
||
| 67 | */ |
||
| 68 | 3 | public function findSimilarWord($word, $search_array, $strict_search = false) |
|
| 82 | |||
| 83 | /** |
||
| 84 | * Поиск кода региона в базе КЛАДР |
||
| 85 | * Логирование ошибок |
||
| 86 | * |
||
| 87 | * @param $region |
||
| 88 | * @param bool $first_letters |
||
| 89 | * @param bool $strict_search |
||
| 90 | * |
||
| 91 | * @return string|false |
||
| 92 | */ |
||
| 93 | 5 | public function findKladrRegion($region, $first_letters = false, $strict_search = false) |
|
| 105 | |||
| 106 | /** |
||
| 107 | * Поиск кода региона в базе ФИАС |
||
| 108 | * Логирование ошибок |
||
| 109 | * |
||
| 110 | * @param $region |
||
| 111 | * @param bool $first_letters |
||
| 112 | * @param bool $strict_search |
||
| 113 | * |
||
| 114 | * @return string|false |
||
| 115 | */ |
||
| 116 | 8 | public function findFiasRegion($region, $first_letters = false, $strict_search = false) |
|
| 133 | |||
| 134 | /** |
||
| 135 | * Поиск ID городов, или ID городов и поселений по коду региона в базе ФИАС |
||
| 136 | * Логирование ошибок |
||
| 137 | * |
||
| 138 | * @param $city |
||
| 139 | * @param $region_code |
||
| 140 | * @param bool $first_letters |
||
| 141 | * @param bool $strict_search |
||
| 142 | * |
||
| 143 | * @return string|false |
||
| 144 | */ |
||
| 145 | 4 | View Code Duplication | public function findFiasSettlement($city, $region_code, $first_letters = false, $strict_search = false, $full_settlements = false) |
| 163 | |||
| 164 | /** |
||
| 165 | * Поиск ID городов, или ID городов и поселений по коду региона в базе КЛАДР |
||
| 166 | * Логирование ошибок |
||
| 167 | * |
||
| 168 | * @param $city |
||
| 169 | * @param $region_code |
||
| 170 | * @param bool $first_letters |
||
| 171 | * @param bool $strict_search |
||
| 172 | * |
||
| 173 | * @return string|false |
||
| 174 | */ |
||
| 175 | 5 | public function findKladrSettlement($city, $region_code, $first_letters = false, $strict_search = false, $full_settlements = false) |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Поиск ID улицы по ID города в базе ФИАС |
||
| 198 | * Логирование ошибок |
||
| 199 | * |
||
| 200 | * @param $street |
||
| 201 | * @param $city_id |
||
| 202 | * @param bool $first_letters |
||
| 203 | * @param bool $strict_search |
||
| 204 | * |
||
| 205 | * @return string|false |
||
| 206 | */ |
||
| 207 | 3 | View Code Duplication | public function findFiasStreet($street, $city_id, $first_letters = false, $strict_search = false) |
| 224 | |||
| 225 | /** |
||
| 226 | * Поиск кода улицы по коду города в базе КЛАДР |
||
| 227 | * Логирование ошибок |
||
| 228 | * |
||
| 229 | * @param $street |
||
| 230 | * @param $city_code |
||
| 231 | * @param bool $first_letters |
||
| 232 | * @param bool $strict_search |
||
| 233 | * |
||
| 234 | * @return string|false |
||
| 235 | */ |
||
| 236 | 4 | View Code Duplication | public function findKladrStreet($street, $city_code, $first_letters = false, $strict_search = false) |
| 253 | |||
| 254 | |||
| 255 | /** |
||
| 256 | * Поиск ID дома по ID улицы в базе ФИАС |
||
| 257 | * |
||
| 258 | * @param $house |
||
| 259 | * @param $street_id |
||
| 260 | * @param bool $building |
||
| 261 | * |
||
| 262 | * @return string|false |
||
| 263 | */ |
||
| 264 | 4 | public function findFiasHouse($house, $street_id, $building = false) |
|
| 280 | } |
||
| 281 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..