GeoFixer\models\GeoFixer

Complexity

Total Complexity

35

Size/Duplication

Total Lines	270
Duplicated Lines	17.04 %

Coupling/Cohesion

Components	2
Dependencies	6

Test Coverage

Coverage

97.25%

Importance

Changes	3
Bugs	0	Features	1

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	isStrict()	0	4	1
A	isFullSettlements()	0	4	1
B	findFiasRegion()	0	23	4
A	findSimilarWord()	0	19	4
B	findFiasSettlements()	23	23	4
B	findKladrSettlements()	0	30	5
B	findFiasStreets()	23	23	4
B	findKladrStreets()	0	37	6
A	findFiasHouses()	0	13	3
A	isFirstLetters()	0	6	2

<?php

namespace GeoFixer\models;

use GeoFixer\models\queries\RegionsDatabaseQuery;
use GeoFixer\models\queries\SettlementsDatabaseQuery;
use GeoFixer\models\queries\StreetsDatabaseQuery;
use GeoFixer\models\queries\HousesDatabaseQuery;
use GeoFixer\helpers\StringHelper;
use GeoFixer\helpers\FuzzySearchHelper;

/**
 * Class GeoFixer
 *
 * @package GeoFixer\models
 */
class GeoFixer
{
    protected $strict = false;
    protected $first_letters = false;
    protected $full_settlements = false;

    protected $string_helper;
    protected $fuzzy_helper;

    /**
     * GeoFixer construct
     */
    public function __construct()
    {
        $this->string_helper = new StringHelper();
        $this->fuzzy_helper = new FuzzySearchHelper();
    }

    /**
     * @param $region
     *
     * @return bool|mixed
     */
    public function findFiasRegion($region)
    {
        $regions = new RegionsDatabaseQuery();
        $regions = $regions->getRegions();

        if (is_integer($this->first_letters)) {
            $regions = $regions->firstLetters(substr($region, 0, $this->first_letters));
        }

        $regions = $regions->findAll();

        $titles = [];
        $regions_with_codes = [];

        foreach ($regions as $v) {
            $regions_with_codes[$v['title']] = $v['code'];
            $titles[] = $v['title'];
        }

        $result = $this->findSimilarWord($region, $titles);

        return $result ? $regions_with_codes[$result] : false;
    }

    /**
     * @param $word
     * @param $search_array
     *
     * @return string
     */
    public function findSimilarWord($word, $search_array)
    {
        if (in_array($word, $search_array)) {
            return $word;
        }

        $word = $this->string_helper->wordTranslit($word);

        $translited_words = $this->string_helper->arrayTranslit($search_array);

        if ($this->strict == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $result = $this->fuzzy_helper->findBestMatch($word, $translited_words);
            return $result;
        }

        $result = key($this->fuzzy_helper->findMostSimilarWords($word, $translited_words));

        return $result ? $result : false;
    }

    /**
     * @param $city
     * @param $region_code
     *
     * @return bool|mixed
     */
    public function findFiasSettlements($city, $region_code)

This method seems to be duplicated in your project.

    {
        $settlements = new SettlementsDatabaseQuery();
        $settlements = $settlements->getSettlements()->regionCode($region_code)->addressLevel();

        if (is_integer($this->first_letters)) {
            $settlements = $settlements->firstLetters(substr($city, 0, $this->first_letters));
        }

        $settlements = $settlements->findAll();

        $titles = [];
        $settlements_with_id = [];

        foreach ($settlements as $v) {
            $settlements_with_id[$v['title']] = $v['address_id'];
            $titles[] = $v['title'];
        }

        $result = $this->findSimilarWord($city, $titles);

        return $result ? $settlements_with_id[$result] : false;
    }

    /**
     * @param $city
     * @param $region_code
     *
     * @return bool|mixed
     */
    public function findKladrSettlements($city, $region_code)
    {
        $settlements = new SettlementsDatabaseQuery();
        $settlements = $settlements->getSettlements()->regionCode($region_code)->addressLevel();

        if (is_integer($this->first_letters)) {
            $settlements = $settlements->firstLetters(substr($city, 0, $this->first_letters));
        }

        $settlements = $settlements->findAll();

        $titles = [];
        $settlements_with_id = [];

        foreach ($settlements as $v) {
            $settlements_with_id[$v['title']] = $v['code'];
            $titles[] = $v['title'];
        }

        $result = $this->findSimilarWord($city, $titles);

        if (!$result) {
            return false;
        }
        if (is_null($settlements_with_id[$result])) {
            return false;
        }

        return $settlements_with_id[$result];
    }

    /**
     * @param $street
     * @param $city_id
     *
     * @return bool|mixed
     */
    public function findFiasStreets($street, $city_id)

This method seems to be duplicated in your project.

    {
        $streets = new StreetsDatabaseQuery();
        $streets = $streets->getStreets()->parentId($city_id)->addressLevel();

        if (is_integer($this->first_letters)) {
            $streets = $streets->firstLetters(substr($street, 0, $this->first_letters));
        }

        $streets = $streets->findAll();

        $titles = [];
        $streets_with_id = [];

        foreach ($streets as $v) {
            $streets_with_id[$v['title']] = $v['address_id'];
            $titles[] = $v['title'];
        }

        $result = $this->findSimilarWord($street, $titles);

        return $result ? $streets_with_id[$result] : false;
    }

    /**
     * @param $street
     * @param $city_code
     *
     * @return bool|mixed
     */
    public function findKladrStreets($street, $city_code)
    {
        $streets = new StreetsDatabaseQuery();
        $city = new SettlementsDatabaseQuery();
        $city_id = $city->getSettlements()->addressLevel(true)->kladrCode($city_code)->findOne();
        if ($city_id) {

The expression $city_id of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $city_id = $city_id['address_id'];
        } else {
            return false;
        }
        $streets = $streets->getStreets()->parentId($city_id)->addressLevel();

        if (is_integer($this->first_letters)) {
            $streets = $streets->firstLetters(substr($street, 0, $this->first_letters));
        }

        $streets = $streets->findAll();

        $titles = [];
        $streets_with_id = [];

        foreach ($streets as $v) {
            $streets_with_id[$v['title']] = $v['code'];
            $titles[] = $v['title'];
        }

        $result = $this->findSimilarWord($street, $titles);

        if (!$result) {
            return false;
        }
        if (is_null($streets_with_id[$result])) {
            return false;
        }

        return $streets_with_id[$result];
    }

    /**
     * @param $house
     * @param $street_id
     *
     * @return bool
     */
    public function findFiasHouses($house, $street_id, $building = false)
    {
        $house_id = new HousesDatabaseQuery();
        $house_id = $house_id->getHouses()->addressId($street_id)->houseNumber($house);

        if ($building != false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $house_id = $house_id->building($building);
        }

        $house_id = $house_id->findOne();

        return $house_id ? $house_id['house_id'] : false;
    }

    /**
     * Включаем строгий режим поиска
     *
     * @param bool $strict
     */
    public function isStrict($strict = false)
    {
        $this->strict = $strict;
    }


    /**
     * Сколько первых букв должны совпадать при поиске по базам ФИАС
     *
     * (теоретически, снизит кол-во слов, которые придется обрабатывать алгоритмом и тем самым увеличит скорость работы, но может не найти слово, если первые буквы не совпадают
     * из-за опечатки или префиксов)
     *
     * @param bool $count
     */
    public function isFirstLetters($count = false)
    {
        if (is_int($count)) {
            $this->first_letters = $count;

The property $first_letters was declared of type boolean, but $count is of type integer. Maybe add a type cast?

        }
    }

    /**
     * Только города, или города и поселения
     *
     * @param bool $is_full
     */
    public function isFullSettlements($is_full = false)
    {
        $this->full_settlements = $is_full;
    }
}