PhileCMS / Phile

lib/Phile/Core/Config.php

<?php

namespace Phile\Core;

/**
 * Config class
 *
 * @author  PhileCMS
 * @link    https://philecms.github.io
 * @license http://opensource.org/licenses/MIT
 * @package Phile
 */
class Config
{
    /** @var boolean configuration is writable */
    protected $isLocked = false;
    
    public function __construct(array $values = [])
    {
        Registry::set('Phile_Settings', []);
        $this->set($values);
    }

    /**
     * Getter for configuration values
     *
     * @param string $key single key
     * @return mixed
     */
    public function get(string $key)
    {
        /** @var array $config */
        $config = Registry::get('Phile_Settings');

        if (array_key_exists($key, $config)) {
            return $config[$key];
        }

        $constant = strtoupper($key);
        if (defined($constant)) {
            return constant($constant);
        }

        return null;
    }

    /**
     * Checks if configuration $key exists
     *
     * @param string $key configuration-key
     * @return boolean
     */
    public function has(string $key): bool
    {
        $config = Registry::get('Phile_Settings');
        return array_key_exists($key, $config);
    }

    /**
     * Return configuration as PHP-array
     *
     * @return array
     */
    public function toArray()
    {
        return Registry::get('Phile_Settings');
    }

    /**
     * Setter for configuration values
     *
     * @param string|array $key set single key value; sell all if array
     * @param mixed $value
     * @return void
     */
    public function set($key, $value = null): void
    {
        $config = Registry::get('Phile_Settings');

        if ($this->isLocked) {
            throw new \LogicException(
                sprintf('Phile-configuration is locked. Can\' set key "%s"', (string)$key),
                1518440759
            );
        }

        if ($value === null && is_array($key)) {
            $config = $key;
        } else {
            $config[$key] = $value;
        }

        Registry::set('Phile_Settings', $config);
    }

    /**
     * Recursively merges a configuration over the existing configuration
     *
     * @param array $values configuration to merge
     * @return void
     */
    public function merge(array $values): void
    {
        $old = $this->toArray();
        $new = array_replace_recursive($old, $values);
        $this->set($new);
    }

    /**
     * Creates an array of template variables derived from the configuration
     *
     * @return array
     */
    public function getTemplateVars(): array
    {
        return [
            'base_dir' => rtrim($this->get('root_dir'), '/'),

It seems like $this->get('root_dir') can also be of type null; however, parameter $string of rtrim() does only seem to accept string, maybe add an additional type check?

            'base_url' => $this->get('base_url'),
            'config' => $this->toArray(),
            'content_dir' => $this->get('content_dir'),
            'content_url' => $this->get('base_url') . '/' . basename($this->get('content_dir')),

It seems like $this->get('content_dir') can also be of type null; however, parameter $path of basename() does only seem to accept string, maybe add an additional type check?

            'site_title' => $this->get('site_title'),
            'theme_dir' => $this->get('themes_dir') . $this->get('theme'),
            'theme_url' => $this->get('base_url') . '/'
                . basename($this->get('themes_dir')) . '/' . $this->get('theme'),
        ];
    }

    /**
     * Locks configuration into read-only mode
     *
     * @return void
     */
    public function lock(): void
    {
        $this->isLocked = true;
    }
}