PluginTest::testWhoops() - Code Metrics - Inspection of "Merge pull request #333 from Schlaefer/feature/1.1..." - PhileCMS/Phile - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 9ae090...ce9409 )

by Schlaefer

created 2018-04-07 10:31 UTC

PluginTest::testWhoops() B

↳ Parent: PluginTest

Complexity

Conditions	2
Paths	4

Size

Total Lines	35
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	35
ccs	24
cts	24
cp	1
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	23
nc	4
nop	0
crap	2

<?php
/**
 * @link http://philecms.github.io/
 * @license http://opensource.org/licenses/MIT
 * @package Phile\Plugin\Phile\ErrorHandler\Test
 */

namespace Phile\Plugin\Phile\ErrorHandler\Tests;

use Phile\Core\Bootstrap;
use Phile\Core\Config;
use Phile\Test\TestCase;

class PluginTest extends TestCase
{
    /**
     * Basic test that whoops plugin is running.
     *
     * The exception is not thrown but caught by Whoops and rendered plaintext
     * CLI response.
     */
    public function testWhoops()
    {
        $config = new Config([
            'plugins' => [
                'phile\\errorHandler' => ['active' => true, 'handler' => 'development']
            ]
        ]);
        $eventBus = new \Phile\Core\Event;
        $eventBus->register('after_init_core', function () {
            throw new \Exception('1845F098-9035-4D8E-9E31');
        });

        $request = $this->createServerRequestFromArray();

        try {
            $core = $this->createPhileCore($eventBus, $config);
            $core->addBootstrap(function ($eventBus, $config) {
                $config->set('phile_cli_mode', false);
                Bootstrap::setupErrorHandler($config);
            });
            $response = $this->createPhileResponse($core, $request);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            ob_start();
            $errorHandler = \Phile\Core\ServiceLocator::getService(
                'Phile_ErrorHandler'
            );
            $errorHandler->handleException($e);
            $body = ob_get_clean();
        }

        $this->assertStringStartsWith('Exception: 1845F098-9035-4D8E-9E31 in file', $body);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        $handlers = set_exception_handler(null);
        $this->assertInstanceOf(\Phile\Plugin\Phile\ErrorHandler\Development::class, $handlers[0]);
    }
}


1		<?php
2		/**
3		* @link http://philecms.github.io/
4		* @license http://opensource.org/licenses/MIT
5		* @package Phile\Plugin\Phile\ErrorHandler\Test
6		*/
7
8		namespace Phile\Plugin\Phile\ErrorHandler\Tests;
9
10		use Phile\Core\Bootstrap;
11		use Phile\Core\Config;
12		use Phile\Test\TestCase;
13
14		class PluginTest extends TestCase
15		{
16		/**
17		* Basic test that whoops plugin is running.
18		*
19		* The exception is not thrown but caught by Whoops and rendered plaintext
20		* CLI response.
21		*/
22	1	public function testWhoops()
23		{
24	1	$config = new Config([
25	1	'plugins' => [
26		'phile\\errorHandler' => ['active' => true, 'handler' => 'development']
27		]
28		]);
29	1	$eventBus = new \Phile\Core\Event;
30	1	$eventBus->register('after_init_core', function () {
31	1	throw new \Exception('1845F098-9035-4D8E-9E31');
32	1	});
33
34	1	$request = $this->createServerRequestFromArray();
35
36		try {
37	1	$core = $this->createPhileCore($eventBus, $config);
38	1	$core->addBootstrap(function ($eventBus, $config) {
39	1	$config->set('phile_cli_mode', false);
40	1	Bootstrap::setupErrorHandler($config);
41	1	});
42	1	$response = $this->createPhileResponse($core, $request);
		0 ignored issues – show Unused Code introduced 2018-04-02 08:14 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
43	1	} catch (\Exception $e) {
44	1	ob_start();
45	1	$errorHandler = \Phile\Core\ServiceLocator::getService(
46	1	'Phile_ErrorHandler'
47		);
48	1	$errorHandler->handleException($e);
49	1	$body = ob_get_clean();
50		}
51
52	1	$this->assertStringStartsWith('Exception: 1845F098-9035-4D8E-9E31 in file', $body);
		0 ignored issues – show Bug introduced 2018-04-02 08:14 UTC by Report Bug Copy Issue Report The variable `$body` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
53
54	1	$handlers = set_exception_handler(null);
55	1	$this->assertInstanceOf(\Phile\Plugin\Phile\ErrorHandler\Development::class, $handlers[0]);
56	1	}
57		}
58

PhileCMS / Phile

Push — develop ( 9ae090...ce9409 )

PluginTest::testWhoops() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like