PageCollection::offsetSet() - Code Metrics - Inspection of "Merge branch 'release/1.8.0'" - PhileCMS/Phile - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1282f8...92a01c )

by Schlaefer

created 2018-02-04 08:33 UTC

PageCollection::offsetSet() A

↳ Parent: PageCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
ccs	0
cts	4
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	2
crap	2

<?php

namespace Phile\Repository;

/**
 * Page collection which delays searching for and loading pages until necessary.
 *
 * @author  PhileCMS
 * @link    https://philecms.com
 * @license http://opensource.org/licenses/MIT
 * @package Phile\Repository
 */
class PageCollection implements \ArrayAccess, \IteratorAggregate, \Countable
{
    /**
     * @var callback A function to be used for loading the pages.
     */
    private $loader;

    /**
     * @var array of \Phile\Model\Page
     */
    private $pages;

    /**
     * Constructor.
     *
     * @param callable $loader pages loader
     */
    public function __construct(callable $loader)
    {
        $this->loader = $loader;
    }

    /**
     * Perform page loading.
     *
     * @return void
     */
    private function load()
    {
        if ($this->pages === null) {
            $this->pages = call_user_func($this->loader);

        }
    }

    /**
     * Get pages in a array.
     *
     * @return array of \Phile\Model\Page
     */
    public function toArray()
    {
        $this->load();
        return $this->pages;
    }

    public function getIterator()
    {
        $this->load();
        return new \ArrayIterator($this->pages);
    }

    public function offsetExists($offset)
    {
        $this->load();
        return isset($this->pages[$offset]);
    }

    public function offsetGet($offset)
    {
        $this->load();
        return $this->pages[$offset];
    }

    public function offsetSet($offset, $value)
    {
        $this->load();
        $this->pages[$offset] =    $value;
    }

    public function offsetUnset($offset)
    {
        $this->load();
        unset($this->pages[$offset]);
    }

    public function count()
    {
        $this->load();
        return count($this->pages);
    }
}


1		<?php
2
3		namespace Phile\Repository;
4
5		/**
6		* Page collection which delays searching for and loading pages until necessary.
7		*
8		* @author PhileCMS
9		* @link https://philecms.com
10		* @license http://opensource.org/licenses/MIT
11		* @package Phile\Repository
12		*/
13		class PageCollection implements \ArrayAccess, \IteratorAggregate, \Countable
14		{
15		/**
16		* @var callback A function to be used for loading the pages.
17		*/
18		private $loader;
19
20		/**
21		* @var array of \Phile\Model\Page
22		*/
23		private $pages;
24
25		/**
26		* Constructor.
27		*
28		* @param callable $loader pages loader
29		*/
30	9	public function __construct(callable $loader)
31		{
32	9	$this->loader = $loader;
33	9	}
34
35		/**
36		* Perform page loading.
37		*
38		* @return void
39		*/
40	9	private function load()
41		{
42	9	if ($this->pages === null) {
43	9	$this->pages = call_user_func($this->loader);
		0 ignored issues – show Documentation Bug introduced 2016-03-04 12:08 UTC by Report Bug Copy Issue Report It seems like `call_user_func($this->loader)` of type `*` is incompatible with the declared type `array` of property `$pages`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
44		}
45	8	}
46
47		/**
48		* Get pages in a array.
49		*
50		* @return array of \Phile\Model\Page
51		*/
52	2	public function toArray()
53		{
54	2	$this->load();
55	1	return $this->pages;
56		}
57
58	4	public function getIterator()
59		{
60	4	$this->load();
61	4	return new \ArrayIterator($this->pages);
62		}
63
64		public function offsetExists($offset)
65		{
66		$this->load();
67		return isset($this->pages[$offset]);
68		}
69
70	2	public function offsetGet($offset)
71		{
72	2	$this->load();
73	2	return $this->pages[$offset];
74		}
75
76		public function offsetSet($offset, $value)
77		{
78		$this->load();
79		$this->pages[$offset] = $value;
80		}
81
82		public function offsetUnset($offset)
83		{
84		$this->load();
85		unset($this->pages[$offset]);
86		}
87
88	2	public function count()
89		{
90	2	$this->load();
91	2	return count($this->pages);
92		}
93		}
94

PhileCMS / Phile

Push — master ( 1282f8...92a01c )

PageCollection::offsetSet() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like