RecaptchaServiceProvider::boot() - Code Metrics - Inspection of "Laravel 8" - PheRum/laravel-recaptcha - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 72a5c2...ae9e87 )

by Valerka

created 2020-09-13 19:40 UTC

RecaptchaServiceProvider::boot() A

↳ Parent: RecaptchaServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace PheRum\Recaptcha;

use Illuminate\Support\ServiceProvider;

class RecaptchaServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap the application events.
     *
     * @return void
     */
    public function boot()
    {
        $this->loadViewsFrom(__DIR__ . '/resources/views', 'pherum');
        
        $this->publishes([
            __DIR__ . '/config/recaptcha.php' => config_path('recaptcha.php'),
        ], 'config');
        
        $this->app->validator->extend('recaptcha', function ($attribute, $value) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return app('recaptcha')->verify(app('request'));
        });
    }
    
    /**
     * Register the application services.
     *
     * @return void
     */
    public function register()
    {
        $this->mergeConfigFrom(__DIR__ . '/config/recaptcha.php', 'recaptcha');
        
        $this->app->bind('recaptcha', function () {
            return new Recaptcha(config('recaptcha'));
        });
    }
}


1			<?php
2
3			namespace PheRum\Recaptcha;
4
5			use Illuminate\Support\ServiceProvider;
6
7			class RecaptchaServiceProvider extends ServiceProvider
8			{
9			/**
10			* Bootstrap the application events.
11			*
12			* @return void
13			*/
14			public function boot()
15			{
16			$this->loadViewsFrom(__DIR__ . '/resources/views', 'pherum');
17
18			$this->publishes([
19			__DIR__ . '/config/recaptcha.php' => config_path('recaptcha.php'),
20			], 'config');
21
22			$this->app->validator->extend('recaptcha', function ($attribute, $value) {
			0 ignored issues – show Bug introduced 2016-08-15 12:25 UTC by Report Bug Copy Issue Report Accessing `validator` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Unused Code introduced 2016-08-15 12:25 UTC by Report Bug Copy Issue Report The parameter `$attribute` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-08-15 12:25 UTC by Report Bug Copy Issue Report The parameter `$value` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
23			return app('recaptcha')->verify(app('request'));
24			});
25			}
26
27			/**
28			* Register the application services.
29			*
30			* @return void
31			*/
32			public function register()
33			{
34			$this->mergeConfigFrom(__DIR__ . '/config/recaptcha.php', 'recaptcha');
35
36			$this->app->bind('recaptcha', function () {
37			return new Recaptcha(config('recaptcha'));
38			});
39			}
40			}
41

PheRum / laravel-recaptcha

Push — master ( 72a5c2...ae9e87 )

RecaptchaServiceProvider::boot() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like