Phauthentic\PasswordHasher\AbstractPasswordHasher

Complexity

Total Complexity

3

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setSalt()	0	13	2
A	needsRehash()	0	3	1

<?php
declare(strict_types=1);
/**
 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
 * @link          http://cakephp.org CakePHP(tm) Project
 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
 */
namespace Phauthentic\PasswordHasher;

use InvalidArgumentException;

/**
 * Abstract password hashing class
 */
abstract class AbstractPasswordHasher implements PasswordHasherInterface
{
    const SALT_BEFORE = 'before';
    const SALT_AFTER = 'after';

    /**
     * Salt
     *
     * @return void
     */
    protected $salt = '';

    /**
     * Position of the salt
     *
     * @var string
     */
    protected $saltPosition;

    /**
     * Sets the salt if any was used
     *
     * @return $this
     */
    public function setSalt(string $salt, string $position = self::SALT_AFTER): self
    {
        if (!in_array($position, [self::SALT_BEFORE, self::SALT_AFTER])) {
            throw new InvalidArgumentException(sprintf(
                '`%s` is an invalud argument, it has to be `` or ``',
                $position,
                self::SALT_BEFORE,
                self::SALT_AFTER
            ));
        }

        $this->salt = $salt;
        $this->saltPosition = $position;

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Phauthentic\PasswordHasher\AbstractPasswordHasher. Consider adding a return statement or allowing null as return value.

    }

    /**
     * Returns true if the password need to be rehashed, due to the password being
     * created with anything else than the passwords generated by this class.
     *
     * Returns true by default since the only implementation users should rely
     * on is the one provided by default in php 5.5+ or any compatible library
     *
     * @param string $password The password to verify
     * @return bool
     */
    public function needsRehash(string $password): bool
    {
        return password_needs_rehash($password, PASSWORD_DEFAULT);
    }
}