Phauthentic / authorization

src/Policy/ResolverCollection.php

<?php

/**
 * CakePHP(tm) : Rapid Development Framework (https://cakephp.org)
 * Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright     Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org)
 * @link          https://cakephp.org CakePHP(tm) Project
 * @since         1.0.0
 * @license       https://opensource.org/licenses/mit-license.php MIT License
 */

declare(strict_types=1);

namespace Phauthentic\Authorization\Policy;

use ArrayIterator;
use Phauthentic\Authorization\Policy\Exception\MissingPolicyException;

/**
 * `ResolverCollection` is used for aggregating multiple resolvers when more than
 * one resolver is necessary. The collection will iterate over configured resolvers
 * and try to resolve a policy on each one. The first successfully resolved policy
 * will be returned.
 *
 * Configured resolvers must throw `Authorization\Policy\Exception\MissingPolicyException`
 * if a policy cannot be resolved.
 *
 * Example configuration:
 *
 * ```
 * $collection = new ResolverCollection([
 *     new OrmResolver(),
 *     new MapResolver([
 *         Service::class => ServicePolicy::class
 *     ])
 * ]);
 *
 * $service = new AuthenticationService($collection);
 * ```
 */
class ResolverCollection implements ResolverInterface, ResolverCollectionInterface
{
    /**
     * Policy resolver instances.
     *
     * @var \Phauthentic\Authorization\Policy\ResolverInterface[]
     */
    protected $resolvers = [];
/**
     * Constructor. Takes an array of policy resolver instances.
     *
     * @param \Phauthentic\Authorization\Policy\ResolverInterface[] $resolvers An array of policy resolver instances.
     */
    public function __construct(array $resolvers = [])
    {
        foreach ($resolvers as $resolver) {
            $this->add($resolver);
        }
    }

    /**
     * Adds a resolver to the collection.
     *
     * @param \Phauthentic\Authorization\Policy\ResolverInterface $resolver Resolver instance.
     * @return $this
     */
    public function add(ResolverInterface $resolver): ResolverCollectionInterface
    {
        $this->resolvers[] = $resolver;
        return $this;
    }

    /**
     * @inheritDoc
     */
    public function count(): int
    {
        return count($this->resolvers);
    }

    /**
     * Gets the iterator
     *
     * @return \Iterator
     */
    public function getIterator()
    {
        return new ArrayIterator($this->resolvers);
    }

    /**
     * @inheritDoc
     */
    public function getPolicy($resource)
    {
        foreach ($this->resolvers as $resolver) {
            try {
                return $resolver->getPolicy($resource);
            } catch (MissingPolicyException $e) {

Consider adding a comment why this CATCH block is empty.

            }
        }

        $exception = new MissingPolicyException();
        throw $exception->setMessageVars([get_class($resource)]);
    }
}