Phauthentic\Authorization\Policy\CollectionResolver

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

70%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getPolicy()	0	13	3
A	__construct()	0	3	1

<?php
declare(strict_types = 1);
/**
 * CakePHP(tm) : Rapid Development Framework (https://cakephp.org)
 * Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright     Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org)
 * @link          https://cakephp.org CakePHP(tm) Project
 * @since         1.0.0
 * @license       https://opensource.org/licenses/mit-license.php MIT License
 */
namespace Phauthentic\Authorization\Policy;

use Phauthentic\Authorization\Policy\Exception\MissingPolicyException;

/**
 * `ResolverCollection` is used for aggregating multiple resolvers when more than
 * one resolver is necessary. The collection will iterate over configured resolvers
 * and try to resolve a policy on each one. The first successfully resolved policy
 * will be returned.
 *
 * Configured resolvers must throw `Authorization\Policy\Exception\MissingPolicyException`
 * if a policy cannot be resolved.
 *
 * Example configuration:
 *
 * ```
 * $collection = new ResolverCollection([
 *     new OrmResolver(),
 *     new MapResolver([
 *         Service::class => ServicePolicy::class
 *     ])
 * ]);
 *
 * $service = new AuthenticationService($collection);
 * ```
 */
class CollectionResolver implements ResolverInterface
{
    /**
     * Policy resolver instances.
     *
     * @var \Phauthentic\Authorization\Policy\ResolverInterface[]
     */
    protected $collection;

    /**
     * Constructor. Takes an array of policy resolver instances.
     *
     * @param \Phauthentic\Authorization\Policy\ResolverInterface[] $resolvers An array of policy resolver instances.
     */
    public function __construct(ResolverCollection $collection)
    {
        $this->collection = $collection;

It seems like $collection of type Phauthentic\Authorization\Policy\ResolverCollection is incompatible with the declared type Phauthentic\Authorization\Policy\ResolverInterface[] of property $collection.

    }

    /**
     * {@inheritDoc}
     */
    public function getPolicy($resource)
    {
        foreach ($this->collection as $resolver) {
            try {
                return $resolver->getPolicy($resource);
            } catch (MissingPolicyException $e) {

Consider adding a comment why this CATCH block is empty.

            }
        }

        $class = get_class($resource);
        $message = sprintf('Policy for `%s` has not been defined.', $class);

        throw new MissingPolicyException($message);
    }
}