Phauthentic / authentication

src/Identifier/Ldap/ExtensionAdapter.php

<?php

/**
 * CakePHP(tm) : Rapid Development Framework (https://cakephp.org)
 * Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright     Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org)
 * @link          https://cakephp.org CakePHP(tm) Project
 * @since         1.0.0
 * @license       https://opensource.org/licenses/mit-license.php MIT License
 */

declare(strict_types=1);

namespace Phauthentic\Authentication\Identifier\Ldap;

use ErrorException;
use RuntimeException;

/**
 * Provides a very thin OOP wrapper around the ldap_* functions.
 *
 * We don't need and want a huge LDAP lib for our purpose.
 *
 * But this makes it easier to unit test code that is using LDAP because we can
 * mock it very easy. It also provides some convenience.
 */
class ExtensionAdapter implements AdapterInterface
{
    /**
     * LDAP Object
     *
     * @var \LDAP\Connection|null

The type LDAP\Connection was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    protected $connection;

    /**
     * Constructor
     *
     * @throws \RuntimeException
     */
    public function __construct()
    {
        if (!extension_loaded('ldap')) {
            throw new RuntimeException('You must enable the ldap extension to use the LDAP identifier.');
        }

        if (!defined('LDAP_OPT_DIAGNOSTIC_MESSAGE')) {
            define('LDAP_OPT_DIAGNOSTIC_MESSAGE', 0x0032);
        }
    }

    /**
     * Bind to LDAP directory
     *
     * @param string $bind Bind rdn
     * @param string $password Bind password
     * @return bool
     * @throws \ErrorException
     */
    public function bind(string $bind, string $password): bool
    {
        $this->setErrorHandler();
        $result = ldap_bind($this->getConnection(), $bind, $password);

$this->getConnection() of type LDAP\Connection is incompatible with the type resource expected by parameter $ldap of ldap_bind().

        $this->unsetErrorHandler();

        return $result;
    }

    /**
     * Get the LDAP connection
     *
     * @return mixed
     * @throws \RuntimeException If the connection is empty
     */
    public function getConnection()
    {
        if (empty($this->connection)) {
            throw new RuntimeException('You are not connected to a LDAP server.');
        }

        return $this->connection;
    }

    /**
     * Connect to an LDAP server
     *
     * @param string $host Hostname
     * @param int $port Port
     * @param array<int, int|bool|string> $options Additional LDAP options
     * @return void
     * @throws \ErrorException
     */
    public function connect(string $host, int $port, array $options): void
    {
        $this->setErrorHandler();
        $this->connection = ldap_connect($host, $port) ?: null;

It seems like ldap_connect($host, $port) ?: null can also be of type resource. However, the property $connection is declared as type LDAP\Connection|null. Maybe add an additional type check?

        $this->unsetErrorHandler();

        if (is_array($options)) {

The condition is_array($options) is always true.

            foreach ($options as $option => $value) {
                $this->setOption($option, $value);
            }
        }
    }

    /**
     *  Set the value of the given option
     *
     * @param int $option Option to set
     * @param int|bool|string $value The new value for the specified option
     * @return void
     */
    public function setOption(int $option, $value)
    {
        $this->setErrorHandler();
        ldap_set_option($this->getConnection(), $option, $value);

$this->getConnection() of type LDAP\Connection is incompatible with the type resource expected by parameter $ldap of ldap_set_option().

        $this->unsetErrorHandler();
    }

    /**
     * Get the current value for given option
     *
     * @param int $option Option to get
     * @return mixed This will be set to the option value.
     */
    public function getOption($option)
    {
        $returnValue = null;
        $this->setErrorHandler();
        ldap_get_option($this->getConnection(), $option, $returnValue);

$this->getConnection() of type LDAP\Connection is incompatible with the type resource expected by parameter $ldap of ldap_get_option().

        $this->unsetErrorHandler();

        return $returnValue;
    }

    /**
     * Get the diagnostic message
     *
     * @return string|null
     */
    public function getDiagnosticMessage()
    {
        return $this->getOption(LDAP_OPT_DIAGNOSTIC_MESSAGE);
    }

    /**
     * Unbind from LDAP directory
     *
     * @return void
     */
    public function unbind()
    {
        $this->setErrorHandler();
        if ($this->connection) {
            ldap_unbind($this->connection);

$this->connection of type LDAP\Connection is incompatible with the type resource expected by parameter $ldap of ldap_unbind().

        }
        $this->unsetErrorHandler();

        $this->connection = null;
    }

    /**
     * Set an error handler to turn LDAP errors into exceptions
     *
     * @return void
     * @throws \ErrorException
     */
    protected function setErrorHandler()
    {
        set_error_handler(
            function ($errorNumber, $errorText) {
                 throw new ErrorException($errorText);
            },
            E_ALL
        );
    }

    /**
     * Restore the error handler
     *
     * @return void
     */
    protected function unsetErrorHandler()
    {
        restore_error_handler();
    }
}