Phauthentic\Authentication\Identifier\Resolver\OrmResolver::find()

Complexity

Conditions	5
Paths	9

Size

Total Lines	24
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	5

Importance

Changes

0

<?php
    public function find(array $conditions): ?ArrayAccess
    {
        $table = $this->getTableLocator()->get($this->getConfig('userModel'));

        $query = $table->query();
        $finders = (array)$this->getConfig('finder');
        foreach ($finders as $finder => $options) {
            if (is_string($options)) {
                $query->find($options);
            } else {
                $query->find($finder, $options);
            }
        }

        $where = [];
        foreach ($conditions as $field => $value) {
            $field = $table->aliasField($field);
            if (is_array($value)) {
                $field = $field . ' IN';
            }
            $where[$field] = $value;
        }

        return $query->where($where)->first();

The expression return $query->where($where)->first() could return the type array which is incompatible with the type-hinted return null|ArrayAccess. Consider adding an additional type-check to rule them out.

    }