RSSReaderController::indexAction() - Code Metrics - PetLid/rssreader - Measure and Improve Code Quality continuously with Scrutinizer

RSSReaderController::indexAction() A
last analyzed 2016-05-22 13:36 UTC

↳ Parent: RSSReaderController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	11
loc	11
ccs	0
cts	7
cp	0
rs	9.4285
cc	1
eloc	6
nc	1
nop	0
crap	2

<?php

namespace petlid\RSSReader;

/**
 * To attach comments-flow to a page or some content.
 *
 */
class RSSReaderController implements \Anax\DI\IInjectionAware
{
    use \Anax\DI\TInjectable;


    private $RSSFeed;

    public function __construct($url = null)
    {
        $this->RSSFeed = new \SimplePie();

        $this->RSSFeed->set_feed_url($url);

        $this->RSSFeed->enable_cache(false);

		$this->RSSFeed->init();
		$this->RSSFeed->handle_content_type();
    }

    public function indexAction()

    {
        $rssPosts = $this->RSSFeed->get_items(0, 5);

        $this->views->addString("This is the index route of rssreader");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->views->add('rssreader/feed', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'title' => 'Rss',
            'items' => $rssPosts
        ]);
    }

    public function viewAction($noOfItems = 5)

    {
        $rssPosts = $this->RSSFeed->get_items(0, $noOfItems);

        $this->views->add('rssreader/feed', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'title' => 'Rss',
            'items' => $rssPosts
        ]);
    }

}


1			<?php
2
3			namespace petlid\RSSReader;
4
5			/**
6			* To attach comments-flow to a page or some content.
7			*
8			*/
9			class RSSReaderController implements \Anax\DI\IInjectionAware
10			{
11			use \Anax\DI\TInjectable;
12
13
14			private $RSSFeed;
15
16	1		public function __construct($url = null)
17			{
18	1		$this->RSSFeed = new \SimplePie();
19
20	1		$this->RSSFeed->set_feed_url($url);
21
22	1		$this->RSSFeed->enable_cache(false);
23
24	1		$this->RSSFeed->init();
25	1		$this->RSSFeed->handle_content_type();
26	1		}
27
28		View Code Duplication	public function indexAction()
			0 ignored issues – show Duplication introduced 2016-05-21 21:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29			{
30			$rssPosts = $this->RSSFeed->get_items(0, 5);
31
32			$this->views->addString("This is the index route of rssreader");
			0 ignored issues – show Documentation introduced 2016-05-22 11:41 UTC by Report Bug Copy Issue Report The property `views` does not exist on `object<petlid\RSSReader\RSSReaderController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
33
34			$this->views->add('rssreader/feed', [
			0 ignored issues – show Documentation introduced 2016-05-22 11:41 UTC by Report Bug Copy Issue Report The property `views` does not exist on `object<petlid\RSSReader\RSSReaderController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35			'title' => 'Rss',
36			'items' => $rssPosts
37			]);
38			}
39
40		View Code Duplication	public function viewAction($noOfItems = 5)
			0 ignored issues – show Duplication introduced 2016-05-21 21:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41			{
42			$rssPosts = $this->RSSFeed->get_items(0, $noOfItems);
43
44			$this->views->add('rssreader/feed', [
			0 ignored issues – show Documentation introduced 2016-05-22 11:41 UTC by Report Bug Copy Issue Report The property `views` does not exist on `object<petlid\RSSReader\RSSReaderController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45			'title' => 'Rss',
46			'items' => $rssPosts
47			]);
48			}
49
50			}
51

PetLid / rssreader

RSSReaderController::indexAction() A last analyzed 2016-05-22 13:36 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RSSReaderController::indexAction() A
last analyzed 2016-05-22 13:36 UTC