Agenda::not() - Code Metrics - Inspection of "add command to delete an agenda" - PersonalGalaxy/Calendar - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( fd1e5f...8e6584 )

by Baptiste

created 2018-04-07 13:59 UTC

Agenda::not() A

↳ Parent: Agenda

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	2
ccs	0
cts	1
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	0
nc	1
nop	0
crap	2

<?php
declare(strict_types = 1);

namespace PersonalGalaxy\Calendar\Specification;

use PersonalGalaxy\Calendar\Entity\Agenda\Identity;
use Innmind\Specification\{
    ComparatorInterface,
    CompositeInterface,
    SpecificationInterface,
    NotInterface,
};

final class Agenda implements ComparatorInterface
{
    private $value;

    public function __construct(Identity $identity)
    {
        $this->value = (string) $identity;
    }

    /**
     * {@inheritdoc}
     */
    public function property(): string
    {
        return 'agenda';
    }

    /**
     * {@inheritdoc}
     */
    public function sign(): string
    {
        return '=';
    }

    /**
     * {@inheritdoc}
     */
    public function value()
    {
        return $this->value;
    }

    /**
     * {@inheritdoc}
     */
    public function and(SpecificationInterface $specification): CompositeInterface
    {
        //not implemented
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * {@inheritdoc}
     */
    public function or(SpecificationInterface $specification): CompositeInterface
    {
        //not implemented
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * {@inheritdoc}
     */
    public function not(): NotInterface
    {
        //not implemented
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace PersonalGalaxy\Calendar\Specification;
5
6		use PersonalGalaxy\Calendar\Entity\Agenda\Identity;
7		use Innmind\Specification\{
8		ComparatorInterface,
9		CompositeInterface,
10		SpecificationInterface,
11		NotInterface,
12		};
13
14		final class Agenda implements ComparatorInterface
15		{
16		private $value;
17
18	2	public function __construct(Identity $identity)
19		{
20	2	$this->value = (string) $identity;
21	2	}
22
23		/**
24		* {@inheritdoc}
25		*/
26	1	public function property(): string
27		{
28	1	return 'agenda';
29		}
30
31		/**
32		* {@inheritdoc}
33		*/
34	1	public function sign(): string
35		{
36	1	return '=';
37		}
38
39		/**
40		* {@inheritdoc}
41		*/
42	1	public function value()
43		{
44	1	return $this->value;
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50		public function and(SpecificationInterface $specification): CompositeInterface
51		{
52		//not implemented
53		}
		0 ignored issues – show Bug Best Practice introduced 2018-04-07 14:01 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `Innmind\Specification\CompositeInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
54
55		/**
56		* {@inheritdoc}
57		*/
58		public function or(SpecificationInterface $specification): CompositeInterface
59		{
60		//not implemented
61		}
		0 ignored issues – show Bug Best Practice introduced 2018-04-07 14:01 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `Innmind\Specification\CompositeInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
62
63		/**
64		* {@inheritdoc}
65		*/
66		public function not(): NotInterface
67		{
68		//not implemented
69		}
		0 ignored issues – show Bug Best Practice introduced 2018-04-07 14:01 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `Innmind\Specification\NotInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
70		}
71

PersonalGalaxy / Calendar

Push — develop ( fd1e5f...8e6584 )

Agenda::not() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like