Permify /
permify
| Conditions | 12 |
| Total Lines | 128 |
| Code Lines | 77 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like servers.*PermissionServer.BulkCheck often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | package servers |
||
| 53 | func (r *PermissionServer) BulkCheck(ctx context.Context, request *v1.PermissionBulkCheckRequest) (*v1.PermissionBulkCheckResponse, error) { |
||
| 54 | // emptyResp is a default, empty response that we will return in case of an error or when the context is cancelled. |
||
| 55 | emptyResp := &v1.PermissionBulkCheckResponse{ |
||
| 56 | Results: make([]*v1.PermissionCheckResponse, 0), |
||
| 57 | } |
||
| 58 | |||
| 59 | ctx, span := internal.Tracer.Start(ctx, "permissions.bulk-check") |
||
| 60 | defer span.End() |
||
| 61 | |||
| 62 | // Validate tenant_id |
||
| 63 | if request.GetTenantId() == "" { |
||
| 64 | err := status.Error(GetStatus(nil), "tenant_id is required") |
||
| 65 | span.RecordError(err) |
||
| 66 | span.SetStatus(otelCodes.Error, err.Error()) |
||
| 67 | return nil, err |
||
| 68 | } |
||
| 69 | |||
| 70 | checkItems := request.GetItems() |
||
| 71 | |||
| 72 | // Validate number of requests |
||
| 73 | if len(checkItems) == 0 { |
||
| 74 | err := status.Error(GetStatus(nil), "at least one item is required") |
||
| 75 | span.RecordError(err) |
||
| 76 | span.SetStatus(otelCodes.Error, err.Error()) |
||
| 77 | return nil, err |
||
| 78 | } |
||
| 79 | |||
| 80 | if len(checkItems) > 100 { |
||
| 81 | err := status.Error(GetStatus(nil), "maximum 100 items allowed") |
||
| 82 | span.RecordError(err) |
||
| 83 | span.SetStatus(otelCodes.Error, err.Error()) |
||
| 84 | return nil, err |
||
| 85 | } |
||
| 86 | |||
| 87 | // The buffer size is equal to the number of references in the entity. |
||
| 88 | type resultItem struct { |
||
| 89 | index int |
||
| 90 | response *v1.PermissionCheckResponse |
||
| 91 | } |
||
| 92 | resultChannel := make(chan resultItem, len(checkItems)) |
||
| 93 | |||
| 94 | // The WaitGroup and Mutex are used for synchronization. |
||
| 95 | var wg sync.WaitGroup |
||
| 96 | var mutex sync.Mutex |
||
| 97 | |||
| 98 | // Process each check request |
||
| 99 | for i, checkRequestItem := range checkItems { |
||
| 100 | wg.Add(1) |
||
| 101 | |||
| 102 | go func(index int, checkRequestItem *v1.PermissionBulkCheckRequestItem) { |
||
| 103 | defer wg.Done() |
||
| 104 | |||
| 105 | // Validate individual request |
||
| 106 | v := checkRequestItem.Validate() |
||
| 107 | if v != nil { |
||
| 108 | resultChannel <- resultItem{ |
||
| 109 | index: index, |
||
| 110 | response: &v1.PermissionCheckResponse{ |
||
| 111 | Can: v1.CheckResult_CHECK_RESULT_DENIED, |
||
| 112 | Metadata: &v1.PermissionCheckResponseMetadata{ |
||
| 113 | CheckCount: 0, |
||
| 114 | }, |
||
| 115 | }, |
||
| 116 | } |
||
| 117 | return |
||
| 118 | } |
||
| 119 | |||
| 120 | // Perform the check using existing Check function |
||
| 121 | checkRequest := &v1.PermissionCheckRequest{ |
||
| 122 | TenantId: request.GetTenantId(), |
||
| 123 | Subject: checkRequestItem.GetSubject(), |
||
| 124 | Entity: checkRequestItem.GetEntity(), |
||
| 125 | Permission: checkRequestItem.GetPermission(), |
||
| 126 | Metadata: request.GetMetadata(), |
||
| 127 | Context: request.GetContext(), |
||
| 128 | Arguments: request.GetArguments(), |
||
| 129 | } |
||
| 130 | response, err := r.invoker.Check(ctx, checkRequest) |
||
| 131 | if err != nil { |
||
| 132 | // Log error but don't fail the entire bulk operation |
||
| 133 | slog.ErrorContext(ctx, "check failed in bulk operation", "error", err.Error(), "index", index) |
||
| 134 | resultChannel <- resultItem{ |
||
| 135 | index: index, |
||
| 136 | response: &v1.PermissionCheckResponse{ |
||
| 137 | Can: v1.CheckResult_CHECK_RESULT_DENIED, |
||
| 138 | Metadata: &v1.PermissionCheckResponseMetadata{ |
||
| 139 | CheckCount: 1, |
||
| 140 | }, |
||
| 141 | }, |
||
| 142 | } |
||
| 143 | return |
||
| 144 | } |
||
| 145 | |||
| 146 | resultChannel <- resultItem{index: index, response: &v1.PermissionCheckResponse{ |
||
| 147 | Can: response.GetCan(), |
||
| 148 | Metadata: response.GetMetadata(), |
||
| 149 | }} |
||
| 150 | }(i, checkRequestItem) |
||
| 151 | } |
||
| 152 | |||
| 153 | // Once the function returns, we wait for all goroutines to finish, then close the resultChannel. |
||
| 154 | defer func() { |
||
| 155 | wg.Wait() |
||
| 156 | close(resultChannel) |
||
| 157 | }() |
||
| 158 | |||
| 159 | // We read the responses from the resultChannel. |
||
| 160 | // We expect as many responses as there are references in the entity. |
||
| 161 | results := make([]*v1.PermissionCheckResponse, len(request.GetItems())) |
||
| 162 | for range checkItems { |
||
| 163 | select { |
||
| 164 | // If we receive a response from the resultChannel, we check for errors. |
||
| 165 | case response := <-resultChannel: |
||
| 166 | // If there's no error, we add the result to our response's Results map. |
||
| 167 | // We use a mutex to safely update the map since multiple goroutines may be writing to it concurrently. |
||
| 168 | mutex.Lock() |
||
| 169 | results[response.index] = response.response |
||
| 170 | mutex.Unlock() |
||
| 171 | |||
| 172 | // If the context is done (i.e., canceled or deadline exceeded), we return an empty response and an error. |
||
| 173 | case <-ctx.Done(): |
||
| 174 | return emptyResp, errors.New(v1.ErrorCode_ERROR_CODE_CANCELLED.String()) |
||
| 175 | } |
||
| 176 | } |
||
| 177 | |||
| 178 | return &v1.PermissionBulkCheckResponse{ |
||
| 179 | Results: results, |
||
| 180 | }, nil |
||
| 181 | } |
||
| 287 |
