Conditions | 42 |
Total Lines | 345 |
Code Lines | 210 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like cmd.serve often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | package cmd |
||
135 | func serve() func(cmd *cobra.Command, args []string) error { |
||
136 | return func(cmd *cobra.Command, args []string) error { |
||
137 | var cfg *config.Config |
||
138 | var err error |
||
139 | cfgFile := viper.GetString("config.file") |
||
140 | if cfgFile != "" { |
||
141 | cfg, err = config.NewConfigWithFile(cfgFile) |
||
142 | if err != nil { |
||
143 | return fmt.Errorf("failed to create new config: %w", err) |
||
|
|||
144 | } |
||
145 | |||
146 | if err = viper.Unmarshal(cfg); err != nil { |
||
147 | return fmt.Errorf("failed to unmarshal config: %w", err) |
||
148 | } |
||
149 | } else { |
||
150 | // Load configuration |
||
151 | cfg, err = config.NewConfig() |
||
152 | if err != nil { |
||
153 | return fmt.Errorf("failed to create new config: %w", err) |
||
154 | } |
||
155 | |||
156 | if err = viper.Unmarshal(cfg); err != nil { |
||
157 | return fmt.Errorf("failed to unmarshal config: %w", err) |
||
158 | } |
||
159 | } |
||
160 | |||
161 | spew.Dump(cfg) |
||
162 | |||
163 | // Print banner and initialize logger |
||
164 | internal.PrintBanner() |
||
165 | |||
166 | var handler slog.Handler |
||
167 | switch cfg.Log.Output { |
||
168 | case "json": |
||
169 | handler = slog.NewJSONHandler(os.Stdout, &slog.HandlerOptions{ |
||
170 | Level: getLogLevel(cfg.Log.Level), |
||
171 | }) |
||
172 | case "text": |
||
173 | handler = slog.NewTextHandler(os.Stdout, &slog.HandlerOptions{ |
||
174 | Level: getLogLevel(cfg.Log.Level), |
||
175 | }) |
||
176 | default: |
||
177 | handler = slog.NewTextHandler(os.Stdout, &slog.HandlerOptions{ |
||
178 | Level: getLogLevel(cfg.Log.Level), |
||
179 | }) |
||
180 | } |
||
181 | |||
182 | logger := slog.New(handler) |
||
183 | |||
184 | slog.SetDefault(logger) |
||
185 | |||
186 | slog.Info("🚀 starting permify service...") |
||
187 | |||
188 | internal.Identifier = cfg.AccountID |
||
189 | if internal.Identifier == "" { |
||
190 | message := "Account ID is not set. Please fill in the Account ID for better support. Get your Account ID from https://permify.co/account" |
||
191 | slog.Error(message) |
||
192 | |||
193 | ticker := time.NewTicker(24 * time.Hour) |
||
194 | defer ticker.Stop() |
||
195 | |||
196 | go func() { |
||
197 | for range ticker.C { |
||
198 | slog.Error(message) |
||
199 | } |
||
200 | }() |
||
201 | } |
||
202 | |||
203 | // Set up context and signal handling |
||
204 | ctx, stop := signal.NotifyContext(context.Background(), syscall.SIGINT, syscall.SIGTERM) |
||
205 | defer stop() |
||
206 | |||
207 | // Run database migration if enabled |
||
208 | if cfg.Database.AutoMigrate { |
||
209 | err = storage.Migrate(cfg.Database) |
||
210 | if err != nil { |
||
211 | slog.Error("failed to migrate database", slog.Any("error", err)) |
||
212 | } |
||
213 | } |
||
214 | |||
215 | // Initialize database |
||
216 | db, err := factories.DatabaseFactory(cfg.Database) |
||
217 | if err != nil { |
||
218 | slog.Error("failed to initialize database", slog.Any("error", err)) |
||
219 | return err |
||
220 | } |
||
221 | defer func() { |
||
222 | if err = db.Close(); err != nil { |
||
223 | slog.Error("failed to close database", slog.Any("error", err)) |
||
224 | } |
||
225 | }() |
||
226 | |||
227 | // Tracing |
||
228 | if cfg.Tracer.Enabled { |
||
229 | var exporter trace.SpanExporter |
||
230 | exporter, err = tracerexporters.ExporterFactory( |
||
231 | cfg.Tracer.Exporter, |
||
232 | cfg.Tracer.Endpoint, |
||
233 | cfg.Tracer.Insecure, |
||
234 | cfg.Tracer.URLPath, |
||
235 | ) |
||
236 | if err != nil { |
||
237 | slog.Error(err.Error()) |
||
238 | } |
||
239 | |||
240 | shutdown := telemetry.NewTracer(exporter) |
||
241 | |||
242 | defer func() { |
||
243 | if err = shutdown(context.Background()); err != nil { |
||
244 | slog.Error(err.Error()) |
||
245 | } |
||
246 | }() |
||
247 | } |
||
248 | |||
249 | // Garbage collection |
||
250 | if cfg.Database.GarbageCollection.Timeout > 0 && cfg.Database.GarbageCollection.Enabled && cfg.Database.Engine != "memory" { |
||
251 | slog.Info("🗑️ starting database garbage collection...") |
||
252 | |||
253 | garbageCollector := gc.NewGC( |
||
254 | db.(*PQDatabase.Postgres), |
||
255 | gc.Interval(cfg.Database.GarbageCollection.Interval), |
||
256 | gc.Window(cfg.Database.GarbageCollection.Window), |
||
257 | gc.Timeout(cfg.Database.GarbageCollection.Timeout), |
||
258 | ) |
||
259 | |||
260 | go func() { |
||
261 | err = garbageCollector.Start(ctx) |
||
262 | if err != nil { |
||
263 | slog.Error(err.Error()) |
||
264 | } |
||
265 | }() |
||
266 | } |
||
267 | |||
268 | // Meter |
||
269 | meter := telemetry.NewNoopMeter() |
||
270 | if cfg.Meter.Enabled { |
||
271 | var exporter metric.Exporter |
||
272 | exporter, err = meterexporters.ExporterFactory( |
||
273 | cfg.Meter.Exporter, |
||
274 | cfg.Meter.Endpoint, |
||
275 | cfg.Meter.Insecure, |
||
276 | cfg.Meter.URLPath, |
||
277 | ) |
||
278 | if err != nil { |
||
279 | slog.Error(err.Error()) |
||
280 | } |
||
281 | |||
282 | meter, err = telemetry.NewMeter(exporter) |
||
283 | if err != nil { |
||
284 | slog.Error(err.Error()) |
||
285 | } |
||
286 | } |
||
287 | |||
288 | // schema cache |
||
289 | var schemaCache pkgcache.Cache |
||
290 | schemaCache, err = ristretto.New(ristretto.NumberOfCounters(cfg.Service.Schema.Cache.NumberOfCounters), ristretto.MaxCost(cfg.Service.Schema.Cache.MaxCost)) |
||
291 | if err != nil { |
||
292 | slog.Error(err.Error()) |
||
293 | return err |
||
294 | } |
||
295 | |||
296 | // engines cache cache |
||
297 | var engineKeyCache pkgcache.Cache |
||
298 | engineKeyCache, err = ristretto.New(ristretto.NumberOfCounters(cfg.Service.Permission.Cache.NumberOfCounters), ristretto.MaxCost(cfg.Service.Permission.Cache.MaxCost)) |
||
299 | if err != nil { |
||
300 | slog.Error(err.Error()) |
||
301 | return err |
||
302 | } |
||
303 | |||
304 | watcher := storage.NewNoopWatcher() |
||
305 | if cfg.Service.Watch.Enabled { |
||
306 | watcher = factories.WatcherFactory(db) |
||
307 | } |
||
308 | |||
309 | // Initialize the storage with factory methods |
||
310 | dataReader := factories.DataReaderFactory(db) |
||
311 | dataWriter := factories.DataWriterFactory(db) |
||
312 | bundleReader := factories.BundleReaderFactory(db) |
||
313 | bundleWriter := factories.BundleWriterFactory(db) |
||
314 | schemaReader := factories.SchemaReaderFactory(db) |
||
315 | schemaWriter := factories.SchemaWriterFactory(db) |
||
316 | tenantReader := factories.TenantReaderFactory(db) |
||
317 | tenantWriter := factories.TenantWriterFactory(db) |
||
318 | |||
319 | // Add caching to the schema reader using a decorator |
||
320 | schemaReader = cacheDecorator.NewSchemaReader(schemaReader, schemaCache) |
||
321 | |||
322 | dataReader = sfDecorator.NewDataReader(dataReader) |
||
323 | schemaReader = sfDecorator.NewSchemaReader(schemaReader) |
||
324 | |||
325 | // Check if circuit breaker should be enabled for services |
||
326 | if cfg.Service.CircuitBreaker { |
||
327 | var cb *gobreaker.CircuitBreaker |
||
328 | var st gobreaker.Settings |
||
329 | st.Name = "storage" |
||
330 | st.ReadyToTrip = func(counts gobreaker.Counts) bool { |
||
331 | failureRatio := float64(counts.TotalFailures) / float64(counts.Requests) |
||
332 | return counts.Requests >= 10 && failureRatio >= 0.6 |
||
333 | } |
||
334 | |||
335 | cb = gobreaker.NewCircuitBreaker(st) |
||
336 | |||
337 | // Add circuit breaker to the relationship reader using decorator |
||
338 | dataReader = cbDecorator.NewDataReader(dataReader, cb) |
||
339 | |||
340 | // Add circuit breaker to the bundle reader using decorators |
||
341 | bundleReader = cbDecorator.NewBundleReader(bundleReader, cb) |
||
342 | |||
343 | // Add circuit breaker to the schema reader using decorator |
||
344 | schemaReader = cbDecorator.NewSchemaReader(schemaReader, cb) |
||
345 | |||
346 | // Add circuit breaker to the tenant reader using decorator |
||
347 | tenantReader = cbDecorator.NewTenantReader(tenantReader, cb) |
||
348 | } |
||
349 | |||
350 | // Initialize the engines using the key manager, schema reader, and relationship reader |
||
351 | checkEngine := engines.NewCheckEngine(schemaReader, dataReader, engines.CheckConcurrencyLimit(cfg.Service.Permission.ConcurrencyLimit)) |
||
352 | expandEngine := engines.NewExpandEngine(schemaReader, dataReader) |
||
353 | |||
354 | // Declare a variable `checker` of type `invoke.Check`. |
||
355 | var checker invoke.Check |
||
356 | |||
357 | // Create the checker either with load balancing or caching capabilities. |
||
358 | if cfg.Distributed.Enabled { |
||
359 | |||
360 | if cfg.Authn.Enabled && cfg.Authn.Method == "oidc" { |
||
361 | return errors.New("OIDC authentication method cannot be used in distributed mode. Please check your configuration") |
||
362 | } |
||
363 | |||
364 | checker, err = balancer.NewCheckEngineWithBalancer( |
||
365 | context.Background(), |
||
366 | checkEngine, |
||
367 | schemaReader, |
||
368 | &cfg.Distributed, |
||
369 | &cfg.Server.GRPC, |
||
370 | &cfg.Authn, |
||
371 | ) |
||
372 | // Handle potential error during checker creation. |
||
373 | if err != nil { |
||
374 | return err |
||
375 | } |
||
376 | checker = cache.NewCheckEngineWithCache( |
||
377 | checker, |
||
378 | schemaReader, |
||
379 | engineKeyCache, |
||
380 | meter, |
||
381 | ) |
||
382 | } else { |
||
383 | checker = cache.NewCheckEngineWithCache( |
||
384 | checkEngine, |
||
385 | schemaReader, |
||
386 | engineKeyCache, |
||
387 | meter, |
||
388 | ) |
||
389 | } |
||
390 | |||
391 | // Create a localChecker which directly checks without considering distributed setup. |
||
392 | // This also includes caching capabilities. |
||
393 | localChecker := cache.NewCheckEngineWithCache( |
||
394 | checkEngine, |
||
395 | schemaReader, |
||
396 | engineKeyCache, |
||
397 | meter, |
||
398 | ) |
||
399 | |||
400 | // Initialize the lookupEngine, which is responsible for looking up certain entities or values. |
||
401 | lookupEngine := engines.NewLookupEngine( |
||
402 | checker, |
||
403 | schemaReader, |
||
404 | dataReader, |
||
405 | // Set concurrency limit based on the configuration. |
||
406 | engines.LookupConcurrencyLimit(cfg.Service.Permission.BulkLimit), |
||
407 | ) |
||
408 | |||
409 | // Initialize the subjectPermissionEngine, responsible for handling subject permissions. |
||
410 | subjectPermissionEngine := engines.NewSubjectPermission( |
||
411 | checker, |
||
412 | schemaReader, |
||
413 | // Set concurrency limit for the subject permission checks. |
||
414 | engines.SubjectPermissionConcurrencyLimit(cfg.Service.Permission.ConcurrencyLimit), |
||
415 | ) |
||
416 | |||
417 | // Create a new invoker that is used to directly call various functions or engines. |
||
418 | // It encompasses the schema, data, checker, and other engines. |
||
419 | invoker := invoke.NewDirectInvoker( |
||
420 | schemaReader, |
||
421 | dataReader, |
||
422 | checker, |
||
423 | expandEngine, |
||
424 | lookupEngine, |
||
425 | subjectPermissionEngine, |
||
426 | meter, |
||
427 | ) |
||
428 | |||
429 | // Associate the invoker with the checkEngine. |
||
430 | checkEngine.SetInvoker(invoker) |
||
431 | |||
432 | // Create a local invoker for local operations. |
||
433 | localInvoker := invoke.NewDirectInvoker( |
||
434 | schemaReader, |
||
435 | dataReader, |
||
436 | localChecker, |
||
437 | expandEngine, |
||
438 | lookupEngine, |
||
439 | subjectPermissionEngine, |
||
440 | meter, |
||
441 | ) |
||
442 | |||
443 | // Initialize the container which brings together multiple components such as the invoker, data readers/writers, and schema handlers. |
||
444 | container := servers.NewContainer( |
||
445 | invoker, |
||
446 | dataReader, |
||
447 | dataWriter, |
||
448 | bundleReader, |
||
449 | bundleWriter, |
||
450 | schemaReader, |
||
451 | schemaWriter, |
||
452 | tenantReader, |
||
453 | tenantWriter, |
||
454 | watcher, |
||
455 | ) |
||
456 | |||
457 | // Create an error group with the provided context |
||
458 | var g *errgroup.Group |
||
459 | g, ctx = errgroup.WithContext(ctx) |
||
460 | |||
461 | // Add the container.Run function to the error group |
||
462 | g.Go(func() error { |
||
463 | return container.Run( |
||
464 | ctx, |
||
465 | &cfg.Server, |
||
466 | logger, |
||
467 | &cfg.Distributed, |
||
468 | &cfg.Authn, |
||
469 | &cfg.Profiler, |
||
470 | localInvoker, |
||
471 | ) |
||
472 | }) |
||
473 | |||
474 | // Wait for the error group to finish and log any errors |
||
475 | if err = g.Wait(); err != nil { |
||
476 | slog.Error(err.Error()) |
||
477 | } |
||
478 | |||
479 | return nil |
||
480 | } |
||
498 |