tests.conftest.populate() - Code Metrics - Inspection of "Revamp a bit" - Pegase745/sqlalchemy-datatables - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#110)

by Michel

created 2018-11-21 21:29 UTC

tests.conftest.populate() A

↳ Parent: tests.conftest

Complexity

Conditions

Size

Total Lines	16
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	13
dl	0
loc	16
rs	9.75
c	0
b	0
f	0
cc	2
nop	1

from __future__ import print_function
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

import itertools
from datetime import datetime, timedelta

import faker

import pytest

from sqlalchemy import create_engine
from sqlalchemy.orm import sessionmaker

from .models import Address, Base, User


def populate(session):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    """Create 3 adresses and 50 users."""
    users = []
    f = faker.Faker(seed=1)

    addresses = [Address(description=d) for d in ['Street', 'Avenue', 'Road']]
    session.add_all(addresses)

    for i, addr in zip(range(0, 50), itertools.cycle(addresses)):
        user = User(
            name=f.name(),
            address=addr,
            birthday=datetime(1970, 1, 2) + timedelta(days=10 * i))
        users.append(user)

    session.add_all(users)
    session.commit()


@pytest.fixture(scope="session")
def engine():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    print("TestCase: Using sqlite database")
    return create_engine('sqlite:///', echo=False)


@pytest.fixture(scope="session")
def session(engine):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    sessionmaker_ = sessionmaker(bind=engine)
    session = sessionmaker_()
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    Base.metadata.create_all(engine)
    populate(session)

    yield session

    session.close()


1			from __future__ import print_function
			0 ignored issues – show Coding Style introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			import itertools
4			from datetime import datetime, timedelta
5
6			import faker
			0 ignored issues – show introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report Unable to import 'faker' Loading history...
7			import pytest
			0 ignored issues – show introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report Unable to import 'pytest' Loading history...
8			from sqlalchemy import create_engine
9			from sqlalchemy.orm import sessionmaker
10
11			from .models import Address, Base, User
12
13
14			def populate(session):
			0 ignored issues – show Comprehensibility Bug introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report `session` is re-defining a name which is already available in the outer-scope (previously defined on line `39`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
15			"""Create 3 adresses and 50 users."""
16			users = []
17			f = faker.Faker(seed=1)
			0 ignored issues – show Coding Style Naming introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report The name `f` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
18			addresses = [Address(description=d) for d in ['Street', 'Avenue', 'Road']]
19			session.add_all(addresses)
20
21			for i, addr in zip(range(0, 50), itertools.cycle(addresses)):
22			user = User(
23			name=f.name(),
24			address=addr,
25			birthday=datetime(1970, 1, 2) + timedelta(days=10 * i))
26			users.append(user)
27
28			session.add_all(users)
29			session.commit()
30
31
32			@pytest.fixture(scope="session")
33			def engine():
			0 ignored issues – show Coding Style introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
34			print("TestCase: Using sqlite database")
35			return create_engine('sqlite:///', echo=False)
36
37
38			@pytest.fixture(scope="session")
39			def session(engine):
			0 ignored issues – show Coding Style introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Comprehensibility Bug introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report `engine` is re-defining a name which is already available in the outer-scope (previously defined on line `33`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
40			sessionmaker_ = sessionmaker(bind=engine)
41			session = sessionmaker_()
			0 ignored issues – show Comprehensibility Bug introduced 2018-11-21 15:03 UTC by Report Bug Copy Issue Report `session` is re-defining a name which is already available in the outer-scope (previously defined on line `39`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
42			Base.metadata.create_all(engine)
43			populate(session)
44
45			yield session
46
47			session.close()
48

Pegase745 / sqlalchemy-datatables

Pull Request — master (#110)

tests.conftest.populate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like