PeekAndPoke\Component\Slumber\Core\Codec\Property\MapMapper

Complexity

Total Complexity

16

Size/Duplication

Total Lines	131
Duplicated Lines	13.74 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

74.36%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	slumber()	0	14	3
A	awake()	0	16	3
A	slumberKeepNulls()	0	10	2
A	slumberFilterNulls()	9	16	3
A	awakeKeepNulls()	0	11	2
A	awakeFilterNulls()	9	16	3

<?php
/**
 * File was created 30.09.2015 07:46
 */

namespace PeekAndPoke\Component\Slumber\Core\Codec\Property;

use PeekAndPoke\Component\Collections\Collection;
use PeekAndPoke\Component\Slumber\Annotation\Slumber\AsMap;
use PeekAndPoke\Component\Slumber\Core\Codec\Awaker;
use PeekAndPoke\Component\Slumber\Core\Codec\Mapper;
use PeekAndPoke\Component\Slumber\Core\Codec\Slumberer;

/**
 * @method AsMap getOptions()
 *
 * @author Karsten J. Gerber <kontakt@karsten-gerber.de>
 */
class MapMapper extends AbstractCollectionMapper
{
    /**
     * @param Slumberer          $slumberer
     * @param array|\Traversable $value
     *
     * @return null|\stdClass We return a std class as this will ensure json-encode will create something like {"0":1}
     */
    public function slumber(Slumberer $slumberer, $value)
    {
        if (false === $this->isIterable($value)) {
            return null;
        }

        $nested = $this->nested;

        if ($nested->getOptions()->keepNullValuesInCollections()) {
            return $this->slumberKeepNulls($slumberer, $value, $nested);

It seems like $value defined by parameter $value on line 27 can also be of type object<Traversable>; however, PeekAndPoke\Component\Slumber\Core\Codec\Property\MapMapper::slumberKeepNulls() does only seem to accept array, maybe add an additional type check?

        }

        return $this->slumberFilterNulls($slumberer, $value, $nested);

It seems like $value defined by parameter $value on line 27 can also be of type object<Traversable>; however, PeekAndPoke\Component\Slumber\Core\Codec\Property\MapMapper::slumberFilterNulls() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param Awaker             $awaker
     * @param array|\Traversable $value
     *
     * @return array|Collection
     */
    public function awake(Awaker $awaker, $value)
    {
        if (false === $this->isIterable($value)) {
            return $this->createAwakeResult([]);
        }

        $nested = $this->nested;

        // TODO: we need a test that checks that an awaken map is a collection when a collection is specified
        // TODO: packing things into a collection should be a wrapper around this mapper and all other collection mappers
        return $this->createAwakeResult(
            $nested->getOptions()->keepNullValuesInCollections()
                ? $this->awakeKeepNulls($awaker, $value, $nested)

It seems like $value defined by parameter $value on line 48 can also be of type object<Traversable>; however, PeekAndPoke\Component\Slumber\Core\Codec\Property\MapMapper::awakeKeepNulls() does only seem to accept array, maybe add an additional type check?

                : $this->awakeFilterNulls($awaker, $value, $nested)

It seems like $value defined by parameter $value on line 48 can also be of type object<Traversable>; however, PeekAndPoke\Component\Slumber\Core\Codec\Property\MapMapper::awakeFilterNulls() does only seem to accept array, maybe add an additional type check?

        );
    }

    /**
     * @param Slumberer $slumberer
     * @param array     $value
     * @param Mapper    $nested
     *
     * @return \stdClass
     */
    private function slumberKeepNulls(Slumberer $slumberer, $value, Mapper $nested)
    {
        $result = new \stdClass();

        foreach ($value as $k => $v) {
            $result->$k = $nested->slumber($slumberer, $v);
        }

        return $result;
    }

    /**
     * @param Slumberer $slumberer
     * @param array     $value
     * @param Mapper    $nested
     *
     * @return \stdClass
     */
    private function slumberFilterNulls(Slumberer $slumberer, $value, Mapper $nested)
    {
        $result = new \stdClass();

        foreach ($value as $k => $v) {

This code seems to be duplicated across your project.

            $slumbering = $nested->slumber($slumberer, $v);

            // check if we should keep nulls
            if ($slumbering !== null) {
                $result->$k = $slumbering;
            }
        }

        return $result;
    }

    /**
     * @param Awaker $awaker
     * @param array  $value
     * @param Mapper $nested
     *
     * @return array
     */
    private function awakeKeepNulls(Awaker $awaker, $value, Mapper $nested)
    {
        $result = [];

        foreach ($value as $k => $v) {
            $result[$k] = $nested->awake($awaker, $v);
        }

        return $result;

    }

    /**
     * @param Awaker $awaker
     * @param array  $value
     * @param Mapper $nested
     *
     * @return array
     */
    private function awakeFilterNulls(Awaker $awaker, $value, Mapper $nested)
    {
        $result = [];

        foreach ($value as $k => $v) {

This code seems to be duplicated across your project.

            $awoken = $nested->awake($awaker, $v);

            // check if we should keep nulls
            if ($awoken !== null) {
                $result[$k] = $awoken;
            }
        }

        return $result;
    }
}