StatusStream::read() - Code Metrics - Inspection of "Merge pull request #4 from DaveRandom/feature/stre..." - PeeHaa/AsyncTwitter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d137b6...850d7f )

by Pieter

created 2017-02-22 13:48 UTC

StatusStream::read() B

↳ Parent: StatusStream

Complexity

Conditions	5
Paths	5

Size

Total Lines	20
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	20
ccs	0
cts	16
cp	0
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	5
nop	0
crap	30

<?php declare(strict_types = 1);

namespace PeeHaa\AsyncTwitter\Api;

use Amp\Deferred;
use Amp\Failure;
use Amp\Promise;
use Amp\Success;

class StatusStream implements Stream
{
    private $buffer = [];

    /**
     * @var Deferred
     */
    private $readPromisor = null;

    private $error = null;
    private $ended = false;

    private function resolveReadPromise($value): bool
    {
        $promisor = $this->readPromisor;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->readPromisor = null;

        if ($promisor === null) {
            return false;
        }

        $promisor->succeed($value);

        return true;
    }

    public function update($status)
    {
        if (!$this->resolveReadPromise($status)) {
            $this->buffer[] = $status;
        }
    }

    public function end()
    {
        $this->ended = true;

        $this->resolveReadPromise(null);
    }

    public function fail(\Throwable $error)
    {
        $this->error = $error;

        $promisor = $this->readPromisor;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->readPromisor = null;

        if ($promisor !== null) {
            $promisor->fail($error);
        }
    }

    public function read(): Promise
    {
        if ($this->error !== null) {
            return new Failure($this->error);
        }

        if ($this->ended) {
            return new Success(null);
        }

        if (count($this->buffer) > 0) {
            return new Success(\array_shift($this->buffer));
        }

        if ($this->readPromisor === null) {
            $this->readPromisor = new Deferred;
        }

        return $this->readPromisor->promise();
    }

    public function close()
    {
        $this->end(); // todo

    }
}


1			<?php declare(strict_types = 1);
2
3			namespace PeeHaa\AsyncTwitter\Api;
4
5			use Amp\Deferred;
6			use Amp\Failure;
7			use Amp\Promise;
8			use Amp\Success;
9
10			class StatusStream implements Stream
11			{
12			private $buffer = [];
13
14			/**
15			* @var Deferred
16			*/
17			private $readPromisor = null;
18
19			private $error = null;
20			private $ended = false;
21
22			private function resolveReadPromise($value): bool
23			{
24			$promisor = $this->readPromisor;
			0 ignored issues – show Coding Style introduced 2017-02-22 13:40 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
25			$this->readPromisor = null;
26
27			if ($promisor === null) {
28			return false;
29			}
30
31			$promisor->succeed($value);
32
33			return true;
34			}
35
36			public function update($status)
37			{
38			if (!$this->resolveReadPromise($status)) {
39			$this->buffer[] = $status;
40			}
41			}
42
43			public function end()
44			{
45			$this->ended = true;
46
47			$this->resolveReadPromise(null);
48			}
49
50			public function fail(\Throwable $error)
51			{
52			$this->error = $error;
53
54			$promisor = $this->readPromisor;
			0 ignored issues – show Coding Style introduced 2017-02-22 13:40 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
55			$this->readPromisor = null;
56
57			if ($promisor !== null) {
58			$promisor->fail($error);
59			}
60			}
61
62			public function read(): Promise
63			{
64			if ($this->error !== null) {
65			return new Failure($this->error);
66			}
67
68			if ($this->ended) {
69			return new Success(null);
70			}
71
72			if (count($this->buffer) > 0) {
73			return new Success(\array_shift($this->buffer));
74			}
75
76			if ($this->readPromisor === null) {
77			$this->readPromisor = new Deferred;
78			}
79
80			return $this->readPromisor->promise();
81			}
82
83			public function close()
84			{
85			$this->end(); // todo
			0 ignored issues – show Coding Style introduced 2017-02-22 13:40 UTC by Report Bug Copy Issue Report Comment refers to a TODO task This check looks `TODO` comments that have been left in the code. ``TODO``s show that something is left unfinished and should be attended to. Loading history...
86			}
87			}
88

PeeHaa / AsyncTwitter

Push — master ( d137b6...850d7f )

StatusStream::read() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like