PeeHaa\AsyncTwitter\Http\Artax

Complexity

Total Complexity

12

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

89.47%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	post()	0	18	2
A	get()	0	15	2
A	buildQueryString()	0	14	3
A	getFormBody()	0	16	4

<?php declare(strict_types=1);

namespace PeeHaa\AsyncTwitter\Http;

use Amp\Artax\Client as ArtaxClient;
use Amp\Artax\FormBody;
use Amp\Promise;
use PeeHaa\AsyncTwitter\Exception;
use PeeHaa\AsyncTwitter\Request\Body;
use PeeHaa\AsyncTwitter\Request\FieldParameter;
use PeeHaa\AsyncTwitter\Request\FileParameter;
use PeeHaa\AsyncTwitter\Request\Parameter;
use PeeHaa\AsyncTwitter\Request\Url;
use PeeHaa\AsyncTwitter\Oauth\Header;
use Amp\Artax\Request;

class Artax implements Client
{
    private $client;

    public function __construct(ArtaxClient $client)
    {
        $this->client = $client;
    }

    public function post(Url $url, Header $header, Body $body, int $flags = 0): Promise
    {
        $body = $this->getFormBody($body);

Consider using a different name than the parameter $body. This often makes code more readable.

        $request = (new Request)
            ->setMethod('POST')
            ->setUri($url->getUrl())
            ->setHeader('Authorization', $header->getHeader())
            ->setBody($body)
        ;

        $options = [];
        if ($flags & Client::OP_STREAM) {
            $options[ArtaxClient::OP_MS_TRANSFER_TIMEOUT] = -1;
        }

        return $this->client->request($request, $options);
    }

    private function getFormBody(Body $body): FormBody
    {
        $formBody = new FormBody();

        foreach ($body->getParameters() as $parameter) {
            if ($parameter instanceof FieldParameter) {
                $formBody->addField($parameter->getKey(), $parameter->getValue(), $parameter->getType());
            } else if ($parameter instanceof FileParameter) {
                $formBody->addFile($parameter->getKey(), $parameter->getPath(), $parameter->getType());
            } else {
                throw new Exception("Unexpected parameter type: " . get_class($parameter));

The string literal Unexpected parameter type: does not require double quotes, as per coding-style, please use single quotes.

            }
        }

        return $formBody;
    }

    public function get(Url $url, Header $header, array $parameters, int $flags = 0): Promise
    {
        $request = (new Request)
            ->setMethod('GET')
            ->setUri($url->getUrl() . $this->buildQueryString(...$parameters))
            ->setAllHeaders(['Authorization' => $header->getHeader()])
        ;

        $options = [];
        if ($flags & Client::OP_STREAM) {
            $options[ArtaxClient::OP_MS_TRANSFER_TIMEOUT] = -1;
        }

        return $this->client->request($request, $options);
    }

    private function buildQueryString(Parameter ...$parameters): string
    {
        $queryString = [];

        foreach ($parameters as $parameter) {
            if (!$parameter instanceof FieldParameter) {
                throw new Exception("Unexpected parameter type: " . get_class($parameter));

The string literal Unexpected parameter type: does not require double quotes, as per coding-style, please use single quotes.

            }

            $queryString[$parameter->getKey()] = $parameter->getValue();
        }

        return '?' . http_build_query($queryString);
    }
}