PatronBase /
omnipay-windcave-hpp
| Conditions | 14 |
| Paths | 8192 |
| Total Lines | 64 |
| Code Lines | 33 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 17 | public function getData() |
||
| 18 | { |
||
| 19 | $this->validate('apiUsername', 'apiKey', 'amount', 'currency'); |
||
| 20 | |||
| 21 | $data = []; |
||
| 22 | |||
| 23 | $data['type'] = $this->getType(); |
||
| 24 | $data['amount'] = $this->getAmount(); |
||
| 25 | $data['currency'] = $this->getCurrency(); |
||
| 26 | $data['callbackUrls'] = []; |
||
| 27 | |||
| 28 | if ( $this->getStoreCard() ) { |
||
| 29 | $data['storeCard'] = true; |
||
| 30 | } |
||
| 31 | |||
| 32 | if ( $this->getStoredCardIndicator() ) { |
||
| 33 | $data['storedCardIndicator'] = $this->getStoredCardIndicator(); |
||
| 34 | } |
||
| 35 | |||
| 36 | if ( $this->getRecurringExpiry() ) { |
||
| 37 | $data['recurringExpiry'] = $this->getRecurringExpiry(); |
||
| 38 | } |
||
| 39 | |||
| 40 | if ( $this->getRecurringFrequency() ) { |
||
| 41 | $data['recurringFrequency'] = $this->getRecurringFrequency(); |
||
| 42 | } |
||
| 43 | |||
| 44 | if ( $this->getToken() ) { |
||
| 45 | $data['cardId'] = $this->getToken(); |
||
| 46 | } |
||
| 47 | |||
| 48 | if ( is_array($this->getPaymentMethods()) ) { |
||
| 49 | $data['methods'] = $this->getPaymentMethods(); |
||
| 50 | } |
||
| 51 | |||
| 52 | if ( is_array($this->getCardTypes()) ) { |
||
| 53 | $data['cardTypes'] = $this->getCardTypes(); |
||
| 54 | } |
||
| 55 | |||
| 56 | if ( is_array($this->getMetadata()) ) { |
||
| 57 | $data['metaData'] = $this->getMetadata(); |
||
| 58 | } |
||
| 59 | |||
| 60 | if ( $this->getMerchantReference() ) { |
||
| 61 | $data['merchantReference'] = $this->getMerchantReference(); |
||
| 62 | } |
||
| 63 | |||
| 64 | if ( $this->getReturnUrl() ) { |
||
| 65 | $data['callbackUrls']['approved'] = $this->getReturnUrl(); |
||
| 66 | } |
||
| 67 | |||
| 68 | if ( $this->getDeclineUrl() ) { |
||
| 69 | $data['callbackUrls']['declined'] = $this->getDeclineUrl(); |
||
| 70 | } |
||
| 71 | |||
| 72 | if ( $this->getCancelUrl() ) { |
||
| 73 | $data['callbackUrls']['cancelled'] = $this->getCancelUrl(); |
||
| 74 | } |
||
| 75 | |||
| 76 | if ( $this->getNotifyUrl() ) { |
||
| 77 | $data['notificationUrl'] = $this->getNotifyUrl(); |
||
| 78 | } |
||
| 79 | |||
| 80 | return $data; |
||
| 81 | } |
||
| 101 | } |
