PatronBase / omnipay-redsys

src/Gateway.php

Braces +13 added lines, -26 removed lines

@@ -11,15 +11,12 @@ 
  *
  * @link http://www.redsys.es/
  */
-class Gateway extends AbstractGateway
-{
-    public function getName()
-    {
+class Gateway extends AbstractGateway {
+    public function getName() {
         return 'Redsys';
     }
 
-    public function getDefaultParameters()
-    {
+    public function getDefaultParameters() {
         return array(
             'merchantId' => '',
             'merchantName' => '',
@@ -29,53 +26,43 @@ 
         );
     }
 
-    public function getMerchantId()
-    {
+    public function getMerchantId() {
         return $this->getParameter('merchantId');
     }
 
-    public function setMerchantId($value)
-    {
+    public function setMerchantId($value) {
         return $this->setParameter('merchantId', $value);
     }
 
-    public function getMerchantName()
-    {
+    public function getMerchantName() {
         return $this->getParameter('merchantName');
     }
 
-    public function setMerchantName($value)
-    {
+    public function setMerchantName($value) {
         return $this->setParameter('merchantName', $value);
     }
 
-    public function getTerminalId()
-    {
+    public function getTerminalId() {
         return $this->getParameter('terminalId');
     }
 
-    public function setTerminalId($value)
-    {
+    public function setTerminalId($value) {
         return $this->setParameter('terminalId', $value);
     }
 
-    public function getHmacKey()
-    {
+    public function getHmacKey() {
         return $this->getParameter('hmacKey');
     }
 
-    public function setHmacKey($value)
-    {
+    public function setHmacKey($value) {
         return $this->setParameter('hmacKey', $value);
     }
 
-    public function purchase(array $parameters = array())
-    {
+    public function purchase(array $parameters = array()) {
         return $this->createRequest('\Omnipay\Redsys\Message\PurchaseRequest', $parameters);
     }
 
-    public function completePurchase(array $parameters = array())
-    {
+    public function completePurchase(array $parameters = array()) {
         return $this->createRequest('\Omnipay\Redsys\Message\CompletePurchaseRequest', $parameters);
     }
 }

src/Message/AbstractResponse.php

Braces +6 added lines, -12 removed lines

@@ -11,8 +11,7 @@ 
  * This abstract class extends the base Omnipay AbstractResponse in order
  * to provide some common encoding and decoding functions.
  */
-abstract class AbstractResponse extends BaseAbstractResponse
-{
+abstract class AbstractResponse extends BaseAbstractResponse {
     /**
      * Encode merchant parameters
      *
@@ -20,8 +19,7 @@ 
      *
      * @return string Encoded data
      */
-    protected function encodeMerchantParameters($data)
-    {
+    protected function encodeMerchantParameters($data) {
         return base64_encode(json_encode($data));
     }
 
@@ -32,8 +30,7 @@ 
      *
      * @return array Decoded data
      */
-    protected function decodeMerchantParameters($data)
-    {
+    protected function decodeMerchantParameters($data) {
         return (array)json_decode(base64_decode(strtr($data, '-_', '+/')));
     }
 
@@ -49,8 +46,7 @@ 
      *
      * @throws RuntimeException
      */
-    protected function encryptMessage($message, $key)
-    {
+    protected function encryptMessage($message, $key) {
         $iv = implode(array_map("chr", array(0, 0, 0, 0, 0, 0, 0, 0)));
 
         if (function_exists('mcrypt_encrypt')) {
@@ -73,14 +69,12 @@ 
      *
      * @return string Generated signature
      */
-    protected function createSignature($message, $salt, $key)
-    {
+    protected function createSignature($message, $salt, $key) {
         $ciphertext = $this->encryptMessage($salt, $key);
         return base64_encode(hash_hmac('sha256', $message, $ciphertext, true));
     }
 
-    protected function createReturnSignature($message, $salt, $key)
-    {
+    protected function createReturnSignature($message, $salt, $key) {
         return strtr($this->createSignature($message, $salt, $key), '+/', '-_');
     }
 }

src/Message/CompletePurchaseRequest.php

Braces +3 added lines, -6 removed lines

@@ -5,15 +5,12 @@
 /**
  * Redsys Complete Purchase Request
  */
-class CompletePurchaseRequest extends PurchaseRequest
-{
-    public function getData()
-    {
+class CompletePurchaseRequest extends PurchaseRequest {
+    public function getData() {
         return $this->httpRequest->request->all();
     }
 
-    public function sendData($data)
-    {
+    public function sendData($data) {
         return $this->response = new CompletePurchaseResponse($this, $data);
     }
 }

src/Message/CompletePurchaseResponse.php

Braces +8 added lines, -16 removed lines

@@ -8,8 +8,7 @@ 
 /**
  * Redsys Complete Purchase Response
  */
-class CompletePurchaseResponse extends AbstractResponse
-{
+class CompletePurchaseResponse extends AbstractResponse {
     /** @var array */
     protected $merchantParameters;
     /** @var string */
@@ -27,8 +26,7 @@ 
      *
      * @throws InvalidResponseException If order number is missing or signature does not match
      */
-    public function __construct(RequestInterface $request, $data)
-    {
+    public function __construct(RequestInterface $request, $data) {
         parent::__construct($request, $data);
 
         if (!empty($data['Ds_MerchantParameters'])) {
@@ -65,8 +63,7 @@ 
      *
      * @return boolean
      */
-    public function isSuccessful()
-    {
+    public function isSuccessful() {
         $key = $this->usingUpcaseParameters ? 'DS_RESPONSE' : 'Ds_Response';
         return isset($this->merchantParameters[$key])
             && is_numeric($this->merchantParameters[$key])
@@ -79,8 +76,7 @@ 
      *
      * @return mixed
      */
-    public function getData()
-    {
+    public function getData() {
         $data = parent::getData();
         return is_array($data) && is_array($this->merchantParameters)
             ? array_merge($data, $this->merchantParameters)
@@ -92,8 +88,7 @@ 
      *
      * @return null|mixed
      */
-    protected function getKey($key)
-    {
+    protected function getKey($key) {
         if ($this->usingUpcaseParameters) {
             $key = strtoupper($key);
         }
@@ -105,8 +100,7 @@ 
      *
      * @return null|string
      */
-    public function getTransactionReference()
-    {
+    public function getTransactionReference() {
         return $this->getKey('Ds_AuthorisationCode');
     }
 
@@ -115,8 +109,7 @@ 
      *
      * @return null|string
      */
-    public function getMessage()
-    {
+    public function getMessage() {
         return $this->getKey('Ds_Response');
     }
 
@@ -125,8 +118,7 @@ 
      *
      * @return null|string
      */
-    public function getCardType()
-    {
+    public function getCardType() {
         return $this->getKey('Ds_Card_Type');
     }
 }

src/Message/PurchaseRequest.php

Braces +19 added lines, -38 removed lines

@@ -7,8 +7,7 @@ 
 /**
  * Redsys Purchase Request
  */
-class PurchaseRequest extends AbstractRequest
-{
+class PurchaseRequest extends AbstractRequest {
     protected $liveEndpoint = 'https://sis.redsys.es/sis/realizarPago';
     protected $testEndpoint = 'https://sis-t.redsys.es:25443/sis/realizarPago';
     protected static $consumerLanguages = array(
@@ -26,18 +25,15 @@ 
         'eu' => '013', // Basque
     );
 
-    public function getCardholder()
-    {
+    public function getCardholder() {
         return $this->getParameter('cardholder');
     }
 
-    public function setCardholder($value)
-    {
+    public function setCardholder($value) {
         return $this->setParameter('cardholder', $value);
     }
 
-    public function getConsumerLanguage()
-    {
+    public function getConsumerLanguage() {
         return $this->getParameter('consumerLanguage');
     }
 
@@ -46,8 +42,7 @@ 
      *
      * @param string|int Either the ISO 639-1 code to be converted, or the gateway's own numeric language code
      */
-    public function setConsumerLanguage($value)
-    {
+    public function setConsumerLanguage($value) {
         if (is_int($value)) {
             if ($value < 0 || $value > 13) {
                 $value = 1;
@@ -60,53 +55,43 @@ 
         return $this->setParameter('consumerLanguage', $value);
     }
 
-    public function getHmacKey()
-    {
+    public function getHmacKey() {
         return $this->getParameter('hmacKey');
     }
 
-    public function setHmacKey($value)
-    {
+    public function setHmacKey($value) {
         return $this->setParameter('hmacKey', $value);
     }
 
-    public function getMerchantData()
-    {
+    public function getMerchantData() {
         return $this->getParameter('merchantData');
     }
 
-    public function setMerchantData($value)
-    {
+    public function setMerchantData($value) {
         return $this->setParameter('merchantData', $value);
     }
 
-    public function getMerchantId()
-    {
+    public function getMerchantId() {
         return $this->getParameter('merchantId');
     }
 
-    public function setMerchantId($value)
-    {
+    public function setMerchantId($value) {
         return $this->setParameter('merchantId', $value);
     }
 
-    public function getMerchantName()
-    {
+    public function getMerchantName() {
         return $this->getParameter('merchantName');
     }
 
-    public function setMerchantName($value)
-    {
+    public function setMerchantName($value) {
         return $this->setParameter('merchantName', $value);
     }
 
-    public function getTerminalId()
-    {
+    public function getTerminalId() {
         return $this->getParameter('terminalId');
     }
 
-    public function setTerminalId($value)
-    {
+    public function setTerminalId($value) {
         return $this->setParameter('terminalId', $value);
     }
 
@@ -115,8 +100,7 @@ 
      *
      * @param string|int $value The transaction ID (merchant order) to set for the transaction
      */
-    public function setTransactionId($value)
-    {
+    public function setTransactionId($value) {
         $start = substr($value, 0, 4);
         $numerics = 0;
         foreach (str_split($start) as $char) {
@@ -131,8 +115,7 @@ 
         parent::setTransactionId($value);
     }
 
-    public function getData()
-    {
+    public function getData() {
         $this->validate('merchantId', 'terminalId', 'amount', 'currency');
 
         return array(
@@ -155,13 +138,11 @@ 
         );
     }
 
-    public function sendData($data)
-    {
+    public function sendData($data) {
         return $this->response = new PurchaseResponse($this, $data);
     }
 
-    public function getEndpoint()
-    {
+    public function getEndpoint() {
         return $this->getTestMode() ? $this->testEndpoint : $this->liveEndpoint;
     }
 }

src/Message/PurchaseResponse.php

Braces +6 added lines, -12 removed lines

@@ -7,32 +7,26 @@
 /**
  * Redsys Purchase Response
  */
-class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
-{
+class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface {
     protected $version = 'HMAC_SHA256_V1';
 
-    public function isSuccessful()
-    {
+    public function isSuccessful() {
         return false;
     }
 
-    public function isRedirect()
-    {
+    public function isRedirect() {
         return true;
     }
 
-    public function getRedirectUrl()
-    {
+    public function getRedirectUrl() {
         return $this->getRequest()->getEndpoint();
     }
 
-    public function getRedirectMethod()
-    {
+    public function getRedirectMethod() {
         return 'POST';
     }
 
-    public function getRedirectData()
-    {
+    public function getRedirectData() {
         $redirect_data = array();
         $redirect_data['Ds_SignatureVersion'] = $this->version;
         $redirect_data['Ds_MerchantParameters'] = $this->encodeMerchantParameters($this->data);