WebservicePurchaseResponse::__construct() - Code Metrics - PatronBase/omnipay-redsys - Measure and Improve Code Quality continuously with Scrutinizer

WebservicePurchaseResponse::__construct() B
last analyzed 2025-07-21 00:29 UTC

↳ Parent: WebservicePurchaseResponse

Complexity

Conditions	9
Paths	15

Size

Total Lines	52
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	37
CRAP Score	9

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	34
c	1
b	0
f	0
nc	15
nop	2
dl	0
loc	52
ccs	37
cts	37
cp	1
crap	9
rs	8.0555

How to fix Long Method

<?php

namespace Omnipay\Redsys\Message;

use Omnipay\Common\Message\AbstractResponse;
use Omnipay\Common\Message\RequestInterface;
use Omnipay\Common\Exception\InvalidResponseException;

/**
 * Redsys Purchase Response
 */
class WebservicePurchaseResponse extends AbstractResponse
{
    /** @var string */
    protected $returnSignature;
    /** @var boolean */
    protected $usingUpcaseResponse = false;

    /**
     * Constructor
     *
     * @param RequestInterface $request the initiating request.
     * @param mixed $data
     *
     * @throws InvalidResponseException If resopnse format is incorrect, data is missing, or signature does not match
     */
    public function __construct(RequestInterface $request, $data)
    {
        parent::__construct($request, $data);

        $security = new Security;

        if (!isset($data['CODIGO'])) {
            throw new InvalidResponseException('Invalid response from payment gateway (no data)');
        }
        if (!isset($data['OPERACION'])) {
            if ($data['CODIGO'] == '0') {
                throw new InvalidResponseException('Invalid response from payment gateway (no data)');
            } else {
                throw new InvalidResponseException('Invalid response from payment gateway ('.$data['CODIGO'].')');
            }
        }

        if (isset($data['OPERACION']['DS_ORDER'])) {
            $this->usingUpcaseResponse = true;
        }

        $order = $this->GetKey('Ds_Order');
        if ($order === null) {
            throw new InvalidResponseException();
        }

        $signature_keys = array(
            'Ds_Amount',
            'Ds_Order',
            'Ds_MerchantCode',
            'Ds_Currency',
            'Ds_Response',
            'Ds_TransactionType',
            'Ds_SecurePayment',
        );
        $signature_data = '';
        foreach ($signature_keys as $key) {
            $value = $this->getKey($key);
            if ($value === null) {
                throw new InvalidResponseException('Invalid response from payment gateway (missing data)');
            }
            $signature_data .= $value;
        }

        $this->returnSignature = $security->createSignature(
            $signature_data,
            $order,
            $this->request->getHmacKey()
                            getHmacKey()
        );

        if ($this->returnSignature != $this->GetKey('Ds_Signature')) {
            throw new InvalidResponseException('Invalid response from payment gateway (signature mismatch)');
        }
    }

    public function isSuccessful()
    {
        $response_code = $this->getKey('Ds_Response');

        // check for field existence as well as value
        return isset($this->data['CODIGO'])
            && $this->data['CODIGO'] == '0'
            && $response_code !== null
            && is_numeric($response_code)
            && 0 <= $response_code
            && 100 > $response_code;
    }

     /**
     * Helper method to get a specific response parameter if available.
     *
     * @param string $key The key to look up
     *
     * @return null|mixed
     */
    protected function getKey($key)
    {
        if ($this->usingUpcaseResponse) {
            $key = strtoupper($key);
        }
        return isset($this->data['OPERACION'][$key]) ? $this->data['OPERACION'][$key] : null;
    }

    /**
     * Get the authorisation code if available.
     *
     * @return null|string
     */
    public function getTransactionReference()
    {
        return $this->getKey('Ds_AuthorisationCode');
    }

    /**
     * Get the merchant response message if available.
     *
     * @return null|string
     */
    public function getMessage()
    {
        return $this->getKey('Ds_Response');
    }

    /**
     * Get the merchant data if available.
     *
     * @return null|string
     */
    public function getMerchantData()
    {
        return $this->getKey('Ds_MerchantData');
    }

    /**
     * Get the card country if available.
     *
     * @return null|string  ISO 3166-1 (3-digit numeric) format, if supplied
     */
    public function getCardCountry()
    {
        return $this->getKey('Ds_Card_Country');
    }
}


PatronBase / omnipay-redsys

WebservicePurchaseResponse::__construct() B last analyzed 2025-07-21 00:29 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

WebservicePurchaseResponse::__construct() B
last analyzed 2025-07-21 00:29 UTC