Endpoint::respond() - Code Metrics - Inspection of "updated readme" - PascalKleindienst/simple-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6c8381...e53e0e )

by Pascal

created 2016-04-19 14:14 UTC

Endpoint::respond() A

↳ Parent: Endpoint

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	9
ccs	4
cts	4
cp	1
rs	9.6666
cc	2
eloc	4
nc	2
nop	1
crap	2

<?php namespace Atog\Api;

use Symfony\Component\HttpFoundation\Response;

/**
 * Abstract Class Endpoint
 * @package Atog\Api
 */
abstract class Endpoint
{
    /**
     * @var \Atog\Api\Client
     */
    protected $client;
    
    /**
     * @var \Atog\Api\Model
     */
    protected $model;
    
    /**
     * @var string
     */
    protected $endpoint;
    
    /**
     * Endpoint constructor.
     * @param \Atog\Api\Client $client
     * @param \Atog\Api\Model  $model
     */
    public function __construct(Client $client, Model $model)
    {
        $this->client = $client;
        $this->model = $model;
    }

    /**
     * @return \Atog\Api\Model
     */
    public function getModel()
    {
        return $this->model;
    }
    
    /**
     * Get the endpoint url for the request
     * @param string $path
     * @param bool   $withTrailingSlash
     * @return string
     */
    public function getEndpointUrl($path, $withTrailingSlash)
    {
        $url = $this->endpoint . '/' . $path;
        
        if ($withTrailingSlash) {
            $url = $url . '/';
        }
        
        return $url;
    }

    /**
     * @param \Symfony\Component\HttpFoundation\Response $response
     * @return \Atog\Api\Model|null
     */
    public function respond(Response $response)
    {
        // return new model instance with fetched content if response is okay
        if ($response->isOk()) {
            return $this->model->newInstance($response->getContent());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return null;
    }
}


1		<?php namespace Atog\Api;
2
3		use Symfony\Component\HttpFoundation\Response;
4
5		/**
6		* Abstract Class Endpoint
7		* @package Atog\Api
8		*/
9		abstract class Endpoint
10		{
11		/**
12		* @var \Atog\Api\Client
13		*/
14		protected $client;
15
16		/**
17		* @var \Atog\Api\Model
18		*/
19		protected $model;
20
21		/**
22		* @var string
23		*/
24		protected $endpoint;
25
26		/**
27		* Endpoint constructor.
28		* @param \Atog\Api\Client $client
29		* @param \Atog\Api\Model $model
30		*/
31	8	public function __construct(Client $client, Model $model)
32		{
33	8	$this->client = $client;
34	8	$this->model = $model;
35	8	}
36
37		/**
38		* @return \Atog\Api\Model
39		*/
40	3	public function getModel()
41		{
42	3	return $this->model;
43		}
44
45		/**
46		* Get the endpoint url for the request
47		* @param string $path
48		* @param bool $withTrailingSlash
49		* @return string
50		*/
51	1	public function getEndpointUrl($path, $withTrailingSlash)
52		{
53	1	$url = $this->endpoint . '/' . $path;
54
55	1	if ($withTrailingSlash) {
56	1	$url = $url . '/';
57	1	}
58
59	1	return $url;
60		}
61
62		/**
63		* @param \Symfony\Component\HttpFoundation\Response $response
64		* @return \Atog\Api\Model\|null
65		*/
66	2	public function respond(Response $response)
67		{
68		// return new model instance with fetched content if response is okay
69	2	if ($response->isOk()) {
70	1	return $this->model->newInstance($response->getContent());
		0 ignored issues – show Documentation introduced 2016-04-19 14:17 UTC by Report Bug Copy Issue Report `$response->getContent()` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71		}
72
73	1	return null;
74		}
75		}
76

PascalKleindienst / simple-api-client

Push — master ( 6c8381...e53e0e )

Endpoint::respond() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like