Issues in OrderdetailTest.php (master) - Issues in master - Part-DB/Part-DB-symfony - Measure and Improve Code Quality continuously with Scrutinizer

Issues (257)

tests/Entity/PriceSystem/OrderdetailTest.php (8 issues)

Labels

Bug 8

Severity

<?php
/**
 * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
 *
 * Copyright (C) 2019 - 2020 Jan Böhmer (https://github.com/jbtronics)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

declare(strict_types=1);

namespace App\Tests\Entity\PriceSystem;

use App\Entity\PriceInformations\Orderdetail;
use App\Entity\PriceInformations\Pricedetail;
use Doctrine\Common\Collections\Collection;
use PHPUnit\Framework\TestCase;
filter:
    dependency_paths: ["lib/*"]

class OrderdetailTest extends TestCase
{
    public function testAddRemovePricdetails(): void
    {
        $orderdetail = new Orderdetail();
        $this->assertInstanceOf(Collection::class, $orderdetail->getPricedetails());
        $this->assertTrue($orderdetail->getPricedetails()->isEmpty());

        $pricedetail = new Pricedetail();
        $orderdetail->addPricedetail($pricedetail);
        $this->assertSame($orderdetail, $pricedetail->getOrderdetail());
        $this->assertSame(1, $orderdetail->getPricedetails()->count());

        //After removal of the pricedetail, the orderdetail must be empty again
        $orderdetail->removePricedetail($pricedetail);
        $this->assertTrue($orderdetail->getPricedetails()->isEmpty());
    }

    public function testFindPriceForQty(): void
    {
        $price0 = (new Pricedetail())->setMinDiscountQuantity(0.23);
        $price1 = (new Pricedetail())->setMinDiscountQuantity(1);
        $price5 = (new Pricedetail())->setMinDiscountQuantity(5.3);
        $orderdetail = (new Orderdetail())->addPricedetail($price0)->addPricedetail($price1)->addPricedetail($price5);

        $this->assertNull($orderdetail->findPriceForQty(0));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertNull($orderdetail->findPriceForQty(0.1));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

        $this->assertSame($price0, $orderdetail->findPriceForQty(0.5));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertSame($price1, $orderdetail->findPriceForQty(1));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertSame($price1, $orderdetail->findPriceForQty(1.5));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertSame($price5, $orderdetail->findPriceForQty(5.3));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertSame($price5, $orderdetail->findPriceForQty(10000));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2			/**
3			* This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
4			*
5			* Copyright (C) 2019 - 2020 Jan Böhmer (https://github.com/jbtronics)
6			*
7			* This program is free software: you can redistribute it and/or modify
8			* it under the terms of the GNU Affero General Public License as published
9			* by the Free Software Foundation, either version 3 of the License, or
10			* (at your option) any later version.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License
18			* along with this program. If not, see <https://www.gnu.org/licenses/>.
19			*/
20
21			declare(strict_types=1);
22
23			namespace App\Tests\Entity\PriceSystem;
24
25			use App\Entity\PriceInformations\Orderdetail;
26			use App\Entity\PriceInformations\Pricedetail;
27			use Doctrine\Common\Collections\Collection;
28			use PHPUnit\Framework\TestCase;
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `PHPUnit\Framework\TestCase` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
29
30			class OrderdetailTest extends TestCase
31			{
32			public function testAddRemovePricdetails(): void
33			{
34			$orderdetail = new Orderdetail();
35			$this->assertInstanceOf(Collection::class, $orderdetail->getPricedetails());
36			$this->assertTrue($orderdetail->getPricedetails()->isEmpty());
37
38			$pricedetail = new Pricedetail();
39			$orderdetail->addPricedetail($pricedetail);
40			$this->assertSame($orderdetail, $pricedetail->getOrderdetail());
41			$this->assertSame(1, $orderdetail->getPricedetails()->count());
42
43			//After removal of the pricedetail, the orderdetail must be empty again
44			$orderdetail->removePricedetail($pricedetail);
45			$this->assertTrue($orderdetail->getPricedetails()->isEmpty());
46			}
47
48			public function testFindPriceForQty(): void
49			{
50			$price0 = (new Pricedetail())->setMinDiscountQuantity(0.23);
51			$price1 = (new Pricedetail())->setMinDiscountQuantity(1);
52			$price5 = (new Pricedetail())->setMinDiscountQuantity(5.3);
53			$orderdetail = (new Orderdetail())->addPricedetail($price0)->addPricedetail($price1)->addPricedetail($price5);
54
55			$this->assertNull($orderdetail->findPriceForQty(0));
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$orderdetail->findPriceForQty(0)` targeting `App\Entity\PriceInformat...tail::findPriceForQty()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56			$this->assertNull($orderdetail->findPriceForQty(0.1));
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$orderdetail->findPriceForQty(0.1)` targeting `App\Entity\PriceInformat...tail::findPriceForQty()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
57
58			$this->assertSame($price0, $orderdetail->findPriceForQty(0.5));
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$orderdetail->findPriceForQty(0.5)` targeting `App\Entity\PriceInformat...tail::findPriceForQty()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
59			$this->assertSame($price1, $orderdetail->findPriceForQty(1));
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$orderdetail->findPriceForQty(1)` targeting `App\Entity\PriceInformat...tail::findPriceForQty()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
60			$this->assertSame($price1, $orderdetail->findPriceForQty(1.5));
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$orderdetail->findPriceForQty(1.5)` targeting `App\Entity\PriceInformat...tail::findPriceForQty()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
61			$this->assertSame($price5, $orderdetail->findPriceForQty(5.3));
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$orderdetail->findPriceForQty(5.3)` targeting `App\Entity\PriceInformat...tail::findPriceForQty()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
62			$this->assertSame($price5, $orderdetail->findPriceForQty(10000));
			0 ignored issues – show Bug introduced 2019-11-09 13:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$orderdetail->findPriceForQty(10000)` targeting `App\Entity\PriceInformat...tail::findPriceForQty()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
63			}
64			}
65

Part-DB / Part-DB-symfony

Issues (257)

tests/Entity/PriceSystem/OrderdetailTest.php (8 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like