Completed
Push — master ( 44bad9...3ecbe1 )
by Jan
04:21
created
src/Command/CleanAttachmentsCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
         $io = new SymfonyStyle($input, $output);
47 47
 
48 48
         $mediaPath = $this->attachment_helper->getMediaPath();
49
-        $io->note("The media path is " . $mediaPath);
49
+        $io->note("The media path is ".$mediaPath);
50 50
 
51 51
         $finder = new Finder();
52 52
         //We look for files in the media folder only
@@ -103,8 +103,8 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function removeEmptySubFolders($path)
105 105
     {
106
-        $empty=true;
107
-        foreach (glob($path . DIRECTORY_SEPARATOR . "*") as $file)
106
+        $empty = true;
107
+        foreach (glob($path.DIRECTORY_SEPARATOR."*") as $file)
108 108
         {
109 109
             $empty &= is_dir($file) && $this->removeEmptySubFolders($file);
110 110
         }
Please login to merge, or discard this patch.
src/Form/Part/OrderdetailType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 
80 80
 
81 81
         //Add pricedetails after we know the data, so we can set the default currency
82
-        $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) use ($options) {
82
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) use ($options) {
83 83
             /** @var Orderdetail $orderdetail */
84 84
             $orderdetail = $event->getData();
85 85
 
Please login to merge, or discard this patch.
src/Form/Type/CurrencyEntityType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
         // This options allows you to override the currency shown for the null value
63 63
         $resolver->setDefault('base_currency', null);
64 64
 
65
-        $resolver->setDefault('empty_message', function (Options $options) {
65
+        $resolver->setDefault('empty_message', function(Options $options) {
66 66
             //By default we use the global base currency:
67 67
             $iso_code = $this->base_currency;
68 68
 
Please login to merge, or discard this patch.
src/Form/Type/StructuralEntityType.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -74,9 +74,9 @@  discard block
 block discarded – undo
74 74
     public function buildForm(FormBuilderInterface $builder, array $options)
75 75
     {
76 76
         $builder->addModelTransformer(new CallbackTransformer(
77
-            function ($value) use ($options){
77
+            function($value) use ($options){
78 78
                 return $this->transform($value, $options);
79
-            }, function ($value) use ($options) {
79
+            }, function($value) use ($options) {
80 80
             return $this->reverseTransform($value, $options);
81 81
         }));
82 82
     }
@@ -86,24 +86,24 @@  discard block
 block discarded – undo
86 86
         $resolver->setRequired(['class']);
87 87
         $resolver->setDefaults([
88 88
             'show_fullpath_in_subtext' => true, //When this is enabled, the full path will be shown in subtext
89
-            'subentities_of' => null,   //Only show entities with the given parent class
90
-            'disable_not_selectable' => false,  //Disable entries with not selectable property
89
+            'subentities_of' => null, //Only show entities with the given parent class
90
+            'disable_not_selectable' => false, //Disable entries with not selectable property
91 91
             'choice_value' => 'id', //Use the element id as option value and for comparing items
92
-            'choice_loader' => function (Options $options) {
93
-                return new CallbackChoiceLoader(function () use ($options) {
92
+            'choice_loader' => function(Options $options) {
93
+                return new CallbackChoiceLoader(function() use ($options) {
94 94
                     return $this->getEntries($options);
95 95
                 });
96
-            }, 'choice_label' => function ($choice, $key, $value) {
96
+            }, 'choice_label' => function($choice, $key, $value) {
97 97
                 return $this->generateChoiceLabels($choice, $key, $value);
98
-            }, 'choice_attr' => function ($choice, $key, $value) {
98
+            }, 'choice_attr' => function($choice, $key, $value) {
99 99
                 return $this->generateChoiceAttr($choice, $key, $value);
100 100
             }
101 101
         ]);
102 102
 
103 103
         $resolver->setDefault('empty_message', null);
104 104
 
105
-        $resolver->setDefault('attr', function (Options $options) {
106
-            $tmp =  ['class' => 'selectpicker', 'data-live-search' => true];
105
+        $resolver->setDefault('attr', function(Options $options) {
106
+            $tmp = ['class' => 'selectpicker', 'data-live-search' => true];
107 107
             if ($options['empty_message']) {
108 108
                 $tmp['data-none-Selected-Text'] = $options['empty_message'];
109 109
             }
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
 
142 142
         $tmp = str_repeat('   ', $choice->getLevel()); //Use 3 spaces for intendation
143
-        $tmp .=  htmlspecialchars($choice->getName());
143
+        $tmp .= htmlspecialchars($choice->getName());
144 144
         return $tmp;
145 145
     }
146 146
 
Please login to merge, or discard this patch.
src/Entity/PriceInformations/Pricedetail.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -188,7 +188,6 @@
 block discarded – undo
188 188
      *          in the database, you have to pass the "price_related_quantity" count as $multiplier.
189 189
      *
190 190
      * @return string  the price as a bcmath string
191
-
192 191
      */
193 192
     public function getPricePerUnit($multiplier = 1.0) : string
194 193
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -356,6 +356,6 @@
 block discarded – undo
356 356
      */
357 357
     public function getIDString(): string
358 358
     {
359
-        return 'PD' . sprintf('%06d', $this->getID());
359
+        return 'PD'.sprintf('%06d', $this->getID());
360 360
     }
361 361
 }
Please login to merge, or discard this patch.
src/Migrations/Version20190902140506.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
         try {
27 27
             //Check if we can use this migration method:
28
-            $version = (int)$this->connection->fetchColumn("SELECT keyValue AS version FROM `internal` WHERE `keyName` = 'dbVersion'");
28
+            $version = (int) $this->connection->fetchColumn("SELECT keyValue AS version FROM `internal` WHERE `keyName` = 'dbVersion'");
29 29
             $this->abortIf($version !== 26, "This database migration can only be used if the database version is 26! Install Part-DB 0.5.6 and update database there!");
30 30
         } catch (DBALException $ex) {
31 31
             //when the table was not found, then you can not use this migration
@@ -46,15 +46,15 @@  discard block
 block discarded – undo
46 46
 
47 47
         /** Migrate the part locations for parts with known instock */
48 48
         $this->addSql(
49
-            'INSERT INTO part_lots (id_part, id_store_location, amount, instock_unknown, last_modified, datetime_added) ' .
50
-            'SELECT parts.id, parts.id_storelocation,  parts.instock, 0, NOW(), NOW() FROM parts ' .
49
+            'INSERT INTO part_lots (id_part, id_store_location, amount, instock_unknown, last_modified, datetime_added) '.
50
+            'SELECT parts.id, parts.id_storelocation,  parts.instock, 0, NOW(), NOW() FROM parts '.
51 51
             'WHERE parts.instock >= 0'
52 52
         );
53 53
 
54 54
         //Migrate part locations for parts with unknown instock
55 55
         $this->addSql(
56
-            'INSERT INTO part_lots (id_part, id_store_location, amount, instock_unknown, last_modified, datetime_added) ' .
57
-            'SELECT parts.id, parts.id_storelocation, 0, 1, NOW(), NOW() FROM parts ' .
56
+            'INSERT INTO part_lots (id_part, id_store_location, amount, instock_unknown, last_modified, datetime_added) '.
57
+            'SELECT parts.id, parts.id_storelocation, 0, 1, NOW(), NOW() FROM parts '.
58 58
             'WHERE parts.instock = -2'
59 59
         );
60 60
 
Please login to merge, or discard this patch.
src/Migrations/Version1.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         try {
24 24
             //Check if we can use this migration method:
25
-            $version = (int)$this->connection->fetchColumn("SELECT keyValue AS version FROM `internal` WHERE `keyName` = 'dbVersion'");
25
+            $version = (int) $this->connection->fetchColumn("SELECT keyValue AS version FROM `internal` WHERE `keyName` = 'dbVersion'");
26 26
             $this->skipIf(true, "Old Part-DB Database detected! Continue with upgrade...");
27 27
         } catch (DBALException $ex) {
28 28
             //when the table was not found, we can proceed, because we have an empty DB!
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         $this->addSql('ALTER TABLE `groups` ADD CONSTRAINT FK_F06D3970727ACA70 FOREIGN KEY (parent_id) REFERENCES `groups` (id)');
81 81
 
82 82
         //Create table for user logs:
83
-        $sql =  $updateSteps[] = "CREATE TABLE `log` ".
83
+        $sql = $updateSteps[] = "CREATE TABLE `log` ".
84 84
             "( `id` INT NOT NULL AUTO_INCREMENT , `datetime` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP() ,".
85 85
             " `id_user` INT NOT NULL ,".
86 86
             " `level` TINYINT NOT NULL ,".
Please login to merge, or discard this patch.
src/Controller/PartController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             $attachments = $form['attachments'];
95 95
             foreach ($attachments as $attachment) {
96 96
                 /** @var $attachment FormInterface */
97
-                $attachmentHelper->upload( $attachment->getData(), $attachment['file']->getData());
97
+                $attachmentHelper->upload($attachment->getData(), $attachment['file']->getData());
98 98
             }
99 99
 
100 100
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
             $this->addFlash('info', $translator->trans('part.edited_flash'));
104 104
             //Reload form, so the SIUnitType entries use the new part unit
105 105
             $form = $this->createForm(PartBaseType::class, $part);
106
-        } elseif ($form->isSubmitted() && ! $form->isValid()) {
106
+        } elseif ($form->isSubmitted() && !$form->isValid()) {
107 107
             $this->addFlash('error', $translator->trans('part.edited_flash.invalid'));
108 108
         }
109 109
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     {
126 126
         $this->denyAccessUnlessGranted('delete', $part);
127 127
 
128
-        if ($this->isCsrfTokenValid('delete' . $part->getId(), $request->request->get('_token'))) {
128
+        if ($this->isCsrfTokenValid('delete'.$part->getId(), $request->request->get('_token'))) {
129 129
             $entityManager = $this->getDoctrine()->getManager();
130 130
 
131 131
             //Remove part
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
             $attachments = $form['attachments'];
170 170
             foreach ($attachments as $attachment) {
171 171
                 /** @var $attachment FormInterface */
172
-                $attachmentHelper->upload( $attachment->getData(), $attachment['file']->getData());
172
+                $attachmentHelper->upload($attachment->getData(), $attachment['file']->getData());
173 173
             }
174 174
 
175 175
             $em->persist($new_part);
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
             $this->addFlash('success', $translator->trans('part.created_flash'));
178 178
 
179 179
             return $this->redirectToRoute('part_edit', ['id' => $new_part->getID()]);
180
-        } elseif ($form->isSubmitted() && ! $form->isValid()) {
180
+        } elseif ($form->isSubmitted() && !$form->isValid()) {
181 181
             $this->addFlash('error', $translator->trans('part.created_flash.invalid'));
182 182
         }
183 183
 
Please login to merge, or discard this patch.
src/Form/AdminPages/ImportType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,12 +66,12 @@
 block discarded – undo
66 66
         //Disable import if user is not allowed to create elements.
67 67
         $entity = new $data['entity_class']();
68 68
         $perm_name = "create";
69
-        $disabled = ! $this->security->isGranted($perm_name, $entity);
69
+        $disabled = !$this->security->isGranted($perm_name, $entity);
70 70
 
71 71
         $builder
72 72
 
73 73
             ->add('format', ChoiceType::class, [
74
-                'choices' => ['JSON' => 'json', 'XML' => 'xml','CSV' => 'csv' ,'YAML' => 'yaml'],
74
+                'choices' => ['JSON' => 'json', 'XML' => 'xml', 'CSV' => 'csv', 'YAML' => 'yaml'],
75 75
                 'label' => $this->trans->trans('export.format'),
76 76
                 'disabled' => $disabled])
77 77
             ->add('csv_separator', TextType::class, ['data' => ';',
Please login to merge, or discard this patch.