App\Tests\Controller\AdminPages\AbstractAdminControllerTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	testDeleteEntity()	0	19	2
A	setUp()	0	4	1
A	readDataProvider()	0	7	1
A	testReadEntity()	0	18	2
A	testListEntries()	0	19	2
A	deleteDataProvider()	0	7	1

<?php
/**
 * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
 *
 * Copyright (C) 2019 Jan Böhmer (https://github.com/jbtronics)
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 */

namespace App\Tests\Controller\AdminPages;

use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * @group slow
 */
abstract class AbstractAdminControllerTest extends WebTestCase
{
    protected static $base_path = 'not_valid';
    protected static $entity_class = 'not valid';

    public function setUp()
    {
        parent::setUp();
        self::bootKernel();
    }

    public function readDataProvider()
    {
        return [
            ['noread', false],
            ['anonymous', true],
            ['user', true],
            ['admin', true],
        ];
    }

    /**
     * @dataProvider readDataProvider
     * @group slow
     * Tests if you can access the /new part which is used to list all entities. Checks if permissions are working
     */
    public function testListEntries(string $user, bool $read)
    {
        //Test read access
        $client = static::createClient([], [
            'PHP_AUTH_USER' => $user,
            'PHP_AUTH_PW' => 'test',
        ]);

        if (false == $read) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $this->expectException(AccessDeniedException::class);
        }

        $client->catchExceptions(false);

        //Test read/list access by access /new overview page
        $crawler = $client->request('GET', static::$base_path.'/new');

The assignment to $crawler is dead and can be removed.

        $this->assertFalse($client->getResponse()->isRedirect());
        $this->assertEquals($read, $client->getResponse()->isSuccessful(), 'Controller was not successful!');
        $this->assertEquals($read, !$client->getResponse()->isForbidden(), 'Permission Checking not working!');
    }

    /**
     * @dataProvider readDataProvider
     * @group slow
     * Tests if it possible to access an specific entity. Checks if permissions are working.
     */
    public function testReadEntity(string $user, bool $read)
    {
        //Test read access
        $client = static::createClient([], [
            'PHP_AUTH_USER' => $user,
            'PHP_AUTH_PW' => 'test',
        ]);

        $client->catchExceptions(false);
        if (false == $read) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $this->expectException(AccessDeniedException::class);
        }

        //Test read/list access by access /new overview page
        $crawler = $client->request('GET', static::$base_path.'/1');

The assignment to $crawler is dead and can be removed.

        $this->assertFalse($client->getResponse()->isRedirect());
        $this->assertEquals($read, $client->getResponse()->isSuccessful(), 'Controller was not successful!');
        $this->assertEquals($read, !$client->getResponse()->isForbidden(), 'Permission Checking not working!');
    }

    public function deleteDataProvider()
    {
        return [
            ['noread', false],
            ['anonymous', false],
            ['user', true],
            ['admin', true],
        ];
    }

    /**
     * Tests if deleting an entity is working.
     *
     * @group slow
     * @dataProvider deleteDataProvider
     */
    public function testDeleteEntity(string $user, bool $delete)
    {
        //Test read access
        $client = static::createClient([], [
            'PHP_AUTH_USER' => $user,
            'PHP_AUTH_PW' => 'test',
        ]);

        $client->catchExceptions(false);
        if (false == $delete) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $this->expectException(AccessDeniedException::class);
        }

        //Test read/list access by access /new overview page
        $crawler = $client->request('DELETE', static::$base_path.'/7');

The assignment to $crawler is dead and can be removed.

        //Page is redirected to '/new', when delete was successful
        $this->assertEquals($delete, $client->getResponse()->isRedirect(static::$base_path.'/new'));
        $this->assertEquals($delete, !$client->getResponse()->isForbidden(), 'Permission Checking not working!');
    }
}