BaseAdminController::_new() - Code Metrics - Inspection of "Allow admins to set passwords in users admin page." - Part-DB/Part-DB-symfony - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 694bec...006cd9 )

by Jan
created 2019-09-19 10:35 UTC
BaseAdminController::_new() C

↳ Parent: BaseAdminController
Complexity

Conditions	13
Paths	10
Size

Total Lines	74
Code Lines	38
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	13
eloc	38
nc	10
nop	3
dl	0
loc	74
rs	6.6166
c	0
b	0
f	0
How to fix Long Method Complexity

<?php
/**
 *
 * part-db version 0.1
 * Copyright (C) 2005 Christoph Lechner
 * http://www.cl-projects.de/
 *
 * part-db version 0.2+
 * Copyright (C) 2009 K. Jacobs and others (see authors.php)
 * http://code.google.com/p/part-db/
 *
 * Part-DB Version 0.4+
 * Copyright (C) 2016 - 2019 Jan Böhmer
 * https://github.com/jbtronics
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 *
 */

namespace App\Controller\AdminPages;

use App\Entity\Base\NamedDBElement;
use App\Entity\Base\StructuralDBElement;
use App\Entity\UserSystem\User;
use App\Form\AdminPages\ImportType;
use App\Form\AdminPages\MassCreationForm;
use App\Services\EntityExporter;
use App\Services\EntityImporter;
use App\Services\StructuralElementRecursionHelper;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Encoder\PasswordEncoderInterface;
use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
use Symfony\Component\Security\Core\Tests\Encoder\PasswordEncoder;
use Symfony\Component\Validator\ConstraintViolationList;
use Symfony\Contracts\Translation\TranslatorInterface;

abstract class BaseAdminController extends AbstractController
{

    protected $entity_class = '';
    protected $form_class = '';
    protected $twig_template = '';
    protected $route_base = '';


    protected $passwordEncoder;
    protected $translator;

    public function __construct(TranslatorInterface $translator, UserPasswordEncoderInterface $passwordEncoder)
    {
        if ($this->entity_class === '' || $this->form_class === '' || $this->twig_template === '' || $this->route_base === '') {

            throw new \InvalidArgumentException('You have to override the $entity_class, $form_class, $route_base and $twig_template value in your subclasss!');
        }

        $this->translator = $translator;
        $this->passwordEncoder = $passwordEncoder;
    }

    protected function _edit(NamedDBElement $entity, Request $request, EntityManagerInterface $em)
    {

        $this->denyAccessUnlessGranted('read', $entity);

        $form = $this->createForm($this->form_class, $entity);
        $form = $this->createForm(/** @scrutinizer ignore-type */ $this->form_class, $entity);

        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            //Check if we editing a user and if we need to change the password of it
            if ($entity instanceof User && !empty($form['new_password']->getData())) {
                $password = $this->passwordEncoder->encodePassword($entity, $form['new_password']->getData());
                $entity->setPassword($password);
                //By default the user must change the password afterwards
                $entity->setNeedPwChange(true);
            }

            $em->persist($entity);
            $em->flush();
            $this->addFlash('success', $this->translator->trans('entity.edit_flash'));

            //Rebuild form, so it is based on the updated data. Important for the parent field!
            //We can not use dynamic form events here, because the parent entity list is build from database!
            $form = $this->createForm($this->form_class, $entity);
        } elseif ($form->isSubmitted() && ! $form->isValid()) {
            $this->addFlash('error', $this->translator->trans('entity.edit_flash.invalid'));
        }

        return $this->render($this->twig_template, [
        return $this->render(/** @scrutinizer ignore-type */ $this->twig_template, [
            'entity' => $entity,
            'form' => $form->createView()
        ]);
    }

    protected function _new(Request $request, EntityManagerInterface $em, EntityImporter $importer)
    {
        /** @var StructuralDBElement $new_entity */
        $new_entity = new $this->entity_class();

        $this->denyAccessUnlessGranted('read', $new_entity);

        //Basic edit form
        $form = $this->createForm($this->form_class, $new_entity);
        $form = $this->createForm(/** @scrutinizer ignore-type */ $this->form_class, $new_entity);

        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            if ($new_entity instanceof User && !empty($form['new_password']->getData())) {

                $password = $this->passwordEncoder->encodePassword($new_entity, $form['new_password']->getData());
                $new_entity->setPassword($password);
                //By default the user must change the password afterwards
                $new_entity->setNeedPwChange(true);
            }
            $em->persist($new_entity);
            $em->flush();
            $this->addFlash('success', $this->translator->trans('entity.created_flash'));

            return $this->redirectToRoute($this->route_base . '_edit', ['id' => $new_entity->getID()]);
            return $this->redirectToRoute(/** @scrutinizer ignore-type */ $this->route_base . '_edit', ['id' => $new_entity->getID()]);
        }

        if ($form->isSubmitted() && ! $form->isValid()) {
            $this->addFlash('error', $this->translator->trans('entity.created_flash.invalid'));
        }

        //Import form
        $import_form = $this->createForm(ImportType::class, ['entity_class' => $this->entity_class]);
        $import_form->handleRequest($request);

        if ($import_form->isSubmitted() && $import_form->isValid()) {
            /** @var UploadedFile $file */
            $file = $import_form['file']->getData();
            $data = $import_form->getData();

            $options = array('parent' => $data['parent'], 'preserve_children' => $data['preserve_children'],
                'format' => $data['format'], 'csv_separator' => $data['csv_separator']);

            $errors = $importer->fileToDBEntities($file, $this->entity_class, $options);
            $errors = $importer->fileToDBEntities($file, /** @scrutinizer ignore-type */ $this->entity_class, $options);

            foreach ($errors as $name => $error) {
                /** @var $error ConstraintViolationList */
                $this->addFlash('error', $name . ':' . $error);
            }
        }

        //Mass creation form
        $mass_creation_form = $this->createForm(MassCreationForm::class, ['entity_class' => $this->entity_class]);
        $mass_creation_form->handleRequest($request);

        if ($mass_creation_form->isSubmitted() && $mass_creation_form->isValid()) {
            $data = $mass_creation_form->getData();

            dump($data);

            //Create entries based on input
            $errors = $importer->massCreation($data['lines'], $this->entity_class, $data['parent']);
            $errors = $importer->massCreation($data['lines'], /** @scrutinizer ignore-type */ $this->entity_class, $data['parent']);

            //Show errors to user:
            foreach ($errors as $name => $error) {
                /** @var $error ConstraintViolationList */
                $this->addFlash('error', $name . ':' . $error);
            }
        }

        return $this->render($this->twig_template, [
        return $this->render(/** @scrutinizer ignore-type */ $this->twig_template, [
            'entity' => $new_entity,
            'form' => $form->createView(),
            'import_form' => $import_form->createView(),
            'mass_creation_form' => $mass_creation_form->createView()
        ]);
    }

    protected function _delete(Request $request, NamedDBElement $entity, StructuralElementRecursionHelper $recursionHelper)
    {
        $this->denyAccessUnlessGranted('delete', $entity);

        if ($this->isCsrfTokenValid('delete'.$entity->getId(), $request->request->get('_token'))) {
            $entityManager = $this->getDoctrine()->getManager();

            //Check if we need to remove recursively
            if ($entity instanceof StructuralDBElement && $request->get('delete_recursive', false)) {
                $recursionHelper->delete($entity, false);
            } else {
                if ($entity instanceof StructuralDBElement) {
                    $parent = $entity->getParent();

                    //Move all sub entities to the current parent
                    foreach ($entity->getSubelements() as $subelement) {
                        $subelement->setParent($parent);
                        $entityManager->persist($subelement);
                    }
                }

                //Remove current element
                $entityManager->remove($entity);
            }

            //Flush changes
            $entityManager->flush();

            $this->addFlash('success', 'attachment_type.deleted');
        }

        return $this->redirectToRoute($this->route_base .  '_new');
        return $this->redirectToRoute(/** @scrutinizer ignore-type */ $this->route_base .  '_new');
    }

    protected function _exportAll(EntityManagerInterface $em, EntityExporter $exporter, Request $request)
    {
        $entity = new $this->entity_class();

        $this->denyAccessUnlessGranted('read', $entity);

        $entities = $em->getRepository($this->entity_class)->findAll();
        $entities = $em->getRepository(/** @scrutinizer ignore-type */ $this->entity_class)->findAll();

        return $exporter->exportEntityFromRequest($entities,$request);
    }

    protected function _exportEntity(NamedDBElement $entity, EntityExporter $exporter, Request $request)
    {
        $this->denyAccessUnlessGranted('read', $entity);

        return $exporter->exportEntityFromRequest($entity, $request);
    }
}
Part-DB / Part-DB-symfony

Push — master ( 694bec...006cd9 )

BaseAdminController::_new() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
