Passed
Push — master ( a50fec...5a733b )
by Jan
04:40
created
tests/Controller/AdminPages/AbstractAdminControllerTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $client->request('GET', static::$base_path.'/new');
91 91
         $this->assertFalse($client->getResponse()->isRedirect());
92 92
         $this->assertSame($read, $client->getResponse()->isSuccessful(), 'Controller was not successful!');
93
-        $this->assertSame($read, ! $client->getResponse()->isForbidden(), 'Permission Checking not working!');
93
+        $this->assertSame($read, !$client->getResponse()->isForbidden(), 'Permission Checking not working!');
94 94
     }
95 95
 
96 96
     /**
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         $client->request('GET', static::$base_path.'/1');
116 116
         $this->assertFalse($client->getResponse()->isRedirect());
117 117
         $this->assertSame($read, $client->getResponse()->isSuccessful(), 'Controller was not successful!');
118
-        $this->assertSame($read, ! $client->getResponse()->isForbidden(), 'Permission Checking not working!');
118
+        $this->assertSame($read, !$client->getResponse()->isForbidden(), 'Permission Checking not working!');
119 119
     }
120 120
 
121 121
     public function deleteDataProvider(): array
@@ -152,6 +152,6 @@  discard block
 block discarded – undo
152 152
 
153 153
         //Page is redirected to '/new', when delete was successful
154 154
         $this->assertSame($delete, $client->getResponse()->isRedirect(static::$base_path.'/new'));
155
-        $this->assertSame($delete, ! $client->getResponse()->isForbidden(), 'Permission Checking not working!');
155
+        $this->assertSame($delete, !$client->getResponse()->isForbidden(), 'Permission Checking not working!');
156 156
     }
157 157
 }
Please login to merge, or discard this patch.
src/EventSubscriber/SymfonyDebugToolbarSubscriber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
 
82 82
     public function onKernelResponse(ResponseEvent $event): void
83 83
     {
84
-        if (! $this->kernel_debug) {
84
+        if (!$this->kernel_debug) {
85 85
             return;
86 86
         }
87 87
 
Please login to merge, or discard this patch.
src/Security/Voter/ExtendedVoter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
         }
77 77
 
78 78
         // if the user is anonymous, we use the anonymous user.
79
-        if (! $user instanceof User) {
79
+        if (!$user instanceof User) {
80 80
             /** @var UserRepository $repo */
81 81
             $repo = $this->entityManager->getRepository(User::class);
82 82
             $user = $repo->getAnonymousUser();
Please login to merge, or discard this patch.
src/Services/GitVersionInfo.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
             $git = file($this->project_dir.'/.git/HEAD');
65 65
             $head = explode('/', $git[0], 3);
66 66
 
67
-            if (! isset($head[2])) {
67
+            if (!isset($head[2])) {
68 68
                 return null;
69 69
             }
70 70
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         if (is_file($filename)) {
90 90
             $head = file($filename);
91 91
 
92
-            if (! isset($head[0])) {
92
+            if (!isset($head[0])) {
93 93
                 return null;
94 94
             }
95 95
 
Please login to merge, or discard this patch.
src/Form/AdminPages/BaseEntityAdminForm.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -93,14 +93,14 @@  discard block
 block discarded – undo
93 93
                 'attr' => [
94 94
                     'placeholder' => 'part.name.placeholder',
95 95
                 ],
96
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
96
+                'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
97 97
             ])
98 98
 
99 99
             ->add('parent', StructuralEntityType::class, [
100 100
                 'class' => get_class($entity),
101 101
                 'required' => false,
102 102
                 'label' => 'parent.label',
103
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
103
+                'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
104 104
             ])
105 105
 
106 106
             ->add('not_selectable', CheckboxType::class, [
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
                 'label_attr' => [
111 111
                     'class' => 'checkbox-custom',
112 112
                 ],
113
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
113
+                'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
114 114
             ])
115 115
 
116 116
             ->add('comment', CKEditorType::class, [
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
                     'rows' => 4,
122 122
                 ],
123 123
                 'help' => 'bbcode.hint',
124
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
124
+                'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
125 125
             ]);
126 126
 
127 127
         $this->additionalFormElements($builder, $options, $entity);
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
             'allow_delete' => true,
134 134
             'label' => false,
135 135
             'reindex_enable' => true,
136
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
136
+            'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
137 137
             'entry_options' => [
138 138
                 'data_class' => $options['attachment_class'],
139 139
             ],
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
         $builder->add('master_picture_attachment', MasterPictureAttachmentType::class, [
144 144
             'required' => false,
145
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
145
+            'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
146 146
             'label' => 'part.edit.master_attachment',
147 147
             'entity' => $entity,
148 148
         ]);
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
             'entry_type' => ParameterType::class,
159 159
             'allow_add' => $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
160 160
             'allow_delete' => $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
161
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
161
+            'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
162 162
             'reindex_enable' => true,
163 163
             'label' => false,
164 164
             'by_reference' => false,
@@ -174,11 +174,11 @@  discard block
 block discarded – undo
174 174
             'attr' => [
175 175
                 'class' => $is_new ? 'btn-success' : '',
176 176
             ],
177
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
177
+            'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
178 178
         ])
179 179
             ->add('reset', ResetType::class, [
180 180
                 'label' => 'entity.edit.reset',
181
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
181
+                'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
182 182
             ]);
183 183
     }
184 184
 
Please login to merge, or discard this patch.
src/Controller/PartController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
             $this->addFlash('info', 'part.edited_flash');
184 184
             //Reload form, so the SIUnitType entries use the new part unit
185 185
             $form = $this->createForm(PartBaseType::class, $part);
186
-        } elseif ($form->isSubmitted() && ! $form->isValid()) {
186
+        } elseif ($form->isSubmitted() && !$form->isValid()) {
187 187
             $this->addFlash('error', 'part.edited_flash.invalid');
188 188
         }
189 189
 
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
      * @return Response
228 228
      */
229 229
     public function new(Request $request, EntityManagerInterface $em, TranslatorInterface $translator,
230
-        AttachmentSubmitHandler $attachmentSubmitHandler, ?Part $part = null): Response
230
+        AttachmentSubmitHandler $attachmentSubmitHandler, ?Part $part = null) : Response
231 231
     {
232 232
         if (null === $part) {
233 233
             $new_part = new Part();
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
         }
257 257
 
258 258
         $store_id = $request->get('storelocation', null);
259
-        $storelocation = $store_id ? $em->find(Storelocation::class, $store_id): null;
259
+        $storelocation = $store_id ? $em->find(Storelocation::class, $store_id) : null;
260 260
         if (null !== $storelocation && $new_part->getPartLots()->isEmpty()) {
261 261
             $partLot = new PartLot();
262 262
             $partLot->setStorageLocation($storelocation);
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         }
266 266
 
267 267
         $supplier_id = $request->get('supplier', null);
268
-        $supplier = $supplier_id ? $em->find(Supplier::class, $supplier_id): null;
268
+        $supplier = $supplier_id ? $em->find(Supplier::class, $supplier_id) : null;
269 269
         if (null !== $supplier && $new_part->getOrderdetails()->isEmpty()) {
270 270
             $orderdetail = new Orderdetail();
271 271
             $orderdetail->setSupplier($supplier);
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
             return $this->redirectToRoute('part_edit', ['id' => $new_part->getID()]);
307 307
         }
308 308
 
309
-        if ($form->isSubmitted() && ! $form->isValid()) {
309
+        if ($form->isSubmitted() && !$form->isValid()) {
310 310
             $this->addFlash('error', 'part.created_flash.invalid');
311 311
         }
312 312
 
Please login to merge, or discard this patch.
src/Controller/SecurityController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function requestPwReset(PasswordResetManager $passwordReset, Request $request)
102 102
     {
103
-        if (! $this->allow_email_pw_reset) {
103
+        if (!$this->allow_email_pw_reset) {
104 104
             throw new AccessDeniedHttpException('The password reset via email is disabled!');
105 105
         }
106 106
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
      */
145 145
     public function pwResetNewPw(PasswordResetManager $passwordReset, Request $request, EntityManagerInterface $em, EventDispatcherInterface $eventDispatcher, ?string $user = null, ?string $token = null)
146 146
     {
147
-        if (! $this->allow_email_pw_reset) {
147
+        if (!$this->allow_email_pw_reset) {
148 148
             throw new AccessDeniedHttpException('The password reset via email is disabled!');
149 149
         }
150 150
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
             $data = $form->getData();
190 190
             //Try to set the new password
191 191
             $success = $passwordReset->setNewPassword($data['username'], $data['token'], $data['new_password']);
192
-            if (! $success) {
192
+            if (!$success) {
193 193
                 $this->addFlash('error', 'pw_reset.new_pw.error');
194 194
             } else {
195 195
                 $this->addFlash('success', 'pw_reset.new_pw.success');
Please login to merge, or discard this patch.
src/Form/UserSettingsType.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -72,27 +72,27 @@  discard block
 block discarded – undo
72 72
         $builder
73 73
             ->add('name', TextType::class, [
74 74
                 'label' => 'user.username.label',
75
-                'disabled' => ! $this->security->isGranted('edit_username', $options['data']) || $this->demo_mode,
75
+                'disabled' => !$this->security->isGranted('edit_username', $options['data']) || $this->demo_mode,
76 76
             ])
77 77
             ->add('first_name', TextType::class, [
78 78
                 'required' => false,
79 79
                 'label' => 'user.firstName.label',
80
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
80
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
81 81
             ])
82 82
             ->add('last_name', TextType::class, [
83 83
                 'required' => false,
84 84
                 'label' => 'user.lastName.label',
85
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
85
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
86 86
             ])
87 87
             ->add('department', TextType::class, [
88 88
                 'required' => false,
89 89
                 'label' => 'user.department.label',
90
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
90
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
91 91
             ])
92 92
             ->add('email', EmailType::class, [
93 93
                 'required' => false,
94 94
                 'label' => 'user.email.label',
95
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
95
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
96 96
             ])
97 97
             ->add('language', LanguageType::class, [
98 98
                 'disabled' => $this->demo_mode,
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                 ],
125 125
                 'translation_domain' => false,
126 126
                 'choices' => User::AVAILABLE_THEMES,
127
-                'choice_label' => function ($entity, $key, $value) {
127
+                'choice_label' => function($entity, $key, $value) {
128 128
                     return $value;
129 129
                 },
130 130
                 'placeholder' => 'user_settings.theme.placeholder',
Please login to merge, or discard this patch.
src/DataTables/LogDataTable.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
         $optionsResolver->setAllowedTypes('filter_elements', ['array', 'object']);
103 103
         $optionsResolver->setAllowedTypes('mode', 'string');
104 104
 
105
-        $optionsResolver->setNormalizer('filter_elements', function (Options $options, $value) {
105
+        $optionsResolver->setNormalizer('filter_elements', function(Options $options, $value) {
106 106
             if (!is_array($value)) {
107 107
                 return [$value];
108 108
             }
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 
121 121
         $dataTable->add('symbol', TextColumn::class, [
122 122
             'label' => '',
123
-            'render' => function ($value, AbstractLogEntry $context) {
123
+            'render' => function($value, AbstractLogEntry $context) {
124 124
                 switch ($context->getLevelString()) {
125 125
                     case LogLevel::DEBUG:
126 126
                         $symbol = 'fa-bug';
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
         $dataTable->add('type', TextColumn::class, [
182 182
             'label' => $this->translator->trans('log.type'),
183 183
             'propertyPath' => 'type',
184
-            'render' => function (string $value, AbstractLogEntry $context) {
184
+            'render' => function(string $value, AbstractLogEntry $context) {
185 185
                 return $this->translator->trans('log.type.'.$value);
186 186
             },
187 187
         ]);
@@ -190,14 +190,14 @@  discard block
 block discarded – undo
190 190
             'label' => $this->translator->trans('log.level'),
191 191
             'visible' => 'system_log' === $options['mode'],
192 192
             'propertyPath' => 'levelString',
193
-            'render' => function (string $value, AbstractLogEntry $context) {
193
+            'render' => function(string $value, AbstractLogEntry $context) {
194 194
                 return $value;
195 195
             },
196 196
         ]);
197 197
 
198 198
         $dataTable->add('user', TextColumn::class, [
199 199
             'label' => $this->translator->trans('log.user'),
200
-            'render' => function ($value, AbstractLogEntry $context) {
200
+            'render' => function($value, AbstractLogEntry $context) {
201 201
                 $user = $context->getUser();
202 202
 
203 203
                 return sprintf(
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
         $dataTable->add('target_type', TextColumn::class, [
212 212
             'label' => $this->translator->trans('log.target_type'),
213 213
             'visible' => false,
214
-            'render' => function ($value, AbstractLogEntry $context) {
214
+            'render' => function($value, AbstractLogEntry $context) {
215 215
                 $class = $context->getTargetClass();
216 216
                 if (null !== $class) {
217 217
                     return $this->elementTypeNameGenerator->getLocalizedTypeLabel($class);
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
         $dataTable->add('timeTravel', IconLinkColumn::class, [
234 234
             'label' => '',
235 235
             'icon' => 'fas fa-fw fa-eye',
236
-            'href' => function ($value, AbstractLogEntry $context) {
236
+            'href' => function($value, AbstractLogEntry $context) {
237 237
                 if (
238 238
                     ($context instanceof TimeTravelInterface
239 239
                         && $context->hasOldDataInformations())
@@ -251,10 +251,10 @@  discard block
 block discarded – undo
251 251
 
252 252
                 return null;
253 253
             },
254
-            'disabled' => function ($value, AbstractLogEntry $context) {
254
+            'disabled' => function($value, AbstractLogEntry $context) {
255 255
                 return
256
-                    ! $this->security->isGranted('@tools.timetravel')
257
-                    || ! $this->security->isGranted('show_history', $context->getTargetClass());
256
+                    !$this->security->isGranted('@tools.timetravel')
257
+                    || !$this->security->isGranted('show_history', $context->getTargetClass());
258 258
             },
259 259
         ]);
260 260
 
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 
267 267
         $dataTable->createAdapter(ORMAdapter::class, [
268 268
             'entity' => AbstractLogEntry::class,
269
-            'query' => function (QueryBuilder $builder) use ($options): void {
269
+            'query' => function(QueryBuilder $builder) use ($options): void {
270 270
                 $this->getQuery($builder, $options);
271 271
             },
272 272
         ]);
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
             ]);
293 293
         }
294 294
 
295
-        if (! empty($options['filter_elements'])) {
295
+        if (!empty($options['filter_elements'])) {
296 296
             foreach ($options['filter_elements'] as $element) {
297 297
                 /** @var AbstractDBElement $element */
298 298
 
Please login to merge, or discard this patch.