Passed
Pull Request — master (#70)
by Jan
11:26
created
src/Repository/Parts/SupplierRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
             ->setParameter(1, $element);
38 38
 
39 39
         foreach ($order_by as $field => $order) {
40
-            $qb->addOrderBy('part.' . $field, $order);
40
+            $qb->addOrderBy('part.'.$field, $order);
41 41
         }
42 42
 
43 43
         return $qb->getQuery()->getResult();
Please login to merge, or discard this patch.
src/Repository/Parts/StorelocationRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
             ->setParameter(1, $element);
38 38
 
39 39
         foreach ($order_by as $field => $order) {
40
-            $qb->addOrderBy('part.' . $field, $order);
40
+            $qb->addOrderBy('part.'.$field, $order);
41 41
         }
42 42
 
43 43
         return $qb->getQuery()->getResult();
Please login to merge, or discard this patch.
src/Form/Part/PartBaseType.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
                 'attr' => [
105 105
                     'placeholder' => 'part.edit.name.placeholder',
106 106
                 ],
107
-                'disabled' => ! $this->security->isGranted('name.edit', $part),
107
+                'disabled' => !$this->security->isGranted('name.edit', $part),
108 108
             ])
109 109
             ->add('description', CKEditorType::class, [
110 110
                 'required' => false,
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
                     'placeholder' => 'part.edit.description.placeholder',
116 116
                     'rows' => 2,
117 117
                 ],
118
-                'disabled' => ! $this->security->isGranted('description.edit', $part),
118
+                'disabled' => !$this->security->isGranted('description.edit', $part),
119 119
             ])
120 120
             ->add('minAmount', SIUnitType::class, [
121 121
                 'attr' => [
@@ -124,13 +124,13 @@  discard block
 block discarded – undo
124 124
                 ],
125 125
                 'label' => 'part.edit.mininstock',
126 126
                 'measurement_unit' => $part->getPartUnit(),
127
-                'disabled' => ! $this->security->isGranted('minamount.edit', $part),
127
+                'disabled' => !$this->security->isGranted('minamount.edit', $part),
128 128
             ])
129 129
             ->add('category', StructuralEntityType::class, [
130 130
                 'class' => Category::class,
131 131
                 'label' => 'part.edit.category',
132 132
                 'disable_not_selectable' => true,
133
-                'disabled' => ! $this->security->isGranted('category.edit', $part),
133
+                'disabled' => !$this->security->isGranted('category.edit', $part),
134 134
                 'constraints' => [
135 135
 
136 136
                 ]
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
                 'required' => false,
141 141
                 'label' => 'part.edit.footprint',
142 142
                 'disable_not_selectable' => true,
143
-                'disabled' => ! $this->security->isGranted('footprint.edit', $part),
143
+                'disabled' => !$this->security->isGranted('footprint.edit', $part),
144 144
             ])
145 145
             ->add('tags', TextType::class, [
146 146
                 'required' => false,
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
                     'class' => 'tagsinput',
151 151
                     'data-autocomplete' => $this->urlGenerator->generate('typeahead_tags', ['query' => 'QUERY']),
152 152
                 ],
153
-                'disabled' => ! $this->security->isGranted('tags.edit', $part),
153
+                'disabled' => !$this->security->isGranted('tags.edit', $part),
154 154
             ]);
155 155
 
156 156
         //Manufacturer section
@@ -159,25 +159,25 @@  discard block
 block discarded – undo
159 159
             'required' => false,
160 160
             'label' => 'part.edit.manufacturer.label',
161 161
             'disable_not_selectable' => true,
162
-            'disabled' => ! $this->security->isGranted('manufacturer.edit', $part),
162
+            'disabled' => !$this->security->isGranted('manufacturer.edit', $part),
163 163
         ])
164 164
             ->add('manufacturer_product_url', UrlType::class, [
165 165
                 'required' => false,
166 166
                 'empty_data' => '',
167 167
                 'label' => 'part.edit.manufacturer_url.label',
168
-                'disabled' => ! $this->security->isGranted('mpn.edit', $part),
168
+                'disabled' => !$this->security->isGranted('mpn.edit', $part),
169 169
             ])
170 170
             ->add('manufacturer_product_number', TextType::class, [
171 171
                 'required' => false,
172 172
                 'empty_data' => '',
173 173
                 'label' => 'part.edit.mpn',
174
-                'disabled' => ! $this->security->isGranted('mpn.edit', $part),
174
+                'disabled' => !$this->security->isGranted('mpn.edit', $part),
175 175
             ])
176 176
             ->add('manufacturing_status', ChoiceType::class, [
177 177
                 'label' => 'part.edit.manufacturing_status',
178 178
                 'choices' => $status_choices,
179 179
                 'required' => false,
180
-                'disabled' => ! $this->security->isGranted('status.edit', $part),
180
+                'disabled' => !$this->security->isGranted('status.edit', $part),
181 181
             ]);
182 182
 
183 183
         //Advanced section
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
             ],
188 188
             'required' => false,
189 189
             'label' => 'part.edit.needs_review',
190
-            'disabled' => ! $this->security->isGranted('edit', $part),
190
+            'disabled' => !$this->security->isGranted('edit', $part),
191 191
         ])
192 192
             ->add('favorite', CheckboxType::class, [
193 193
                 'label_attr' => [
@@ -195,20 +195,20 @@  discard block
 block discarded – undo
195 195
                 ],
196 196
                 'required' => false,
197 197
                 'label' => 'part.edit.is_favorite',
198
-                'disabled' => ! $this->security->isGranted('change_favorite', $part),
198
+                'disabled' => !$this->security->isGranted('change_favorite', $part),
199 199
             ])
200 200
             ->add('mass', SIUnitType::class, [
201 201
                 'unit' => 'g',
202 202
                 'label' => 'part.edit.mass',
203 203
                 'required' => false,
204
-                'disabled' => ! $this->security->isGranted('mass.edit', $part),
204
+                'disabled' => !$this->security->isGranted('mass.edit', $part),
205 205
             ])
206 206
             ->add('partUnit', StructuralEntityType::class, [
207 207
                 'class' => MeasurementUnit::class,
208 208
                 'required' => false,
209 209
                 'disable_not_selectable' => true,
210 210
                 'label' => 'part.edit.partUnit',
211
-                'disabled' => ! $this->security->isGranted('unit.edit', $part),
211
+                'disabled' => !$this->security->isGranted('unit.edit', $part),
212 212
             ]);
213 213
 
214 214
         //Comment section
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
             'attr' => [
219 219
                 'rows' => 4,
220 220
             ],
221
-            'disabled' => ! $this->security->isGranted('comment.edit', $part),
221
+            'disabled' => !$this->security->isGranted('comment.edit', $part),
222 222
             'empty_data' => '',
223 223
         ]);
224 224
 
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
             'label' => false,
232 232
             'entry_options' => [
233 233
                 'measurement_unit' => $part->getPartUnit(),
234
-                'disabled' => ! $this->security->isGranted('lots.edit', $part),
234
+                'disabled' => !$this->security->isGranted('lots.edit', $part),
235 235
             ],
236 236
             'by_reference' => false,
237 237
         ]);
@@ -245,14 +245,14 @@  discard block
 block discarded – undo
245 245
             'label' => false,
246 246
             'entry_options' => [
247 247
                 'data_class' => PartAttachment::class,
248
-                'disabled' => ! $this->security->isGranted('attachments.edit', $part),
248
+                'disabled' => !$this->security->isGranted('attachments.edit', $part),
249 249
             ],
250 250
             'by_reference' => false,
251 251
         ]);
252 252
 
253 253
         $builder->add('master_picture_attachment', MasterPictureAttachmentType::class, [
254 254
             'required' => false,
255
-            'disabled' => ! $this->security->isGranted('attachments.edit', $part),
255
+            'disabled' => !$this->security->isGranted('attachments.edit', $part),
256 256
             'label' => 'part.edit.master_attachment',
257 257
             'entity' => $part,
258 258
         ]);
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
             'prototype_data' => new Orderdetail(),
269 269
             'entry_options' => [
270 270
                 'measurement_unit' => $part->getPartUnit(),
271
-                'disabled' => ! $this->security->isGranted('orderdetails.edit', $part),
271
+                'disabled' => !$this->security->isGranted('orderdetails.edit', $part),
272 272
             ],
273 273
         ]);
274 274
 
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
             'by_reference' => false,
282 282
             'prototype_data' => new PartParameter(),
283 283
             'entry_options' => [
284
-                'disabled' => ! $this->security->isGranted('parameters.edit', $part),
284
+                'disabled' => !$this->security->isGranted('parameters.edit', $part),
285 285
                 'data_class' => PartParameter::class,
286 286
             ],
287 287
         ]);
Please login to merge, or discard this patch.
src/Form/AdminPages/SupplierForm.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             'required' => false,
72 72
             'label' => 'supplier.edit.default_currency',
73 73
             'disable_not_selectable' => true,
74
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
74
+            'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
75 75
         ]);
76 76
 
77 77
         $builder->add('shipping_costs', BigDecimalMoneyType::class, [
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             'currency' => $this->default_currency,
80 80
             'scale' => 3,
81 81
             'label' => 'supplier.shipping_costs.label',
82
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
82
+            'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
83 83
         ]);
84 84
     }
85 85
 }
Please login to merge, or discard this patch.
src/Controller/SelectAPIController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -107,12 +107,12 @@
 block discarded – undo
107 107
         foreach ($nodes_list as $node) {
108 108
             /** @var AbstractStructuralDBElement $node */
109 109
             $entry = [
110
-                'text' => str_repeat('   ', $node->getLevel()) . htmlspecialchars($node->getName()),
110
+                'text' => str_repeat('   ', $node->getLevel()).htmlspecialchars($node->getName()),
111 111
                 'value' => $node->getID(),
112 112
                 'data-subtext' => $node->getParent() ? $node->getParent()->getFullPath() : null,
113 113
             ];
114 114
 
115
-            $entries[] =  $entry;
115
+            $entries[] = $entry;
116 116
         }
117 117
 
118 118
         return $entries;
Please login to merge, or discard this patch.
src/Services/Parts/PartsTableActionHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
                     break;
100 100
 
101 101
                 default:
102
-                    throw new \InvalidArgumentException('The given action is unknown! (' . $action . ')');
102
+                    throw new \InvalidArgumentException('The given action is unknown! ('.$action.')');
103 103
             }
104 104
         }
105 105
     }
Please login to merge, or discard this patch.
src/DataTables/AttachmentDataTable.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
79 79
     {
80 80
         $dataTable->add('picture', TextColumn::class, [
81 81
             'label' => '',
82
-            'render' => function ($value, Attachment $context) {
82
+            'render' => function($value, Attachment $context) {
83 83
                 if ($context->isPicture()
84
-                    && ! $context->isExternal()
84
+                    && !$context->isExternal()
85 85
                     && $this->attachmentHelper->isFileExisting($context)) {
86 86
 
87 87
                     $title = htmlspecialchars($context->getName());
88 88
                     if ($context->getFilename()) {
89
-                        $title .= ' (' . htmlspecialchars($context->getFilename()) . ')';
89
+                        $title .= ' ('.htmlspecialchars($context->getFilename()).')';
90 90
                     }
91 91
 
92 92
                     return sprintf(
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
         $dataTable->add('name', TextColumn::class, [
107 107
             'label' => 'attachment.edit.name',
108
-            'render' => function ($value, Attachment $context) {
108
+            'render' => function($value, Attachment $context) {
109 109
                 //Link to external source
110 110
                 if ($context->isExternal()) {
111 111
                     return sprintf(
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
         $dataTable->add('attachment_type', TextColumn::class, [
131 131
             'label' => 'attachment.table.type',
132 132
             'field' => 'attachment_type.name',
133
-            'render' => function ($value, Attachment $context) {
133
+            'render' => function($value, Attachment $context) {
134 134
                 return sprintf(
135 135
                     '<a href="%s">%s</a>',
136 136
                     $this->entityURLGenerator->editURL($context->getAttachmentType()),
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         $dataTable->add('element', TextColumn::class, [
143 143
             'label' => 'attachment.table.element',
144 144
             //'propertyPath' => 'element.name',
145
-            'render' => function ($value, Attachment $context) {
145
+            'render' => function($value, Attachment $context) {
146 146
                 return sprintf(
147 147
                     '<a href="%s">%s</a>',
148 148
                     $this->entityURLGenerator->infoURL($context->getElement()),
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 
159 159
         $dataTable->add('filesize', TextColumn::class, [
160 160
             'label' => $this->translator->trans('attachment.table.filesize'),
161
-            'render' => function ($value, Attachment $context) {
161
+            'render' => function($value, Attachment $context) {
162 162
                 if ($this->attachmentHelper->isFileExisting($context)) {
163 163
                     return $this->attachmentHelper->getHumanFileSize($context);
164 164
                 }
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 
223 223
         $dataTable->createAdapter(ORMAdapter::class, [
224 224
             'entity' => Attachment::class,
225
-            'query' => function (QueryBuilder $builder): void {
225
+            'query' => function(QueryBuilder $builder): void {
226 226
                 $this->getQuery($builder);
227 227
             },
228 228
         ]);
Please login to merge, or discard this patch.
src/DataTables/PartsDataTable.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         $optionsResolver->setAllowedTypes('search', ['null', 'string']);
120 120
 
121 121
         //Configure search options
122
-        $optionsResolver->setDefault('search_options', function (OptionsResolver $resolver): void {
122
+        $optionsResolver->setDefault('search_options', function(OptionsResolver $resolver): void {
123 123
             $resolver->setDefaults([
124 124
                 'name' => true,
125 125
                 'category' => true,
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
         $dataTable
156 156
             ->add('picture', TextColumn::class, [
157 157
                 'label' => '',
158
-                'render' => function ($value, Part $context) {
158
+                'render' => function($value, Part $context) {
159 159
                     $preview_attachment = $this->previewGenerator->getTablePreviewAttachment($context);
160 160
                     if (null === $preview_attachment) {
161 161
                         return '';
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 
164 164
                     $title = htmlspecialchars($preview_attachment->getName());
165 165
                     if ($preview_attachment->getFilename()) {
166
-                        $title .= ' (' . htmlspecialchars($preview_attachment->getFilename()) . ')';
166
+                        $title .= ' ('.htmlspecialchars($preview_attachment->getFilename()).')';
167 167
                     }
168 168
 
169 169
                     return sprintf(
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
             ])
179 179
             ->add('name', TextColumn::class, [
180 180
                 'label' => $this->translator->trans('part.table.name'),
181
-                'render' => function ($value, Part $context) {
181
+                'render' => function($value, Part $context) {
182 182
                     return sprintf(
183 183
                         '<a href="%s">%s</a>',
184 184
                         $this->urlGenerator->infoURL($context),
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
             ])
208 208
             ->add('storelocation', TextColumn::class, [
209 209
                 'label' => $this->translator->trans('part.table.storeLocations'),
210
-                'render' => function ($value, Part $context) {
210
+                'render' => function($value, Part $context) {
211 211
                     $tmp = [];
212 212
                     foreach ($context->getPartLots() as $lot) {
213 213
                         //Ignore lots without storelocation
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
             ])
227 227
             ->add('amount', TextColumn::class, [
228 228
                 'label' => $this->translator->trans('part.table.amount'),
229
-                'render' => function ($value, Part $context) {
229
+                'render' => function($value, Part $context) {
230 230
                     $amount = $context->getAmountSum();
231 231
 
232 232
                     return $this->amountFormatter->format($amount, $context->getPartUnit());
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
             ->add('minamount', TextColumn::class, [
236 236
                 'label' => $this->translator->trans('part.table.minamount'),
237 237
                 'visible' => false,
238
-                'render' => function ($value, Part $context) {
238
+                'render' => function($value, Part $context) {
239 239
                     return $this->amountFormatter->format($value, $context->getPartUnit());
240 240
                 },
241 241
             ])
@@ -298,10 +298,10 @@  discard block
 block discarded – undo
298 298
             ->add('edit', IconLinkColumn::class, [
299 299
                 'label' => $this->translator->trans('part.table.edit'),
300 300
                 'visible' => false,
301
-                'href' => function ($value, Part $context) {
301
+                'href' => function($value, Part $context) {
302 302
                     return $this->urlGenerator->editURL($context);
303 303
                 },
304
-                'disabled' => function ($value, Part $context) {
304
+                'disabled' => function($value, Part $context) {
305 305
                     return !$this->security->isGranted('edit', $context);
306 306
                 },
307 307
                 'title' => $this->translator->trans('part.table.edit.title'),
@@ -310,12 +310,12 @@  discard block
 block discarded – undo
310 310
             ->addOrderBy('name')
311 311
             ->createAdapter(FetchJoinORMAdapter::class, [
312 312
                 'simple_total_query' => true,
313
-                'query' => function (QueryBuilder $builder): void {
313
+                'query' => function(QueryBuilder $builder): void {
314 314
                     $this->getQuery($builder);
315 315
                 },
316 316
                 'entity' => Part::class,
317 317
                 'criteria' => [
318
-                    function (QueryBuilder $builder) use ($options): void {
318
+                    function(QueryBuilder $builder) use ($options): void {
319 319
                         $this->buildCriteria($builder, $options);
320 320
                     },
321 321
                     new SearchCriteriaProvider(),
@@ -396,8 +396,8 @@  discard block
 block discarded – undo
396 396
             $builder->andWhere('part.tags LIKE :tag')->setParameter('tag', '%'.$options['tag'].'%');
397 397
         }
398 398
 
399
-        if (! empty($options['search'])) {
400
-            if (! $options['search_options']['regex']) {
399
+        if (!empty($options['search'])) {
400
+            if (!$options['search_options']['regex']) {
401 401
                 //Dont show results, if no things are selected
402 402
                 $builder->andWhere('0=1');
403 403
                 $defined = false;
Please login to merge, or discard this patch.
src/Controller/PartController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 
189 189
             //Reload form, so the SIUnitType entries use the new part unit
190 190
             $form = $this->createForm(PartBaseType::class, $part);
191
-        } elseif ($form->isSubmitted() && ! $form->isValid()) {
191
+        } elseif ($form->isSubmitted() && !$form->isValid()) {
192 192
             $this->addFlash('error', 'part.edited_flash.invalid');
193 193
         }
194 194
 
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
      * @return Response
233 233
      */
234 234
     public function new(Request $request, EntityManagerInterface $em, TranslatorInterface $translator,
235
-        AttachmentSubmitHandler $attachmentSubmitHandler, ?Part $part = null): Response
235
+        AttachmentSubmitHandler $attachmentSubmitHandler, ?Part $part = null) : Response
236 236
     {
237 237
         if (null === $part) {
238 238
             $new_part = new Part();
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
             return $this->redirectToRoute('part_edit', ['id' => $new_part->getID()]);
316 316
         }
317 317
 
318
-        if ($form->isSubmitted() && ! $form->isValid()) {
318
+        if ($form->isSubmitted() && !$form->isValid()) {
319 319
             $this->addFlash('error', 'part.created_flash.invalid');
320 320
         }
321 321
 
Please login to merge, or discard this patch.