Passed
Push — master ( da72f5...6369ee )
by Jan
04:43
created
src/Form/Part/PartBaseType.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
                 'attr' => [
85 85
                     'placeholder' => 'part.edit.name.placeholder',
86 86
                 ],
87
-                'disabled' => ! $this->security->isGranted('name.edit', $part),
87
+                'disabled' => !$this->security->isGranted('name.edit', $part),
88 88
             ])
89 89
             ->add('description', CKEditorType::class, [
90 90
                 'required' => false,
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
                     'placeholder' => 'part.edit.description.placeholder',
96 96
                     'rows' => 2,
97 97
                 ],
98
-                'disabled' => ! $this->security->isGranted('description.edit', $part),
98
+                'disabled' => !$this->security->isGranted('description.edit', $part),
99 99
             ])
100 100
             ->add('minAmount', SIUnitType::class, [
101 101
                 'attr' => [
@@ -104,20 +104,20 @@  discard block
 block discarded – undo
104 104
                 ],
105 105
                 'label' => 'part.edit.mininstock',
106 106
                 'measurement_unit' => $part->getPartUnit(),
107
-                'disabled' => ! $this->security->isGranted('minamount.edit', $part),
107
+                'disabled' => !$this->security->isGranted('minamount.edit', $part),
108 108
             ])
109 109
             ->add('category', StructuralEntityType::class, [
110 110
                 'class' => Category::class,
111 111
                 'label' => 'part.edit.category',
112 112
                 'disable_not_selectable' => true,
113
-                'disabled' => ! $this->security->isGranted('category.edit', $part),
113
+                'disabled' => !$this->security->isGranted('category.edit', $part),
114 114
             ])
115 115
             ->add('footprint', StructuralEntityType::class, [
116 116
                 'class' => Footprint::class,
117 117
                 'required' => false,
118 118
                 'label' => 'part.edit.footprint',
119 119
                 'disable_not_selectable' => true,
120
-                'disabled' => ! $this->security->isGranted('footprint.edit', $part),
120
+                'disabled' => !$this->security->isGranted('footprint.edit', $part),
121 121
             ])
122 122
             ->add('tags', TextType::class, [
123 123
                 'required' => false,
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
                     'class' => 'tagsinput',
128 128
                     'data-autocomplete' => $this->urlGenerator->generate('typeahead_tags', ['query' => 'QUERY']),
129 129
                 ],
130
-                'disabled' => ! $this->security->isGranted('tags.edit', $part),
130
+                'disabled' => !$this->security->isGranted('tags.edit', $part),
131 131
             ]);
132 132
 
133 133
         //Manufacturer section
@@ -136,25 +136,25 @@  discard block
 block discarded – undo
136 136
             'required' => false,
137 137
             'label' => 'part.edit.manufacturer.label',
138 138
             'disable_not_selectable' => true,
139
-            'disabled' => ! $this->security->isGranted('manufacturer.edit', $part),
139
+            'disabled' => !$this->security->isGranted('manufacturer.edit', $part),
140 140
         ])
141 141
             ->add('manufacturer_product_url', UrlType::class, [
142 142
                 'required' => false,
143 143
                 'empty_data' => '',
144 144
                 'label' => 'part.edit.manufacturer_url.label',
145
-                'disabled' => ! $this->security->isGranted('mpn.edit', $part),
145
+                'disabled' => !$this->security->isGranted('mpn.edit', $part),
146 146
             ])
147 147
             ->add('manufacturer_product_number', TextType::class, [
148 148
                 'required' => false,
149 149
                 'empty_data' => '',
150 150
                 'label' => 'part.edit.mpn',
151
-                'disabled' => ! $this->security->isGranted('mpn.edit', $part),
151
+                'disabled' => !$this->security->isGranted('mpn.edit', $part),
152 152
             ])
153 153
             ->add('manufacturing_status', ChoiceType::class, [
154 154
                 'label' => 'part.edit.manufacturing_status',
155 155
                 'choices' => $status_choices,
156 156
                 'required' => false,
157
-                'disabled' => ! $this->security->isGranted('status.edit', $part),
157
+                'disabled' => !$this->security->isGranted('status.edit', $part),
158 158
             ]);
159 159
 
160 160
         //Advanced section
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
             ],
165 165
             'required' => false,
166 166
             'label' => 'part.edit.needs_review',
167
-            'disabled' => ! $this->security->isGranted('edit', $part),
167
+            'disabled' => !$this->security->isGranted('edit', $part),
168 168
         ])
169 169
             ->add('favorite', CheckboxType::class, [
170 170
                 'label_attr' => [
@@ -172,20 +172,20 @@  discard block
 block discarded – undo
172 172
                 ],
173 173
                 'required' => false,
174 174
                 'label' => 'part.edit.is_favorite',
175
-                'disabled' => ! $this->security->isGranted('change_favorite', $part),
175
+                'disabled' => !$this->security->isGranted('change_favorite', $part),
176 176
             ])
177 177
             ->add('mass', SIUnitType::class, [
178 178
                 'unit' => 'g',
179 179
                 'label' => 'part.edit.mass',
180 180
                 'required' => false,
181
-                'disabled' => ! $this->security->isGranted('mass.edit', $part),
181
+                'disabled' => !$this->security->isGranted('mass.edit', $part),
182 182
             ])
183 183
             ->add('partUnit', StructuralEntityType::class, [
184 184
                 'class' => MeasurementUnit::class,
185 185
                 'required' => false,
186 186
                 'disable_not_selectable' => true,
187 187
                 'label' => 'part.edit.partUnit',
188
-                'disabled' => ! $this->security->isGranted('unit.edit', $part),
188
+                'disabled' => !$this->security->isGranted('unit.edit', $part),
189 189
             ]);
190 190
 
191 191
         //Comment section
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
             'attr' => [
196 196
                 'rows' => 4,
197 197
             ],
198
-            'disabled' => ! $this->security->isGranted('comment.edit', $part),
198
+            'disabled' => !$this->security->isGranted('comment.edit', $part),
199 199
             'empty_data' => '',
200 200
         ]);
201 201
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
             'label' => false,
208 208
             'entry_options' => [
209 209
                 'measurement_unit' => $part->getPartUnit(),
210
-                'disabled' => ! $this->security->isGranted('lots.edit', $part),
210
+                'disabled' => !$this->security->isGranted('lots.edit', $part),
211 211
             ],
212 212
             'by_reference' => false,
213 213
         ]);
@@ -220,14 +220,14 @@  discard block
 block discarded – undo
220 220
             'label' => false,
221 221
             'entry_options' => [
222 222
                 'data_class' => PartAttachment::class,
223
-                'disabled' => ! $this->security->isGranted('attachments.edit', $part),
223
+                'disabled' => !$this->security->isGranted('attachments.edit', $part),
224 224
             ],
225 225
             'by_reference' => false,
226 226
         ]);
227 227
 
228 228
         $builder->add('master_picture_attachment', MasterPictureAttachmentType::class, [
229 229
             'required' => false,
230
-            'disabled' => ! $this->security->isGranted('attachments.edit', $part),
230
+            'disabled' => !$this->security->isGranted('attachments.edit', $part),
231 231
             'label' => 'part.edit.master_attachment',
232 232
             'entity' => $part,
233 233
         ]);
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
             'prototype_data' => new Orderdetail(),
243 243
             'entry_options' => [
244 244
                 'measurement_unit' => $part->getPartUnit(),
245
-                'disabled' => ! $this->security->isGranted('orderdetails.edit', $part),
245
+                'disabled' => !$this->security->isGranted('orderdetails.edit', $part),
246 246
             ],
247 247
         ]);
248 248
 
Please login to merge, or discard this patch.
src/Form/Type/MasterPictureAttachmentType.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -45,14 +45,14 @@  discard block
 block discarded – undo
45 45
             'attr' => [
46 46
                 'class' => 'selectpicker',
47 47
             ],
48
-            'choice_attr' => function (Options $options) {
49
-                return  function ($choice, $key, $value) use ($options) {
48
+            'choice_attr' => function(Options $options) {
49
+                return  function($choice, $key, $value) use ($options) {
50 50
                     /** @var Attachment $choice */
51 51
                     $tmp = ['data-subtext' => $choice->getFilename() ?? 'URL'];
52 52
 
53
-                    if ('picture' === $options['filter'] && ! $choice->isPicture()) {
53
+                    if ('picture' === $options['filter'] && !$choice->isPicture()) {
54 54
                         $tmp += ['disabled' => 'disabled'];
55
-                    } elseif ('3d_model' === $options['filter'] && ! $choice->is3DModel()) {
55
+                    } elseif ('3d_model' === $options['filter'] && !$choice->is3DModel()) {
56 56
                         $tmp += ['disabled' => 'disabled'];
57 57
                     }
58 58
 
@@ -60,13 +60,13 @@  discard block
 block discarded – undo
60 60
                 };
61 61
             },
62 62
             'choice_label' => 'name',
63
-            'class' => function (Options $options) {
63
+            'class' => function(Options $options) {
64 64
                 $short_class_name = (new ReflectionClass($options['entity']))->getShortName();
65 65
                 //Category becomes CategoryAttachment
66 66
                 return 'App\\Entity\\Attachments\\'.$short_class_name.'Attachment';
67 67
             },
68
-            'query_builder' => function (Options $options) {
69
-                return function (EntityRepository $er) use ($options) {
68
+            'query_builder' => function(Options $options) {
69
+                return function(EntityRepository $er) use ($options) {
70 70
                     $entity = $options['entity'];
71 71
                     if (null === $entity->getID()) {
72 72
                         //This query is always false, so we get empty results
Please login to merge, or discard this patch.
src/Form/Type/StructuralEntityType.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -64,9 +64,9 @@  discard block
 block discarded – undo
64 64
     public function buildForm(FormBuilderInterface $builder, array $options): void
65 65
     {
66 66
         $builder->addModelTransformer(new CallbackTransformer(
67
-            function ($value) use ($options) {
67
+            function($value) use ($options) {
68 68
                 return $this->transform($value, $options);
69
-            }, function ($value) use ($options) {
69
+            }, function($value) use ($options) {
70 70
                 return $this->reverseTransform($value, $options);
71 71
             }));
72 72
     }
@@ -76,25 +76,25 @@  discard block
 block discarded – undo
76 76
         $resolver->setRequired(['class']);
77 77
         $resolver->setDefaults([
78 78
             'show_fullpath_in_subtext' => true, //When this is enabled, the full path will be shown in subtext
79
-            'subentities_of' => null,   //Only show entities with the given parent class
80
-            'disable_not_selectable' => false,  //Disable entries with not selectable property
79
+            'subentities_of' => null, //Only show entities with the given parent class
80
+            'disable_not_selectable' => false, //Disable entries with not selectable property
81 81
             'choice_value' => 'id', //Use the element id as option value and for comparing items
82
-            'choice_loader' => function (Options $options) {
83
-                return new CallbackChoiceLoader(function () use ($options) {
82
+            'choice_loader' => function(Options $options) {
83
+                return new CallbackChoiceLoader(function() use ($options) {
84 84
                     return $this->getEntries($options);
85 85
                 });
86 86
             },
87
-            'choice_label' => function ($choice, $key, $value) {
87
+            'choice_label' => function($choice, $key, $value) {
88 88
                 return $this->generateChoiceLabels($choice, $key, $value);
89 89
             },
90
-            'choice_attr' => function ($choice, $key, $value) {
90
+            'choice_attr' => function($choice, $key, $value) {
91 91
                 return $this->generateChoiceAttr($choice, $key, $value);
92 92
             },
93 93
         ]);
94 94
 
95 95
         $resolver->setDefault('empty_message', null);
96 96
 
97
-        $resolver->setDefault('attr', function (Options $options) {
97
+        $resolver->setDefault('attr', function(Options $options) {
98 98
             $tmp = [
99 99
                 'class' => 'selectpicker',
100 100
                 'data-live-search' => true,
Please login to merge, or discard this patch.
src/Form/UserSettingsType.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -54,27 +54,27 @@  discard block
 block discarded – undo
54 54
         $builder
55 55
             ->add('name', TextType::class, [
56 56
                 'label' => 'user.username.label',
57
-                'disabled' => ! $this->security->isGranted('edit_username', $options['data']) || $this->demo_mode,
57
+                'disabled' => !$this->security->isGranted('edit_username', $options['data']) || $this->demo_mode,
58 58
             ])
59 59
             ->add('first_name', TextType::class, [
60 60
                 'required' => false,
61 61
                 'label' => 'user.firstName.label',
62
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
62
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
63 63
             ])
64 64
             ->add('last_name', TextType::class, [
65 65
                 'required' => false,
66 66
                 'label' => 'user.lastName.label',
67
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
67
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
68 68
             ])
69 69
             ->add('department', TextType::class, [
70 70
                 'required' => false,
71 71
                 'label' => 'user.department.label',
72
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
72
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
73 73
             ])
74 74
             ->add('email', EmailType::class, [
75 75
                 'required' => false,
76 76
                 'label' => 'user.email.label',
77
-                'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
77
+                'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
78 78
             ])
79 79
             ->add('language', LanguageType::class, [
80 80
                 'disabled' => $this->demo_mode,
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
                     'class' => 'selectpicker',
106 106
                 ],
107 107
                 'choices' => User::AVAILABLE_THEMES,
108
-                'choice_label' => function ($entity, $key, $value) {
108
+                'choice_label' => function($entity, $key, $value) {
109 109
                     return $value;
110 110
                 },
111 111
                 'placeholder' => 'user_settings.theme.placeholder',
Please login to merge, or discard this patch.
src/Helpers/UTCDateTimeType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
42 42
     {
43
-        if (! self::$utc_timezone) {
43
+        if (!self::$utc_timezone) {
44 44
             self::$utc_timezone = new DateTimeZone('UTC');
45 45
         }
46 46
 
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
     public function convertToPHPValue($value, AbstractPlatform $platform)
55 55
     {
56
-        if (! self::$utc_timezone) {
56
+        if (!self::$utc_timezone) {
57 57
             self::$utc_timezone = new DateTimeZone('UTC');
58 58
         }
59 59
 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             self::$utc_timezone
68 68
         );
69 69
 
70
-        if (! $converted) {
70
+        if (!$converted) {
71 71
             throw ConversionException::conversionFailedFormat($value, $this->getName(), $platform->getDateTimeFormatString());
72 72
         }
73 73
 
Please login to merge, or discard this patch.
src/DataTables/PartsDataTable.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         $dataTable
81 81
             ->add('picture', TextColumn::class, [
82 82
                 'label' => '',
83
-                'render' => function ($value, Part $context) {
83
+                'render' => function($value, Part $context) {
84 84
                     $preview_attachment = $this->previewGenerator->getTablePreviewAttachment($context);
85 85
                     if (null === $preview_attachment) {
86 86
                         return '';
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
             ])
98 98
             ->add('name', TextColumn::class, [
99 99
                 'label' => $this->translator->trans('part.table.name'),
100
-                'render' => function ($value, Part $context) {
100
+                'render' => function($value, Part $context) {
101 101
                     return sprintf(
102 102
                         '<a href="%s">%s</a>',
103 103
                         $this->urlGenerator->infoURL($context),
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
             ])
127 127
             ->add('storelocation', TextColumn::class, [
128 128
                 'label' => $this->translator->trans('part.table.storeLocations'),
129
-                'render' => function ($value, Part $context) {
129
+                'render' => function($value, Part $context) {
130 130
                     $tmp = [];
131 131
                     foreach ($context->getPartLots() as $lot) {
132 132
                         //Ignore lots without storelocation
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
             ])
146 146
             ->add('amount', TextColumn::class, [
147 147
                 'label' => $this->translator->trans('part.table.amount'),
148
-                'render' => function ($value, Part $context) {
148
+                'render' => function($value, Part $context) {
149 149
                     $amount = $context->getAmountSum();
150 150
 
151 151
                     return $this->amountFormatter->format($amount, $context->getPartUnit());
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
             ->add('minamount', TextColumn::class, [
155 155
                 'label' => $this->translator->trans('part.table.minamount'),
156 156
                 'visible' => false,
157
-                'render' => function ($value, Part $context) {
157
+                'render' => function($value, Part $context) {
158 158
                     return $this->amountFormatter->format($value, $context->getPartUnit());
159 159
                 },
160 160
             ])
@@ -218,12 +218,12 @@  discard block
 block discarded – undo
218 218
             ->addOrderBy('name')
219 219
             ->createAdapter(FetchJoinORMAdapter::class, [
220 220
                 'simple_total_query' => true,
221
-                'query' => function (QueryBuilder $builder): void {
221
+                'query' => function(QueryBuilder $builder): void {
222 222
                     $this->getQuery($builder);
223 223
                 },
224 224
                 'entity' => Part::class,
225 225
                 'criteria' => [
226
-                    function (QueryBuilder $builder) use ($options): void {
226
+                    function(QueryBuilder $builder) use ($options): void {
227 227
                         $this->buildCriteria($builder, $options);
228 228
                     },
229 229
                     new SearchCriteriaProvider(),
Please login to merge, or discard this patch.
tests/Entity/LogSystem/AbstractLogEntryTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
     public function targetTypeDataProvider(): array
60 60
     {
61 61
         return [
62
-            [1,  User::class],
62
+            [1, User::class],
63 63
             [2, Attachment::class],
64 64
             [3, AttachmentType::class],
65 65
             [4, Category::class],
Please login to merge, or discard this patch.
src/Command/SetPasswordCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -78,14 +78,14 @@
 block discarded – undo
78 78
             sprintf('You are going to change the password of %s with ID %d. Proceed?',
79 79
                 $user->getFullName(true), $user->getID()));
80 80
 
81
-        if (! $proceed) {
81
+        if (!$proceed) {
82 82
             return 1;
83 83
         }
84 84
 
85 85
         $success = false;
86 86
         $new_password = '';
87 87
 
88
-        while (! $success) {
88
+        while (!$success) {
89 89
             $pw1 = $io->askHidden('Please enter new password:');
90 90
             $pw2 = $io->askHidden('Please confirm:');
91 91
             if ($pw1 !== $pw2) {
Please login to merge, or discard this patch.
src/Command/CleanAttachmentsCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 
106 106
             $continue = $io->confirm(sprintf('Found %d abandoned files. Do you want to delete them? This can not be undone!', count($file_list)), false);
107 107
 
108
-            if (! $continue) {
108
+            if (!$continue) {
109 109
                 //We are finished here, when no files should be deleted
110 110
                 return 0;
111 111
             }
Please login to merge, or discard this patch.