for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace ParityBit\DeploymentNotifier\Clients;
class SlackClient
{
protected $webhookUrl;
protected $channels = [];
protected $iconUrl = null;
protected $username = null;
public function __construct($webhookUrl, $channels = [], $username = 'Deployment Notifier', $iconUrl = null)
$this->webhookUrl = $webhookUrl;
$this->channels = $channels;
$this->username = $username;
$this->iconUrl = $iconUrl;
}
public function sendMessage($message)
foreach ($this->channels as $channel) {
$payload = $this->getPayload($message, $channel);
$ch = curl_init();
curl_setopt($ch, \CURLOPT_URL, $this->webhookUrl);
curl_setopt($ch, \CURLOPT_POST, 1);
curl_setopt($ch, \CURLOPT_POSTFIELDS, 'payload=' .json_encode($payload));
$result = curl_exec($ch);
$result
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
curl_close($ch);
protected function getPayload($message, $channel)
$payload = [];
if (!is_null($this->iconUrl)) {
$payload['icon_url'] = $this->iconUrl;
$payload['text'] = $message;
$payload['channel'] = $channel;
$payload['username'] = $this->username;
return $payload;
ParityBitSystems /
deployment-notifier
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.