SlackClient::getPayload() - Code Metrics - ParityBitSystems/deployment-notifier - Measure and Improve Code Quality continuously with Scrutinizer

SlackClient::getPayload() A
last analyzed 2016-05-27 16:18 UTC

↳ Parent: SlackClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	2
eloc	8
nc	2
nop	2

<?php

namespace ParityBit\DeploymentNotifier\Clients;

use Curl\Curl;

class SlackClient
{
    protected $curl;
    protected $webhookUrl;
    protected $channels = [];
    protected $iconUrl = null;
    protected $username = null;

    public function __construct(Curl $curl, $webhookUrl, $channels = [], $username = 'Deployment Notifier', $iconUrl = null)
    {
        $this->curl = $curl;
        $this->webhookUrl = $webhookUrl;
        $this->channels = $channels;
        $this->username = $username;
        $this->iconUrl = $iconUrl;
    }

    public function sendMessage($message)
    {
        foreach ($this->channels as $channel) {
            $payload = $this->getPayload($message, $channel);

            $this->curl->post(
                $this->webhookUrl,
                'payload=' . json_encode($payload)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }
    }

    public function getPayload($message, $channel)
    {
        $payload = [];

        if (!is_null($this->iconUrl)) {
            $payload['icon_url'] = $this->iconUrl;
        }

        $payload['text'] = $message;
        $payload['channel'] = $channel;
        $payload['username'] = $this->username;

        return $payload;
    }
}


1			<?php
2
3			namespace ParityBit\DeploymentNotifier\Clients;
4
5			use Curl\Curl;
6
7			class SlackClient
8			{
9			protected $curl;
10			protected $webhookUrl;
11			protected $channels = [];
12			protected $iconUrl = null;
13			protected $username = null;
14
15			public function __construct(Curl $curl, $webhookUrl, $channels = [], $username = 'Deployment Notifier', $iconUrl = null)
16			{
17			$this->curl = $curl;
18			$this->webhookUrl = $webhookUrl;
19			$this->channels = $channels;
20			$this->username = $username;
21			$this->iconUrl = $iconUrl;
22			}
23
24			public function sendMessage($message)
25			{
26			foreach ($this->channels as $channel) {
27			$payload = $this->getPayload($message, $channel);
28
29			$this->curl->post(
30			$this->webhookUrl,
31			'payload=' . json_encode($payload)
			0 ignored issues – show Documentation introduced 2016-05-24 22:18 UTC by Report Bug Copy Issue Report `'payload=' . json_encode($payload)` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			);
33			}
34			}
35
36			public function getPayload($message, $channel)
37			{
38			$payload = [];
39
40			if (!is_null($this->iconUrl)) {
41			$payload['icon_url'] = $this->iconUrl;
42			}
43
44			$payload['text'] = $message;
45			$payload['channel'] = $channel;
46			$payload['username'] = $this->username;
47
48			return $payload;
49			}
50			}
51

ParityBitSystems / deployment-notifier

SlackClient::getPayload() A last analyzed 2016-05-27 16:18 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SlackClient::getPayload() A
last analyzed 2016-05-27 16:18 UTC