for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace ParityBit\DeploymentNotifier\Clients;
use Curl\Curl;
class NewRelicClient
{
protected $curl;
protected $appName;
const NOTIFICATION_URL = 'https://api.newrelic.com/deployments.xml';
public function __construct(Curl $curl, $apiKey, $appName)
$this->curl = $curl;
$this->curl->setHeader('x-api-key', $apiKey);
$this->appName = $appName;
}
public function logDeployment()
// SHOULDDO: Use API v2
$this->curl->post(
self::NOTIFICATION_URL,
'deployment[app_name]=' . $this->appName
string
array
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example:
function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x);
);
ParityBitSystems /
deployment-notifier
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: