Coordinates::setLongitudeIsValid() - Code Metrics - Inspection of "Add test coverage analysis with scrutinizer." - PanovAlexey/geo-coordinates - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 953efc...1c2901 )

by Alexey

created 2020-10-01 07:54 UTC

Coordinates::setLongitudeIsValid() A

↳ Parent: Coordinates

Complexity

Conditions	5
Paths	4

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	5.3906

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	7
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	15
ccs	6
cts	8
cp	0.75
crap	5.3906
rs	9.6111

<?php

declare(strict_types=1);

namespace CodeblogPro\GeoCoordinates;

use CodeblogPro\GeoCoordinates\Exceptions\InvalidArgumentException;

class Coordinates implements CoordinatesInterface
{
    private float $latitude;
    private float $longitude;

    public function __construct($latitude, $longitude)
    {
        $this->setLatitudeIsValid($latitude);
        $this->setLongitudeIsValid($longitude);
    }

    public function getLatitude(): float
    {
        return $this->latitude;
    }

    public function getLongitude(): float
    {
        return $this->longitude;
    }

    public function toArray(): array
    {
        return [$this->getLongitude(), $this->getLatitude()];
    }

    public function toString(): string
    {
        return $this->getLongitude() . ', ' . $this->getLatitude();
    }

    private function setLatitudeIsValid($latitude): void
    {
        $isValid = true;

        if (!is_numeric($latitude)) {
            $isValid = false;
        }

        $latitude = (float)$latitude;

        if (!$isValid || $latitude < -90 || $latitude > 90) {
            throw new InvalidArgumentException('Invalid latitude. It must be a number between -90 and 90');
        }

        $this->latitude = $latitude;
    }

    private function setLongitudeIsValid($longitude): void
    {
        $isValid = true;

        if (!is_numeric($longitude)) {
            $isValid = false;
        }

        $longitude = (float)$longitude;

        if (!$isValid || $longitude < -180 || $longitude > 180) {
            throw new InvalidArgumentException('Invalid longitude. It must be a number between -90 and 90');
        }

        $this->longitude = $longitude;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace CodeblogPro\GeoCoordinates;
6
7		use CodeblogPro\GeoCoordinates\Exceptions\InvalidArgumentException;
8
9		class Coordinates implements CoordinatesInterface
10		{
11		private float $latitude;
12		private float $longitude;
13
14	5	public function __construct($latitude, $longitude)
15		{
16	5	$this->setLatitudeIsValid($latitude);
17	3	$this->setLongitudeIsValid($longitude);
18	3	}
19
20		public function getLatitude(): float
21		{
22		return $this->latitude;
23		}
24
25		public function getLongitude(): float
26		{
27		return $this->longitude;
28		}
29
30		public function toArray(): array
31		{
32		return [$this->getLongitude(), $this->getLatitude()];
33		}
34
35		public function toString(): string
36		{
37		return $this->getLongitude() . ', ' . $this->getLatitude();
38		}
39
40	5	private function setLatitudeIsValid($latitude): void
41		{
42	5	$isValid = true;
43
44	5	if (!is_numeric($latitude)) {
45		$isValid = false;
46		}
47
48	5	$latitude = (float)$latitude;
49
50	5	if (!$isValid \|\| $latitude < -90 \|\| $latitude > 90) {
51	2	throw new InvalidArgumentException('Invalid latitude. It must be a number between -90 and 90');
52		}
53
54	3	$this->latitude = $latitude;
55	3	}
56
57	3	private function setLongitudeIsValid($longitude): void
58		{
59	3	$isValid = true;
60
61	3	if (!is_numeric($longitude)) {
62		$isValid = false;
63		}
64
65	3	$longitude = (float)$longitude;
66
67	3	if (!$isValid \|\| $longitude < -180 \|\| $longitude > 180) {
68		throw new InvalidArgumentException('Invalid longitude. It must be a number between -90 and 90');
69		}
70
71	3	$this->longitude = $longitude;
72	3	}
73		}
74

PanovAlexey / geo-coordinates

Push — master ( 953efc...1c2901 )

Coordinates::setLongitudeIsValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like