DalliSDK\Requests\Act\BaseActRequest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setBarcodes()	0	4	1
A	getBarcodes()	0	3	1
A	__construct()	0	3	1
A	addBarcode()	0	10	3

<?php

declare(strict_types=1);

namespace DalliSDK\Requests\Act;

use DalliSDK\Requests\AbstractRequest;
use DalliSDK\Requests\RequestInterface;
use JMS\Serializer\Annotation as JMS;

/**
 * Запрос файла акта приема-передачи
 *
 * @see https://api.dalli-service.com/v1/doc/getact
 */
class BaseActRequest extends AbstractRequest implements RequestInterface
{
    /**
     * Контейнер, который содержит штрих-коды заказов.
     * По-умолчанию все переданные заказы за сегодня (не обязательный элемент)
     *
     * @JMS\XmlList(inline = false, entry = "barcode")
     */
    private ?array $barcodes = null;

    /**
     * @param array|null $barcodes
     */
    public function __construct(?array $barcodes = null)
    {
        $this->barcodes = $barcodes;
    }

    /**
     * @return array|null
     */
    public function getBarcodes(): ?array
    {
        return $this->barcodes;
    }

    /**
     * Штрих-коды. Если указан хотя бы один - в файле акта будут только эти заказы
     *
     * @param array|null $barcodes
     *
     * @return BaseActRequest
     */
    public function setBarcodes(?array $barcodes): BaseActRequest
    {
        $this->barcodes = $barcodes;
        return $this;
    }

    /**
     * @param string $barcode
     *
     * @return $this
     */
    public function addBarcode(string $barcode): BaseActRequest
    {
        if ($this->barcodes === null) {
            $this->barcodes = [];
        }
        if (in_array($barcode, $this->barcodes)) {

It seems like $this->barcodes can also be of type null; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

            throw new \InvalidArgumentException("Barcode: $barcode already exists.");
        }
        $this->barcodes[] = $barcode;
        return $this;
    }
}