PagaMasTarde / pmtApiClient

src/PagaMasTarde/Service/ChargeService.php

<?php

namespace PagaMasTarde\Service;

use Httpful\Http;
use Httpful\Mime;
use PagaMasTarde\Model\Charge;
use PagaMasTarde\Model\Refund;

/**
 * Class ChargeService
 * @package PagaMasTarde\Service
 */
class ChargeService extends AbstractService
{
    /**
     * Charges endpoint
     */
    const CHARGES_ENDPOINT = '/api/1/charges';

    /**
     * URI Separator
     */
    const SLASH = '/';

    /**
     * Refunds Endpoint
     */
    const REFUNDS_ENDPOINT = '/refunds';

    /**
     * @param int $page
     *
     * @return Charge[]
     */
    public function getCharges($page = null)
    {
        $response = $this->getRequest()
            ->method(Http::GET)
            ->uri($this->baseUri . self::CHARGES_ENDPOINT . $this->addGetParameters(array(
                'page' => $page,
                )))
            ->send()
        ;

        if ($response->hasErrors()) {
            return array();
        }

        foreach ($response->body->response as $charge) {
                $charges[] = new Charge($charge);
        }

        return isset($charges) ? $charges : array();

The variable $charges seems to be defined by a foreach iteration on line 50. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    /**
     * @param string $orderId
     *
     * @return Charge[]
     */
    public function getChargesByOrderId($orderId)
    {
        $response = $this->getRequest()
            ->method(Http::GET)
            ->uri($this->baseUri . self::CHARGES_ENDPOINT . $this->addGetParameters(array(
                    'order_id' => $orderId,
                )))
            ->send()
        ;

        if ($response->hasErrors()) {
            return array();
        }

        foreach ($response->body->response as $charge) {
            $charges[] = new Charge($charge);
        }

        return isset($charges) ? $charges : array();

The variable $charges seems to be defined by a foreach iteration on line 76. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    /**
     * @param string $orderId
     *
     * @return bool
     */
    public function validatePaymentForOrderId($orderId)
    {
        $charges = $this->getChargesByOrderId($orderId);

        if (!empty($charges)) {
            foreach ($charges as $charge) {
                if ($charge->getPaid() === true && $charge->getStatus() == 'paid') {
                    return true;
                }
            }
        }

        return false;
    }

    /**
     * @param string $id
     *
     * @return Charge | null
     */
    public function getChargeById($id)
    {
        $response = $this->getRequest()
            ->method(Http::GET)
            ->uri($this->baseUri . self::CHARGES_ENDPOINT . '/' . $id)
            ->send()
        ;

        if ($response->hasErrors() || !$response->hasBody() || empty($response->body->response)) {
            return null;
        }

        return new Charge($response->body->response);
    }

    /**
     * @param Charge $charge
     *
     * @return null|Refund
     */
    public function refundCharge(Charge $charge)
    {
        $response = $this->getRequest()
             ->method(Http::POST)
             ->uri(
                 $this->baseUri .
                 self::CHARGES_ENDPOINT .
                 self::SLASH .
                 $charge->getId() .
                 self::REFUNDS_ENDPOINT
             )
             ->body(array(
                 'refund[amount]' => $charge->getAmount()
             ), Mime::FORM)
            ->expects(Mime::JSON)
            ->send()
        ;

        if ($response->hasErrors() || !$response->hasBody() || empty($response->body->response)) {
            return null;
        }

        return new Refund($response->body->response);
    }

    /**
     * @param Charge $charge
     * @param int    $amount
     *
     * @return null|Refund
     */
    public function refundChargePartial(Charge $charge, $amount)
    {
        $response = $this->getRequest()
             ->method(Http::POST)
             ->uri(
                 $this->baseUri .
                 self::CHARGES_ENDPOINT .
                 self::SLASH .
                 $charge->getId() .
                 self::REFUNDS_ENDPOINT
             )
             ->body(array(
                 'refund[amount]' => $amount
             ), Mime::FORM)
             ->expects(Mime::JSON)
             ->send()
        ;

        if ($response->hasErrors() || !$response->hasBody() || empty($response->body->response)) {
            return null;
        }

        return new Refund($response->body->response);
    }
}