LongPollingUtilsTest::getEvolvingPersonRepo() - Code Metrics - Inspection of "Merge remote-tracking branch 'upstream/master' int..." - PROCERGS/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 22f213...24f6ce )

by Guilherme

created 2017-10-04 18:58 UTC

LongPollingUtilsTest::getEvolvingPersonRepo() A

↳ Parent: LongPollingUtilsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	2
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\CoreBundle\Tests\LongPolling;

use Doctrine\ORM\EntityManagerInterface;
use LoginCidadao\CoreBundle\Entity\PersonRepository;
use LoginCidadao\CoreBundle\LongPolling\LongPollingUtils;
use LoginCidadao\CoreBundle\Model\PersonInterface;
use Symfony\Component\Stopwatch\Stopwatch;

/**
 * @group time-sensitive
 */
class LongPollingUtilsTest extends \PHPUnit_Framework_TestCase
{
    public function testRunTimeLimited()
    {
        $timer = 'timeLimited';
        $stopwatch = new Stopwatch();
        $stopwatch->start($timer);

        $longPolling = new LongPollingUtils($this->getEntityManager(), 60);


        $count = 5;
        $response = $longPolling->runTimeLimited(function () use (&$count) {
            return --$count <= 0;
        });
        $duration = $stopwatch->stop($timer)->getDuration();

        $this->assertTrue($response);
        $this->assertEquals(0, $count);
        $this->assertLessThan(60, $duration);
    }

    public function testTimeout()
    {
        $this->setExpectedException('LoginCidadao\APIBundle\Exception\RequestTimeoutException');

        $longPolling = new LongPollingUtils($this->getEntityManager(), 30);

        $longPolling->runTimeLimited(function () {
            return false;
        });
    }

    public function testEntityUpdateCheckerCallback()
    {
        $updatedAt = new \DateTime('-1 hour');
        $currentUpdatedAt = new \DateTime('-1 hour');

        $person = $this->getPerson();
        $person->expects($this->any())->method('getUpdatedAt')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->willReturnCallback(function () use (&$currentUpdatedAt) {
                return $currentUpdatedAt;
            });

        $em = $this->getEntityManager();
        $em->expects($this->once())->method('getRepository')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->willReturn($this->getEvolvingPersonRepo($person, $currentUpdatedAt));

        $longPolling = new LongPollingUtils($em);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $callback = $longPolling->getEntityUpdateCheckerCallback($person, $updatedAt);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        call_user_func($callback);
        $response = call_user_func($callback);

        $this->assertNotFalse($response);
        $this->assertNotEquals($updatedAt, $currentUpdatedAt);
        $this->assertEquals($person, $response);
    }

    public function testEntityUpdateCheckerCallbackNeverUpdated()
    {
        $person = $this->getPerson();
        $person->expects($this->once())->method('getUpdatedAt')->willReturn(null);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $repo = $this->getPersonRepository();
        $repo->expects($this->any())->method('find')->willReturn($person);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $em = $this->getEntityManager();
        $em->expects($this->once())->method('getRepository')->willReturn($repo);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $longPolling = new LongPollingUtils($em);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $callback = $longPolling->getEntityUpdateCheckerCallback($person, new \DateTime());
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $response = call_user_func($callback);

        $this->assertFalse($response);
    }

    public function testObviouslyValidEmail()
    {
        $person = $this->getPerson();
        $person->expects($this->once())->method('getEmailConfirmedAt')->willReturn(new \DateTime());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $longPolling = new LongPollingUtils($this->getEntityManager());

        $response = $longPolling->waitValidEmail($person, new \DateTime());
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->assertTrue($response);
    }

    public function testWaitValidEmail()
    {
        $updatedAt = new \DateTime('-1 hour');
        $currentUpdatedAt = new \DateTime('-1 hour');

        $person = $this->getPerson();
        $person->expects($this->any())->method('getUpdatedAt')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->willReturnCallback(function () use (&$currentUpdatedAt) {
                return $currentUpdatedAt;
            });

        $repo = $this->getEvolvingPersonRepo($person, $currentUpdatedAt);

        $em = $this->getEntityManager();
        $em->expects($this->once())->method('getRepository')->willReturn($repo);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $longPolling = new LongPollingUtils($em);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $response = $longPolling->waitValidEmail($person, $updatedAt);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->assertTrue($response);
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|EntityManagerInterface
     */
    private function getEntityManager()
    {
        $em = $this->getMock('Doctrine\ORM\EntityManagerInterface');

        return $em;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|PersonRepository
     */
    private function getPersonRepository()
    {
        $repo = $this->getMockBuilder('LoginCidadao\CoreBundle\Entity\PersonRepository')
            ->disableOriginalConstructor()->getMock();

        return $repo;
    }

    /**
     * @return PersonInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getPerson()
    {
        /** @var \PHPUnit_Framework_MockObject_MockObject|PersonInterface $person */
        $person = $this->getMock('LoginCidadao\CoreBundle\Model\PersonInterface');
        $person->expects($this->any())->method('getId')->willReturn(123);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $person;
    }

    /**
     * @param PersonInterface|\PHPUnit_Framework_MockObject_MockObject $person
     * @param \DateTime|null $currentUpdatedAt
     * @return PersonRepository|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getEvolvingPersonRepo(&$person, &$currentUpdatedAt)
    {
        $repo = $this->getPersonRepository();
        $repo->expects($this->at(0))->method('find')->willReturn($person);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $repo->expects($this->at(1))->method('find')
            ->willReturnCallback(function () use (&$person, &$currentUpdatedAt) {
                $currentUpdatedAt = new \DateTime();
                $person->expects($this->any())->method('getEmailConfirmedAt')->willReturn($currentUpdatedAt);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

                return $person;
            });

        return $repo;
    }
}


Push — master ( 22f213...24f6ce )

LongPollingUtilsTest::getEvolvingPersonRepo() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* This file is part of the login-cidadao project or it's bundles.
4			*
5			* (c) Guilherme Donato <guilhermednt on github>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace LoginCidadao\CoreBundle\Tests\LongPolling;
12
13			use Doctrine\ORM\EntityManagerInterface;
14			use LoginCidadao\CoreBundle\Entity\PersonRepository;
15			use LoginCidadao\CoreBundle\LongPolling\LongPollingUtils;
16			use LoginCidadao\CoreBundle\Model\PersonInterface;
17			use Symfony\Component\Stopwatch\Stopwatch;
18
19			/**
20			* @group time-sensitive
21			*/
22			class LongPollingUtilsTest extends \PHPUnit_Framework_TestCase
23			{
24			public function testRunTimeLimited()
25			{
26			$timer = 'timeLimited';
27			$stopwatch = new Stopwatch();
28			$stopwatch->start($timer);
29
30			$longPolling = new LongPollingUtils($this->getEntityManager(), 60);
			0 ignored issues – show Bug introduced 2017-10-04 19:15 UTC by Report Bug Copy Issue Report It seems like `$this->getEntityManager()` targeting `LoginCidadao\CoreBundle\...est::getEntityManager()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `LoginCidadao\CoreBundle\...ingUtils::__construct()` does only seem to accept `object<Doctrine\ORM\EntityManagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
31
32			$count = 5;
33			$response = $longPolling->runTimeLimited(function () use (&$count) {
34			return --$count <= 0;
35			});
36			$duration = $stopwatch->stop($timer)->getDuration();
37
38			$this->assertTrue($response);
39			$this->assertEquals(0, $count);

PROCERGS / login-cidadao

Push — master ( 22f213...24f6ce )

LongPollingUtilsTest::getEvolvingPersonRepo() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like