TwoFactorAuthenticationController::enable2FA() - Code Metrics - Inspection of "Merge remote-tracking branch 'upstream/master' int..." - PROCERGS/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 22f213...24f6ce )

by Guilherme

created 2017-10-04 18:58 UTC

TwoFactorAuthenticationController::enable2FA() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	2
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\CoreBundle\Controller;

use LoginCidadao\CoreBundle\Security\TwoFactorAuthenticationService;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use LoginCidadao\CoreBundle\Form\Type\TwoFactorAuthenticationFormType;
use LoginCidadao\CoreBundle\Form\Type\TwoFactorAuthenticationDisableFormType;
use LoginCidadao\CoreBundle\Form\Type\TwoFactorAuthenticationBackupCodeGenerationFormType;
use Symfony\Component\Form\FormError;

/**
 * @Route("/two-factor")
 */
class TwoFactorAuthenticationController extends Controller
{

    /**
     * @Route("/enable", name="2fa_enable")
     * @Template()
     */
    public function enableAction(Request $request)
    {
        /** @var TwoFactorAuthenticationService $twoFactor */
        $twoFactor = $this->get('lc.two_factor');

        $translator = $this->get('translator');
        $person = $this->getUser();
        $person->setGoogleAuthenticatorSecret($twoFactor->generateSecret());

        $form = $this->createForm(new TwoFactorAuthenticationFormType(), $person);
        $form->handleRequest($request);

        if ($form->isValid()) {
            $verificationCode = $form->get('verification')->getData();

            try {
                $twoFactor->enable($form->getData(), $verificationCode);

                $message = $translator->trans('Two-Factor Authentication enabled.');
                $this->get('session')->getFlashBag()->add('success', $message);

                return $this->redirect($this->generateUrl("fos_user_change_password"));
            } catch (\InvalidArgumentException $e) {
                $message = $translator->trans($e->getMessage());
                $form->get('verification')->addError(new FormError($message));
            }
        }

        return ['form' => $form->createView(), 'secretUrl' => $twoFactor->getSecretUrl($person)];
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @Route("/disable", name="2fa_disable")
     * @Template()
     */
    public function disableAction(Request $request)
    {
        /** @var TwoFactorAuthenticationService $twoFactor */
        $twoFactor = $this->get('lc.two_factor');

        $person = $this->getUser();
        $form = $this->createForm(new TwoFactorAuthenticationDisableFormType(), $person);
        $form->handleRequest($request);

        if ($form->isValid()) {
            $translator = $this->get('translator');
            $twoFactor->disable($person);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $message = $translator->trans('Two-Factor Authentication disabled.');
            $this->get('session')->getFlashBag()->add('success', $message);

            return $this->redirect($this->generateUrl("fos_user_change_password"));
        }

        return ['form' => $form->createView()];
    }

    /**
     * @Route("/backup-codes/generate", name="2fa_backup_codes_generate")
     * @Template()
     */
    public function generateBackupCodesAction(Request $request)
    {
        /** @var TwoFactorAuthenticationService $twoFactor */
        $twoFactor = $this->get('lc.two_factor');

        $person = $this->getUser();
        $form = $this->createForm(new TwoFactorAuthenticationBackupCodeGenerationFormType(), $person);
        $form->handleRequest($request);

        if ($form->isValid()) {
            $twoFactor->removeBackupCodes($person);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $twoFactor->generateBackupCodes($person);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $message = $this->get('translator')
                ->trans('New Backup Codes generated. Don\'t forget to copy and store them safely.');
            $this->get('session')->getFlashBag()->add('success', $message);

            return $this->redirect($this->generateUrl("fos_user_change_password"));
        }

        return ['form' => $form->createView()];
    }

    /**
     * @Route("/teste")
     * @Template()
     */
    public function formAction()
    {
        return [];
    }
}


1			<?php
2			/**
3			* This file is part of the login-cidadao project or it's bundles.
4			*
5			* (c) Guilherme Donato <guilhermednt on github>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace LoginCidadao\CoreBundle\Controller;
12
13			use LoginCidadao\CoreBundle\Security\TwoFactorAuthenticationService;
14			use Symfony\Component\HttpFoundation\Request;
15			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
16			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
17			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
18			use LoginCidadao\CoreBundle\Form\Type\TwoFactorAuthenticationFormType;
19			use LoginCidadao\CoreBundle\Form\Type\TwoFactorAuthenticationDisableFormType;
20			use LoginCidadao\CoreBundle\Form\Type\TwoFactorAuthenticationBackupCodeGenerationFormType;
21			use Symfony\Component\Form\FormError;
22
23			/**
24			* @Route("/two-factor")
25			*/
26			class TwoFactorAuthenticationController extends Controller
27			{
28
29			/**
30			* @Route("/enable", name="2fa_enable")
31			* @Template()
32			*/
33			public function enableAction(Request $request)
34			{
35			/** @var TwoFactorAuthenticationService $twoFactor */
36			$twoFactor = $this->get('lc.two_factor');
37
38			$translator = $this->get('translator');
39			$person = $this->getUser();
40			$person->setGoogleAuthenticatorSecret($twoFactor->generateSecret());
41
42			$form = $this->createForm(new TwoFactorAuthenticationFormType(), $person);
43			$form->handleRequest($request);
44
45			if ($form->isValid()) {
46			$verificationCode = $form->get('verification')->getData();
47
48			try {
49			$twoFactor->enable($form->getData(), $verificationCode);
50
51			$message = $translator->trans('Two-Factor Authentication enabled.');
52			$this->get('session')->getFlashBag()->add('success', $message);
53
54			return $this->redirect($this->generateUrl("fos_user_change_password"));
55			} catch (\InvalidArgumentException $e) {
56			$message = $translator->trans($e->getMessage());
57			$form->get('verification')->addError(new FormError($message));
58			}
59			}
60
61			return ['form' => $form->createView(), 'secretUrl' => $twoFactor->getSecretUrl($person)];
			0 ignored issues – show Documentation introduced 2017-10-04 19:15 UTC by Report Bug Copy Issue Report `$person` is of type `null\|object`, but the function expects a `object<LoginCidadao\Core...\Model\PersonInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62			}
63
64			/**
65			* @Route("/disable", name="2fa_disable")
66			* @Template()
67			*/
68			public function disableAction(Request $request)
69			{
70			/** @var TwoFactorAuthenticationService $twoFactor */
71			$twoFactor = $this->get('lc.two_factor');
72
73			$person = $this->getUser();
74			$form = $this->createForm(new TwoFactorAuthenticationDisableFormType(), $person);
75			$form->handleRequest($request);
76
77			if ($form->isValid()) {
78			$translator = $this->get('translator');
79			$twoFactor->disable($person);
			0 ignored issues – show Documentation introduced 2017-10-04 19:15 UTC by Report Bug Copy Issue Report `$person` is of type `null\|object`, but the function expects a `object<LoginCidadao\Core...\Model\PersonInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80			$message = $translator->trans('Two-Factor Authentication disabled.');
81			$this->get('session')->getFlashBag()->add('success', $message);
82
83			return $this->redirect($this->generateUrl("fos_user_change_password"));
84			}
85
86			return ['form' => $form->createView()];
87			}
88
89			/**
90			* @Route("/backup-codes/generate", name="2fa_backup_codes_generate")
91			* @Template()
92			*/
93			public function generateBackupCodesAction(Request $request)
94			{
95			/** @var TwoFactorAuthenticationService $twoFactor */
96			$twoFactor = $this->get('lc.two_factor');
97
98			$person = $this->getUser();
99			$form = $this->createForm(new TwoFactorAuthenticationBackupCodeGenerationFormType(), $person);
100			$form->handleRequest($request);
101
102			if ($form->isValid()) {
103			$twoFactor->removeBackupCodes($person);
			0 ignored issues – show Documentation introduced 2017-10-04 19:15 UTC by Report Bug Copy Issue Report `$person` is of type `null\|object`, but the function expects a `object<LoginCidadao\Core...\Model\PersonInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
104			$twoFactor->generateBackupCodes($person);
			0 ignored issues – show Documentation introduced 2017-10-04 19:15 UTC by Report Bug Copy Issue Report `$person` is of type `null\|object`, but the function expects a `object<LoginCidadao\Core...\Model\PersonInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
105
106			$message = $this->get('translator')
107			->trans('New Backup Codes generated. Don\'t forget to copy and store them safely.');
108			$this->get('session')->getFlashBag()->add('success', $message);
109
110			return $this->redirect($this->generateUrl("fos_user_change_password"));
111			}
112
113			return ['form' => $form->createView()];
114			}
115
116			/**
117			* @Route("/teste")
118			* @Template()
119			*/
120			public function formAction()
121			{
122			return [];
123			}
124			}
125

PROCERGS / login-cidadao

Push — master ( 22f213...24f6ce )

TwoFactorAuthenticationController::enable2FA() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like