LoginCidadao\APIBundle\Tests\Service\VersionServiceTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

10 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetNonExistentVersion()	0	7	1
A	getVersionService()	0	3	1
A	getRequestStack()	0	14	1
A	getSupportedVersions()	0	13	1
A	testGetLatestVersionPartials()	0	16	1
A	testGetLatestVersionWithInvalidInput()	0	7	1
A	testGetLatestVersion()	0	9	1
A	testGetString()	0	7	1
A	getExpectedVersion()	0	6	1
A	testGetVersionFromRequest()	0	10	1

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\APIBundle\Tests\Service;

use LoginCidadao\APIBundle\Service\VersionService;
use Symfony\Component\HttpFoundation\ParameterBag;
use Symfony\Component\HttpFoundation\RequestStack;

class VersionServiceTest extends \PHPUnit_Framework_TestCase
{
    private function getSupportedVersions()
    {
        return [
            '1' => [
                '0' => ['0', '1', '2', '9'],
                '1' => ['0', '10'],
            ],
            '2' => [
                '0' => ['0', '1', '37'],
                '3' => ['20', '3', '0'],
            ],
            '3' => [
                '0' => ['0', '1', '5'],
            ],
        ];
    }

    private function getExpectedVersion($major, $minor, $patch)
    {
        return [
            'major' => $major,
            'minor' => $minor,
            'patch' => $patch,
        ];
    }

    /**
     * @param mixed $version
     * @return \PHPUnit_Framework_MockObject_MockObject|RequestStack
     */
    private function getRequestStack($version = null)
    {
        $request = $this->getMock('Symfony\Component\HttpFoundation\Request');

        $attributes = $this->getMock('Symfony\Component\HttpFoundation\ParameterBag');
        $attributes->expects($this->any())
            ->method('get')->with('version')
            ->willReturn($version);
        $request->attributes = $attributes;

Accessing attributes on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $requestStack = $this->getMock('Symfony\Component\HttpFoundation\RequestStack');
        $requestStack->expects($this->any())->method('getCurrentRequest')->willReturn($request);

        return $requestStack;
    }

    private function getVersionService($version = null)
    {
        return new VersionService($this->getRequestStack($version), $this->getSupportedVersions());
    }

    public function testGetLatestVersion()
    {
        $expected = $this->getExpectedVersion(3, 0, 5);

        /** @var RequestStack $requestStack */
        $requestStack = $this->getMock('Symfony\Component\HttpFoundation\RequestStack');

        $versionService = new VersionService($requestStack, $this->getSupportedVersions());
        $this->assertEquals($expected, $versionService->getLatestVersion());
    }

    public function testGetLatestVersionPartials()
    {
        /** @var RequestStack $requestStack */
        $requestStack = $this->getMock('Symfony\Component\HttpFoundation\RequestStack');

        $versionService = new VersionService($requestStack, $this->getSupportedVersions());

        $this->assertEquals(
            $this->getExpectedVersion(2, 3, 20),
            $versionService->getLatestVersion(2),
            'Expected 2.3.20'
        );
        $this->assertEquals(
            $this->getExpectedVersion(1, 1, 10),
            $versionService->getLatestVersion(1, 1),
            'Expected 1.1.10'
        );
    }

    public function testGetNonExistentVersion()
    {
        $this->setExpectedException('\InvalidArgumentException');

        $versionService = $this->getVersionService();

        $versionService->getLatestVersion(150);
    }

    public function testGetLatestVersionWithInvalidInput()
    {
        $this->setExpectedException('\InvalidArgumentException');

        $versionService = $this->getVersionService();

        $versionService->getLatestVersion('a');

'a' of type string is incompatible with the type null|integer expected by parameter $major of LoginCidadao\APIBundle\Service\VersionService::getLatestVersion().

    }

    public function testGetVersionFromRequest()
    {
        $versionService = $this->getVersionService('2');
        $this->assertEquals($this->getExpectedVersion(2, 3, 20), $versionService->getVersionFromRequest());

        $versionService = $this->getVersionService('2.0');
        $this->assertEquals($this->getExpectedVersion(2, 0, 37), $versionService->getVersionFromRequest());

        $versionService = $this->getVersionService('2.0.37');
        $this->assertEquals($this->getExpectedVersion(2, 0, 37), $versionService->getVersionFromRequest());
    }

    public function testGetString()
    {
        $versionService = $this->getVersionService();

        $this->assertEquals('1.0.0', $versionService->getString($this->getExpectedVersion(1, 0, 0)));
        $this->assertEquals('1.0', $versionService->getString([1, 0]));
        $this->assertEquals('4.9999999.8', $versionService->getString([4, 9999999, 8]));
    }
}