ClientManager::getClientById() - Code Metrics - Inspection of "added missing indexes PROCERGS#763" - PROCERGS/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — issue#763 ( 4f5bf6 )

by Guilherme

created 2018-03-15 13:18 UTC

ClientManager::getClientById() A

↳ Parent: ClientManager

Complexity

Conditions	3
Paths	4

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	15
nc	4
nop	1
dl	0
loc	23
ccs	15
cts	15
cp	1
crap	3
rs	9.0856
c	0
b	0
f	0

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\OpenIDBundle\Manager;

use Doctrine\ORM\EntityManagerInterface;
use LoginCidadao\CoreBundle\Event\GetClientEvent;
use LoginCidadao\CoreBundle\Event\LoginCidadaoCoreEvents;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

class ClientManager
{
    /** @var EventDispatcherInterface */
    protected $dispatcher;

    /** @var EntityManagerInterface */
    private $em;

    public function __construct(
        EntityManagerInterface $em,
        EventDispatcherInterface $dispatcher
    ) {
        $this->em = $em;
        $this->dispatcher = $dispatcher;
    }

    public function getClientById($id)
    {
        $randomId = null;
        if (strstr($id, '_') !== false) {
            $parts = explode('_', $id);
            $id = $parts[0];
            $randomId = $parts[1];
        }

        $repo = $this->em->getRepository('LoginCidadaoOAuthBundle:Client');

        if ($randomId) {
            $client = $repo->findOneBy([
                'id' => $id,
                'randomId' => $randomId,
            ]);
        } else {
            $client = $repo->find($id);
        }
        $event = new GetClientEvent($client);
        $this->dispatcher->dispatch(LoginCidadaoCoreEvents::GET_CLIENT, $event);

        return $event->getClient();
    }
}


1		<?php
2		/**
3		* This file is part of the login-cidadao project or it's bundles.
4		*
5		* (c) Guilherme Donato <guilhermednt on github>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace LoginCidadao\OpenIDBundle\Manager;
12
13		use Doctrine\ORM\EntityManagerInterface;
14		use LoginCidadao\CoreBundle\Event\GetClientEvent;
15		use LoginCidadao\CoreBundle\Event\LoginCidadaoCoreEvents;
16		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
17
18		class ClientManager
19		{
20		/** @var EventDispatcherInterface */
21		protected $dispatcher;
22
23		/** @var EntityManagerInterface */
24		private $em;
25
26	2	public function __construct(
27		EntityManagerInterface $em,
28		EventDispatcherInterface $dispatcher
29		) {
30	2	$this->em = $em;
31	2	$this->dispatcher = $dispatcher;
32	2	}
33
34	2	public function getClientById($id)
35		{
36	2	$randomId = null;
37	2	if (strstr($id, '_') !== false) {
38	1	$parts = explode('_', $id);
39	1	$id = $parts[0];
40	1	$randomId = $parts[1];
41		}
42
43	2	$repo = $this->em->getRepository('LoginCidadaoOAuthBundle:Client');
44
45	2	if ($randomId) {
46	1	$client = $repo->findOneBy([
47	1	'id' => $id,
48	1	'randomId' => $randomId,
49		]);
50		} else {
51	1	$client = $repo->find($id);
52		}
53	2	$event = new GetClientEvent($client);
54	2	$this->dispatcher->dispatch(LoginCidadaoCoreEvents::GET_CLIENT, $event);
55
56	2	return $event->getClient();
57		}
58		}
59

PROCERGS / login-cidadao

Push — issue#763 ( 4f5bf6 )

ClientManager::getClientById() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like