Zip_Manager

Complexity

Total Complexity

12

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	matchFileToFilter()	0	15	5
A	createDir()	0	5	3
A	filteredExtractTo()	0	20	4

<?php
class Zip_Manager extends \ZipArchive

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

This class is not in CamelCase format.

{

    const CHMOD = 0755;

    public function filteredExtractTo($directory, array $filters = null)
    {
        if (count($filters) === 0) {
            return $this->extractTo($directory);
        }

        $this->createDir($directory);

        $copySource = 'zip://'.$this->filename.'#';
        for ($i = 0; $i < $this->numFiles; $i++) {
            $entry = $this->getNameIndex($i);
            $filename = basename($entry);

            if ($this->matchFileToFilter($filename, $filters)) {

It seems like $filters can also be of type null; however, parameter $filters of Zip_Manager::matchFileToFilter() does only seem to accept array, maybe add an additional type check?

                $base = dirname($entry);
                $newPath = $directory.DIRECTORY_SEPARATOR.$base.DIRECTORY_SEPARATOR;
                $this->createDir($newPath);

                // extract file
                copy($copySource.$entry, $newPath.$filename);
            }
        }
    }

    protected function createDir($path)
    {
        if (!is_dir($path)) {
            if (!mkdir($path, self::CHMOD, true)) {
                throw new Exception('unable to create path '.$path);
            }
        }
    }

    protected function matchFileToFilter($filename, array $filters)
    {
        $ext = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
        if (in_array($ext, array_map('strtolower', $filters))) {

Blank line found at start of control structure

            return true;
        }

        foreach ($filters as $i => $filter) {

Blank line found at start of control structure

            if (!ctype_alnum($filter[0]) && preg_match($filter, $filename)) {
                return true;
            }
        }
        return false;
    }
}

function getTempNam($prefix = "php")
{
    $tmp = getenv('TMPDIR');
    if ($tmp && @is_writable($tmp)) {

It seems like $tmp can also be of type array; however, parameter $filename of is_writable() does only seem to accept string, maybe add an additional type check?

        $tmpDir = $tmp;
    } elseif (function_exists('sys_get_temp_dir') && @is_writable(sys_get_temp_dir())) {
        $tmpDir = sys_get_temp_dir();
    }
    return tempnam($tmpDir, $prefix);

The variable $tmpDir does not seem to be defined for all execution paths leading up to this point.

}

function file_get_contents_curl($url, $file, $referer = null)
{
    $ch = curl_init();
    // curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
    $f = fopen($file, 'wb');
    if (!$f) {

The condition $f is always false.

        return false;
    }
    curl_setopt($ch, CURLOPT_FILE, $f);
    curl_setopt($ch, CURLOPT_HEADER, 0);
    curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
    curl_setopt($ch, CURLOPT_ENCODING, '');
    curl_setopt($ch, CURLOPT_URL, $url);
    if ($referer) {
        curl_setopt($ch, CURLOPT_REFERER, $referer);
    }
    $result = curl_exec($ch);
    if (!$result) {
        echo curl_error($ch);
    }
    curl_close($ch);
    fclose($f);
    return $result;
}

function getPDOConnection($config)
{
    $db_driver = $config['database_driver'];
    $db_host = $config['database_host'];
    $db_name = $config['database_name'];
    $db_user = $config['database_user'];
    $db_pass = $config['database_password'];
    $db_port = $config['database_port'];
    $pdo = new PDO("$db_driver:host=$db_host;port=$db_port;dbname=$db_name", $db_user, $db_pass);
    $pdo->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_ASSOC);
    $pdo->query("SET NAMES 'UTF8'");
    return $pdo;
}
function trim2($s)
{
    $s = trim($s, " \t\n\r\0\x0B-");
    if ('' === $s) {
        return null;
    } else {
        return $s;
    }
}
function utf8_encode_recursivo($in)
{
    if (is_array($in)) {
        foreach ($in as $key => $value) {
            $out[utf8_encode_recursivo($key)] = utf8_encode_recursivo($value);
        }
    } elseif (is_string($in)) {
        if (!mb_check_encoding($in, 'UTF-8')
            OR !($in === mb_convert_encoding(mb_convert_encoding($in, 'UTF-32', 'UTF-8'), 'UTF-8', 'UTF-32'))) {

As per coding-style, PHP keywords should be in lowercase; expected or, but found OR.

                $in = mb_convert_encoding($in, 'UTF-8');
            }

Closing brace indented incorrectly; expected 8 spaces, found 12

            return $in;
    } else {
        return $in;
    }
    return $out;

The variable $out seems to be defined by a foreach iteration on line 119. Are you sure the iterator is never empty, otherwise this variable is not defined?

}