AuthorizationCode::setSessionStateStorage() - Code Metrics - Inspection of "updated scrutinizer config PROCERGS#666" - PROCERGS/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — issue#666 ( 82e9d5...91903a )

by Guilherme

created 2018-02-15 18:19 UTC

AuthorizationCode::setSessionStateStorage() A

↳ Parent: AuthorizationCode

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\OpenIDBundle\Storage;

use OAuth2\OpenID\Storage\AuthorizationCodeInterface;
use LoginCidadao\OpenIDBundle\Storage\SessionState;
use Doctrine\ORM\EntityManager;

class AuthorizationCode implements AuthorizationCodeInterface
{
    /** @var EntityManager */
    private $em;

    /** @var SessionState */
    private $sessionStateStorage;

    public function __construct(EntityManager $EntityManager)
    {
        $this->em = $EntityManager;
    }

    /**
     * Fetch authorization code data (probably the most common grant type).
     *
     * Retrieve the stored data for the given authorization code.
     *
     * Required for OAuth2::GRANT_TYPE_AUTH_CODE.
     *
     * @param $code
     * Authorization code to be check with.
     *
     * @return
     * An associative array as below, and NULL if the code is invalid
     * @code
     * return array(
     *     "client_id"    => CLIENT_ID,      // REQUIRED Stored client identifier
     *     "user_id"      => USER_ID,        // REQUIRED Stored user identifier
     *     "expires"      => EXPIRES,        // REQUIRED Stored expiration in unix timestamp
     *     "redirect_uri" => REDIRECT_URI,   // REQUIRED Stored redirect URI
     *     "scope"        => SCOPE,          // OPTIONAL Stored scope values in space-separated string
     * );
     * @endcode
     *
     * @see http://tools.ietf.org/html/rfc6749#section-4.1
     *
     * @ingroup oauth2_section_4
     */
    public function getAuthorizationCode($code)
    {
        // Get Code
        $code = $this->em->getRepository('LoginCidadaoOAuthBundle:AuthCode')
            ->findOneBy(array('token' => $code));

        if (!$code) {
            return null;
        }

        if ($code instanceof \LoginCidadao\OAuthBundle\Entity\AuthCode) {
            $response = array(
                'client_id' => $code->getClient()->getClientId(),
                'user_id' => $code->getUser()->getId(),
                'user_id' => $code->getUser()->/** @scrutinizer ignore-call */ getId(),
                'expires' => $code->getExpiresAt(),
                'redirect_uri' => $code->getRedirectUri(),
                'scope' => $code->getScope()
            );
            if ($code->getIdToken()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $response['id_token'] = $code->getIdToken();
            }
            if ($code->getSessionId()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $response['session_id'] = $code->getSessionId();
            }
            return $response;
        }
    }

    /**
     * Take the provided authorization code values and store them somewhere.
     *
     * This function should be the storage counterpart to getAuthCode().
     *
     * If storage fails for some reason, we're not currently checking for
     * any sort of success/failure, so you should bail out of the script
     * and provide a descriptive fail message.
     *
     * Required for OAuth2::GRANT_TYPE_AUTH_CODE.
     *
     * @param $code
     * Authorization code to be stored.
     * @param $client_id
     * Client identifier to be stored.
     * @param $user_id
     * User identifier to be stored.
     * @param string $redirect_uri
     *                             Redirect URI(s) to be stored in a space-separated string.
     * @param int    $expires
     *                             Expiration to be stored as a Unix timestamp.
     * @param string $scope
     *                             (optional) Scopes to be stored in space-separated string.
     *
     * @ingroup oauth2_section_4
     */
    public function setAuthorizationCode($code, $client_id, $user_id,
                                            $redirect_uri, $expires, $scope = null,
                                            $id_token = null)
    {
        $id     = explode('_', $client_id);
        $client = $this->em->getRepository('LoginCidadaoOAuthBundle:Client')
            ->find($id[0]);

        if ($user_id === null) {
            $user = null;
        } else {
            $user = $this->em->getRepository('LoginCidadaoCoreBundle:Person')
                ->find($user_id);
        }

        if (!$client) {
            throw new \Exception('Unknown client identifier');
        }

        $authorizationCode = new \LoginCidadao\OAuthBundle\Entity\AuthCode();
        $authorizationCode->setToken($code);
        $authorizationCode->setClient($client);
        $authorizationCode->setUser($user);
        $authorizationCode->setRedirectUri($redirect_uri);
        $authorizationCode->setExpiresAt($expires);
        $authorizationCode->setScope($scope);
        $authorizationCode->setIdToken($id_token);
        $authorizationCode->setSessionId($this->sessionStateStorage->getSessionId());

        $this->em->persist($authorizationCode);
        $this->em->flush();
    }

    /**
     * once an Authorization Code is used, it must be exipired
     *
     * @see http://tools.ietf.org/html/rfc6749#section-4.1.2
     *
     *    The client MUST NOT use the authorization code
     *    more than once.  If an authorization code is used more than
     *    once, the authorization server MUST deny the request and SHOULD
     *    revoke (when possible) all tokens previously issued based on
     *    that authorization code
     *
     */
    public function expireAuthorizationCode($code)
    {
        $code = $this->em->getRepository('LoginCidadaoOAuthBundle:AuthCode')
            ->findOneBy(array('token' => $code));
        $this->em->remove($code);
        $this->em->flush();
    }

    public function setSessionStateStorage(SessionState $sessionStateStorage)
    {
        $this->sessionStateStorage = $sessionStateStorage;
    }
}


PROCERGS / login-cidadao

Push — issue#666 ( 82e9d5...91903a )

AuthorizationCode::setSessionStateStorage() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like