RemoteClaimController::validateRemoteClaimAction() - Code Metrics - Inspection of "implementing remote claim token check. PROCERGS#66..." - PROCERGS/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — issue#666 ( 8f1392...6be2d0 )

by Guilherme

created 2017-12-08 18:16 UTC

RemoteClaimController::validateRemoteClaimAction() B

↳ Parent: RemoteClaimController

Complexity

Conditions	2
Paths	2

Size

Total Lines	41
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	22
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	41
rs	8.8571

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\RemoteClaimsBundle\Controller;

use FOS\OAuthServerBundle\Security\Authentication\Token\OAuthToken;
use FOS\RestBundle\Controller\Annotations as REST;
use JMS\Serializer\SerializationContext;
use JMS\Serializer\SerializerInterface;
use LoginCidadao\APIBundle\Controller\BaseController;
use LoginCidadao\CoreBundle\Entity\Authorization;
use LoginCidadao\CoreBundle\Entity\AuthorizationRepository;
use LoginCidadao\CoreBundle\LongPolling\LongPollingUtils;
use LoginCidadao\OAuthBundle\Model\AccessTokenManager;
use LoginCidadao\OAuthBundle\Model\ClientInterface;
use LoginCidadao\RemoteClaimsBundle\Model\ClaimProviderInterface;
use LoginCidadao\RemoteClaimsBundle\Model\RemoteClaimAuthorizationInterface;
use LoginCidadao\RemoteClaimsBundle\Model\RemoteClaimInterface;
use LoginCidadao\RemoteClaimsBundle\Model\RemoteClaimManagerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Nelmio\ApiDocBundle\Annotation\ApiDoc;
use LoginCidadao\CoreBundle\Model\PersonInterface;
use LoginCidadao\OAuthBundle\Model\ClientUser;
use LoginCidadao\APIBundle\Security\Audit\Annotation as Audit;
use LoginCidadao\APIBundle\Entity\LogoutKey;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

class RemoteClaimController extends BaseController
{

    /**
     * @REST\Get("/api/v1/validate-claim", name="remote_claims_validate", defaults={"_format"="json"})
     * @REST\View(templateVar="oidc_config")
     */
    public function validateRemoteClaimAction(Request $request)
    {
        /** @var ClaimProviderInterface|ClientInterface $provider */
        $provider = $this->getClient();

        $accessToken = $request->get('claim_access_token');

        /** @var RemoteClaimManagerInterface $manager */
        $manager = $this->get('lc.remote_claims.manager');

        $remoteClaimAuthorization = $manager->getRemoteClaimAuthorizationByAccessToken($provider, $accessToken);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        if (!$remoteClaimAuthorization instanceof RemoteClaimAuthorizationInterface) {
            throw $this->createNotFoundException("Authorization not found");
        }
        $person = $remoteClaimAuthorization->getPerson();
        $client = $remoteClaimAuthorization->getClient();

        /** @var AuthorizationRepository $authorizationRepo */
        $authorizationRepo = $this->getDoctrine()->getRepository('LoginCidadaoCoreBundle:Authorization');

        /** @var Authorization $authorization */
        $authorization = $authorizationRepo->findOneBy([
            'client' => $provider,
            'person' => $person,
        ]);

        /** @var SerializerInterface $serializer */
        $serializer = $this->get('jms_serializer');
        $serializedPerson = $serializer->serialize($person, $this->getSerializationContext($authorization->getScope()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $serializedClient = $serializer->serialize($client, $this->getSerializationContext(['remote_claim']));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $response = [
            'claim_name' => (string)$remoteClaimAuthorization->getClaimName(),
            'userinfo' => $serializedPerson,
            'relying_party' => $serializedClient,
        ];

        $view = $this->view($response);

        return $this->handleView($view);
    }
}


1			<?php
2			/**
3			* This file is part of the login-cidadao project or it's bundles.
4			*
5			* (c) Guilherme Donato <guilhermednt on github>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace LoginCidadao\RemoteClaimsBundle\Controller;
12
13			use FOS\OAuthServerBundle\Security\Authentication\Token\OAuthToken;
14			use FOS\RestBundle\Controller\Annotations as REST;
15			use JMS\Serializer\SerializationContext;
16			use JMS\Serializer\SerializerInterface;
17			use LoginCidadao\APIBundle\Controller\BaseController;
18			use LoginCidadao\CoreBundle\Entity\Authorization;
19			use LoginCidadao\CoreBundle\Entity\AuthorizationRepository;
20			use LoginCidadao\CoreBundle\LongPolling\LongPollingUtils;
21			use LoginCidadao\OAuthBundle\Model\AccessTokenManager;
22			use LoginCidadao\OAuthBundle\Model\ClientInterface;
23			use LoginCidadao\RemoteClaimsBundle\Model\ClaimProviderInterface;
24			use LoginCidadao\RemoteClaimsBundle\Model\RemoteClaimAuthorizationInterface;
25			use LoginCidadao\RemoteClaimsBundle\Model\RemoteClaimInterface;
26			use LoginCidadao\RemoteClaimsBundle\Model\RemoteClaimManagerInterface;
27			use Symfony\Component\HttpFoundation\Request;
28			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
29			use Nelmio\ApiDocBundle\Annotation\ApiDoc;
30			use LoginCidadao\CoreBundle\Model\PersonInterface;
31			use LoginCidadao\OAuthBundle\Model\ClientUser;
32			use LoginCidadao\APIBundle\Security\Audit\Annotation as Audit;
33			use LoginCidadao\APIBundle\Entity\LogoutKey;
34			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
35			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
36
37			class RemoteClaimController extends BaseController
38			{
39
40			/**
41			* @REST\Get("/api/v1/validate-claim", name="remote_claims_validate", defaults={"_format"="json"})
42			* @REST\View(templateVar="oidc_config")
43			*/
44			public function validateRemoteClaimAction(Request $request)
45			{
46			/** @var ClaimProviderInterface\|ClientInterface $provider */
47			$provider = $this->getClient();
48
49			$accessToken = $request->get('claim_access_token');
50
51			/** @var RemoteClaimManagerInterface $manager */
52			$manager = $this->get('lc.remote_claims.manager');
53
54			$remoteClaimAuthorization = $manager->getRemoteClaimAuthorizationByAccessToken($provider, $accessToken);
			0 ignored issues – show Bug introduced 2017-12-08 18:19 UTC by Report Bug Copy Issue Report It seems like `$provider` defined by `$this->getClient()` on line `47` can also be of type `object<LoginCidadao\OAut...\Model\ClientInterface>`; however, `LoginCidadao\RemoteClaim...rizationByAccessToken()` does only seem to accept `object<LoginCidadao\Remo...ClaimProviderInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
55			if (!$remoteClaimAuthorization instanceof RemoteClaimAuthorizationInterface) {
56			throw $this->createNotFoundException("Authorization not found");
57			}
58			$person = $remoteClaimAuthorization->getPerson();
59			$client = $remoteClaimAuthorization->getClient();
60
61			/** @var AuthorizationRepository $authorizationRepo */
62			$authorizationRepo = $this->getDoctrine()->getRepository('LoginCidadaoCoreBundle:Authorization');
63
64			/** @var Authorization $authorization */
65			$authorization = $authorizationRepo->findOneBy([
66			'client' => $provider,
67			'person' => $person,
68			]);
69
70			/** @var SerializerInterface $serializer */
71			$serializer = $this->get('jms_serializer');
72			$serializedPerson = $serializer->serialize($person, $this->getSerializationContext($authorization->getScope()));
			0 ignored issues – show Documentation introduced 2017-12-08 18:19 UTC by Report Bug Copy Issue Report `$this->getSerializationC...horization->getScope())` is of type `object<JMS\Serializer\SerializationContext>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73			$serializedClient = $serializer->serialize($client, $this->getSerializationContext(['remote_claim']));
			0 ignored issues – show Documentation introduced 2017-12-08 18:19 UTC by Report Bug Copy Issue Report `$this->getSerializationC...(array('remote_claim'))` is of type `object<JMS\Serializer\SerializationContext>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74
75			$response = [
76			'claim_name' => (string)$remoteClaimAuthorization->getClaimName(),
77			'userinfo' => $serializedPerson,
78			'relying_party' => $serializedClient,
79			];
80
81			$view = $this->view($response);
82
83			return $this->handleView($view);
84			}
85			}
86

PROCERGS / login-cidadao

Push — issue#666 ( 8f1392...6be2d0 )

RemoteClaimController::validateRemoteClaimAction() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like